From: Finn Thain <fthain@telegraphics.com.au>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Chris Zankel <chris@zankel.net>,
Laurent Vivier <laurent@vivier.eu>,
Geert Uytterhoeven <geert@linux-m68k.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2 05/12] net/sonic: Fix receive buffer handling
Date: Wed, 22 Jan 2020 10:53:04 +1100 (AEDT) [thread overview]
Message-ID: <alpine.LNX.2.21.1.2001221034510.8@nippy.intranet> (raw)
In-Reply-To: <20200121142356.2b17ad74@hermes.lan>
On Tue, 21 Jan 2020, Stephen Hemminger wrote:
> On Wed, 22 Jan 2020 08:22:08 +1100
> Finn Thain <fthain@telegraphics.com.au> wrote:
>
> >
> > +/* Return the array index corresponding to a given Receive Buffer pointer. */
> > +
> > +static inline int index_from_addr(struct sonic_local *lp, dma_addr_t addr,
> > + unsigned int last)
>
> Why the blank line between comment and the start of the function?
>
The driver mostly uses this style:
/*
* We have a good packet(s), pass it/them up the network stack.
*/
static void sonic_rx(struct net_device *dev)
{
}
To my eyes, style I used is the closest readable approximation of the
existing style that doesn't upset checkpatch.
Anyway, I will remove the blank lines.
> Also, the kernel standard is not to use the inline keyword on functions
> and let the compiler decide to inline if it wants to.
OK.
Thanks for your review.
next prev parent reply other threads:[~2020-01-21 23:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 21:22 [PATCH net v2 00/12] Fixes for SONIC ethernet driver Finn Thain
2020-01-21 21:22 ` [PATCH net v2 12/12] net/sonic: Prevent tx watchdog timeout Finn Thain
2020-01-21 21:22 ` [PATCH net v2 06/12] net/sonic: Avoid needless receive descriptor EOL flag updates Finn Thain
2020-01-21 21:22 ` [PATCH net v2 03/12] net/sonic: Use MMIO accessors Finn Thain
2020-01-21 21:22 ` [PATCH net v2 02/12] net/sonic: Clear interrupt flags immediately Finn Thain
2020-01-21 21:22 ` [PATCH net v2 09/12] net/sonic: Quiesce SONIC before re-initializing descriptor memory Finn Thain
2020-01-21 21:22 ` [PATCH net v2 04/12] net/sonic: Fix interface error stats collection Finn Thain
2020-01-21 21:22 ` [PATCH net v2 10/12] net/sonic: Fix command register usage Finn Thain
2020-01-21 21:22 ` [PATCH net v2 05/12] net/sonic: Fix receive buffer handling Finn Thain
2020-01-21 22:23 ` Stephen Hemminger
2020-01-21 23:53 ` Finn Thain [this message]
2020-01-21 21:22 ` [PATCH net v2 01/12] net/sonic: Add mutual exclusion for accessing shared state Finn Thain
2020-01-21 22:19 ` Eric Dumazet
2020-01-21 23:33 ` Finn Thain
2020-01-21 23:52 ` Eric Dumazet
2020-01-22 0:40 ` Finn Thain
2020-01-21 21:22 ` [PATCH net v2 08/12] net/sonic: Fix receive buffer replenishment Finn Thain
2020-01-21 21:22 ` [PATCH net v2 07/12] net/sonic: Improve receive descriptor status flag check Finn Thain
2020-01-21 21:22 ` [PATCH net v2 11/12] net/sonic: Fix CAM initialization Finn Thain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.21.1.2001221034510.8@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=chris@zankel.net \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=laurent@vivier.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox