From mboxrd@z Thu Jan 1 00:00:00 1970 From: Finn Thain Subject: Re: [PATCH net 2/4] net/8390: Fix msg_enable patch snafu Date: Tue, 20 Feb 2018 09:01:11 +1100 (AEDT) Message-ID: References: <20180219.141137.2095980245673495027.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk To: David Miller Return-path: In-Reply-To: <20180219.141137.2095980245673495027.davem@davemloft.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: netdev.vger.kernel.org On Mon, 19 Feb 2018, David Miller wrote: > From: Finn Thain > Date: Sun, 18 Feb 2018 21:39:17 -0500 (EST) > > > The lib8390 module parameter 'msg_enable' doesn't do anything useful: > > it causes an ancient version string to be logged. > > Since you are removing the last reference to this 'version' string > you should remove it as well. > > I'm surprised the compiler doesn't warn about this. > I compile-tested every 8390 module and I didn't come across any compiler bugs. Please take another look. I think you'll find that lib8390.c is always #included by a module which does define that symbol. Thanks. --