From mboxrd@z Thu Jan 1 00:00:00 1970 From: Finn Thain Subject: Re: another cleanup patch gone wrong Date: Fri, 16 Apr 2010 13:21:52 +1000 (EST) Message-ID: References: <1271387506.2298.17.camel@Joe-Laptop.home> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: "David S. Miller" , Paul Gortmaker , netdev@vger.kernel.org, Linux Kernel Mailing List , Linux/m68k To: Joe Perches Return-path: In-Reply-To: <1271387506.2298.17.camel@Joe-Laptop.home> Sender: linux-m68k-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, 15 Apr 2010, Joe Perches wrote: > > Why the macro? You only used it once. > > It's used embedded in the pr_ functions. > It's used more than once. > > > The pr_xxx naming convention belongs to a kernel-wide include file. Is it > > really a good idea to start repurposing it in .c files? > > It's in kernel.h, and yes, it is. > http://lkml.org/lkml/2008/11/12/297 My mistake. Finn