From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ronak Doshi Subject: Re: suspicius csum initialization in vmxnet3_rx_csum Date: Thu, 31 May 2018 11:02:34 -0700 Message-ID: References: <1527151641.3058.32.camel@redhat.com> , <4aab239242c841b8cbff08eea5f340f89f368a42.camel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Cc: Guolin Yang , Neil Horman , Boon Ang , Louis Luo , To: Paolo Abeni Return-path: Received: from ex13-edg-ou-002.vmware.com ([208.91.0.190]:15514 "EHLO EX13-EDG-OU-002.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755879AbeEaSCf (ORCPT ); Thu, 31 May 2018 14:02:35 -0400 In-Reply-To: <4aab239242c841b8cbff08eea5f340f89f368a42.camel@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 30 May 2018, Paolo Abeni wrote: > Hi, > > On Thu, 2018-05-24 at 21:48 +0000, Guolin Yang wrote: > > Yes, that code is not correct, we should fix that code > > Did you have any chance to address the issue and/or to give a more in- > deepth look to the change proposed in my initial email? > Hi Paolo, Can you provide the esx build you are using? It can be found using "vmware -vl" on ESX host. Did you try your proposed fix and did it work? Are you sure the packet hits the below if block and not the else block? I still don't think the ICMP packet will go through the below if block. if (gdesc->rcd.csum) { skb->csum = htons(gdesc->rcd.csum); skb->ip_summed = CHECKSUM_PARTIAL; } else { skb_checksum_none_assert(skb); } The vmxnet3 emulation does not calculate rcd.csum for ICMP packet and hence should go through the else block i.e. checksum none. Thanks, Ronak