From: Mat Martineau <mathew.j.martineau@linux.intel.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
mptcp@lists.01.org
Subject: Re: [MPTCP] [PATCH net 1/2] mptcp: cache msk on MP_JOIN init_req
Date: Wed, 17 Jun 2020 11:13:22 -0700 (PDT) [thread overview]
Message-ID: <alpine.OSX.2.22.394.2006171112280.1663@mjmartin-mac01.local> (raw)
In-Reply-To: <3213f22a1fa85217032ba3de482f2209c63f2870.1592388398.git.pabeni@redhat.com>
On Wed, 17 Jun 2020, Paolo Abeni wrote:
> The msk ownership is transferred to the child socket at
> 3rd ack time, so that we avoid more lookups later. If the
> request does not reach the 3rd ack, the MSK reference is
> dropped at request sock release time.
>
> As a side effect, fallback is now tracked by a NULL msk
> reference instead of zeroed 'mp_join' field. This will
> simplify the next patch.
>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> ---
> net/mptcp/protocol.h | 1 +
> net/mptcp/subflow.c | 39 +++++++++++++++++----------------------
> 2 files changed, 18 insertions(+), 22 deletions(-)
>
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
--
Mat Martineau
Intel
next prev parent reply other threads:[~2020-06-17 18:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 10:08 [PATCH net 0/2] mptcp: cope with syncookie on MP_JOINs Paolo Abeni
2020-06-17 10:08 ` [PATCH net 1/2] mptcp: cache msk on MP_JOIN init_req Paolo Abeni
2020-06-17 18:13 ` Mat Martineau [this message]
2020-06-17 10:08 ` [PATCH net 2/2] mptcp: drop MP_JOIN request sock on syn cookies Paolo Abeni
2020-06-17 18:14 ` [MPTCP] " Mat Martineau
2020-06-19 3:26 ` [PATCH net 0/2] mptcp: cope with syncookie on MP_JOINs David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.OSX.2.22.394.2006171112280.1663@mjmartin-mac01.local \
--to=mathew.j.martineau@linux.intel.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=mptcp@lists.01.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).