From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21791C433E0 for ; Wed, 17 Jun 2020 18:13:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0927921789 for ; Wed, 17 Jun 2020 18:13:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727090AbgFQSN1 (ORCPT ); Wed, 17 Jun 2020 14:13:27 -0400 Received: from mga04.intel.com ([192.55.52.120]:44229 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727083AbgFQSNY (ORCPT ); Wed, 17 Jun 2020 14:13:24 -0400 IronPort-SDR: QElvJtrigecWuoAZAl5E1p9C5+BZOx8UbrI+w/Hvod0gVv2/Lby392xSIkVG4KWJWH9fVehnoi yGwoMUbxyZJw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2020 11:13:23 -0700 IronPort-SDR: hRQTzk2CIaJmqpMpIrcppylAXyZj+pmaZl0WeSVMjs7d61eRSMfwhXdK8EKkOgoaRJ5RSM/td9 zsyan//T72mQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,523,1583222400"; d="scan'208";a="476943896" Received: from unknown (HELO [10.254.109.153]) ([10.254.109.153]) by fmsmga005.fm.intel.com with ESMTP; 17 Jun 2020 11:13:22 -0700 Date: Wed, 17 Jun 2020 11:13:22 -0700 (PDT) From: Mat Martineau X-X-Sender: mjmartin@mjmartin-mac01.local To: Paolo Abeni cc: netdev@vger.kernel.org, "David S. Miller" , Jakub Kicinski , mptcp@lists.01.org Subject: Re: [MPTCP] [PATCH net 1/2] mptcp: cache msk on MP_JOIN init_req In-Reply-To: <3213f22a1fa85217032ba3de482f2209c63f2870.1592388398.git.pabeni@redhat.com> Message-ID: References: <3213f22a1fa85217032ba3de482f2209c63f2870.1592388398.git.pabeni@redhat.com> User-Agent: Alpine 2.22 (OSX 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 17 Jun 2020, Paolo Abeni wrote: > The msk ownership is transferred to the child socket at > 3rd ack time, so that we avoid more lookups later. If the > request does not reach the 3rd ack, the MSK reference is > dropped at request sock release time. > > As a side effect, fallback is now tracked by a NULL msk > reference instead of zeroed 'mp_join' field. This will > simplify the next patch. > > Signed-off-by: Paolo Abeni > --- > net/mptcp/protocol.h | 1 + > net/mptcp/subflow.c | 39 +++++++++++++++++---------------------- > 2 files changed, 18 insertions(+), 22 deletions(-) > Reviewed-by: Mat Martineau -- Mat Martineau Intel