From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 890DFC433DF for ; Wed, 17 Jun 2020 18:14:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E8D82070A for ; Wed, 17 Jun 2020 18:14:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727768AbgFQSOb (ORCPT ); Wed, 17 Jun 2020 14:14:31 -0400 Received: from mga03.intel.com ([134.134.136.65]:40811 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727017AbgFQSOb (ORCPT ); Wed, 17 Jun 2020 14:14:31 -0400 IronPort-SDR: +EfUVD1r5DFxjfITfpjcIjH70v0I+ra6Lrt+v555PlFdSv6GydfCMPBkc30axmzrcslUfSNuFX ZSWyEVQpUtWA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2020 11:14:30 -0700 IronPort-SDR: U6V53XQvCVt5x47K2QyEWAQRtARrdCQo2ZqnhcZ60yQq16obFNoLnJmll3rX2yaaotjhdXy+1U WwZeXXaI9Tdw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,523,1583222400"; d="scan'208";a="299387172" Received: from unknown (HELO [10.254.109.153]) ([10.254.109.153]) by fmsmga004.fm.intel.com with ESMTP; 17 Jun 2020 11:14:28 -0700 Date: Wed, 17 Jun 2020 11:14:28 -0700 (PDT) From: Mat Martineau X-X-Sender: mjmartin@mjmartin-mac01.local To: Paolo Abeni cc: netdev@vger.kernel.org, "David S. Miller" , Jakub Kicinski , mptcp@lists.01.org Subject: Re: [MPTCP] [PATCH net 2/2] mptcp: drop MP_JOIN request sock on syn cookies In-Reply-To: <3aff0acec0b89a55fdae02194036f34be56b545c.1592388398.git.pabeni@redhat.com> Message-ID: References: <3aff0acec0b89a55fdae02194036f34be56b545c.1592388398.git.pabeni@redhat.com> User-Agent: Alpine 2.22 (OSX 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 17 Jun 2020, Paolo Abeni wrote: > Currently any MPTCP socket using syn cookies will fallback to > TCP at 3rd ack time. In case of MP_JOIN requests, the RFC mandate > closing the child and sockets, but the existing error paths > do not handle the syncookie scenario correctly. > > Address the issue always forcing the child shutdown in case of > MP_JOIN fallback. > > Fixes: ae2dd7164943 ("mptcp: handle tcp fallback when using syn cookies") > Signed-off-by: Paolo Abeni > --- > net/mptcp/subflow.c | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) Reviewed-by: Mat Martineau -- Mat Martineau Intel