From: Meelis Roos <mroos@linux.ee>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] ibmtr: fix tr%d in dmesg
Date: Tue, 5 Oct 2010 00:12:33 +0300 (EEST) [thread overview]
Message-ID: <alpine.SOC.1.00.1010042301100.5418@math.ut.ee> (raw)
In-Reply-To: <20101003.205632.104074109.davem@davemloft.net>
> Instead, the more correct way to fit this is to use dev_info(),
> dev_err(), and friends. It will both print the correct stuff,
> and also document the probing path messages that occur before
> the net device is registered.
OK, fair enough.
I remember trying dev_info first and getting null from it. Retried, got
(null): ISA P&P 16/4 Adapter/A (short) | 16/4 ISA-16 Adapter found
So it seems dev_info does not know about 16-bit pcmcia devices or
buses... dev_driver_string() finds neither dev->name, dev->bus->name nor
dev->class->name. Will dig into this some other day.
--
Meelis Roos (mroos@linux.ee)
prev parent reply other threads:[~2010-10-04 21:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-02 18:35 [PATCH] ibmtr: fix tr%d in dmesg Meelis Roos
2010-10-04 3:56 ` David Miller
2010-10-04 21:12 ` Meelis Roos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.SOC.1.00.1010042301100.5418@math.ut.ee \
--to=mroos@linux.ee \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).