From: Meelis Roos <mroos-Y27EyoLml9s@public.gmane.org>
To: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jouni Malinen <j@w1.fi>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH] fix hostap registration order
Date: Fri, 10 Dec 2010 01:19:23 +0200 (EET) [thread overview]
Message-ID: <alpine.SOC.1.00.1012100020110.26229@math.ut.ee> (raw)
In 2.6.37-rc4, hostap_pci init gives a WARNING with backtrace telling
that netif_stop_queue is called before register_netdev. Fix it by moving
this call after register_netdev. Removes the warning and seems to work,
but why is the call to netif_stop_queue needed at all after
register_netdev?
Signed-off-by: Meelis Roos <mroos-Y27EyoLml9s@public.gmane.org>
diff --git a/drivers/net/wireless/hostap/hostap_hw.c b/drivers/net/wireless/hostap/hostap_hw.c
index b7cb165..cc760c5 100644
--- a/drivers/net/wireless/hostap/hostap_hw.c
+++ b/drivers/net/wireless/hostap/hostap_hw.c
@@ -3253,6 +3253,8 @@ while (0)
}
printk(KERN_INFO "%s: Registered netdevice %s\n", dev_info, dev->name);
+ netif_stop_queue(dev);
+
hostap_init_data(local);
return dev;
diff --git a/drivers/net/wireless/hostap/hostap_main.c b/drivers/net/wireless/hostap/hostap_main.c
index 25a2722..0f1b202 100644
--- a/drivers/net/wireless/hostap/hostap_main.c
+++ b/drivers/net/wireless/hostap/hostap_main.c
@@ -100,6 +100,7 @@ struct net_device * hostap_add_interface(struct local_info *local,
printk(KERN_DEBUG "%s: registered netdevice %s\n",
mdev->name, dev->name);
+ netif_stop_queue(dev);
return dev;
}
@@ -891,7 +892,6 @@ void hostap_setup_dev(struct net_device *dev, local_info_t *local,
SET_ETHTOOL_OPS(dev, &prism2_ethtool_ops);
- netif_stop_queue(dev);
}
static int hostap_enable_hostapd(local_info_t *local, int rtnl_locked)
--
Meelis Roos (mroos-Y27EyoLml9s@public.gmane.org)
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2010-12-09 23:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 23:19 Meelis Roos [this message]
2010-12-10 3:53 ` [PATCH] fix hostap registration order David Miller
2010-12-10 7:19 ` Meelis Roos
2010-12-10 17:47 ` David Miller
2010-12-17 21:27 ` [PATCH] hostap: remove netif_stop_queue from init Meelis Roos
[not found] ` <alpine.SOC.1.00.1012172324340.24976-ptEonEWSGqKptlylMvRsHA@public.gmane.org>
2010-12-17 21:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.SOC.1.00.1012100020110.26229@math.ut.ee \
--to=mroos-y27eyolml9s@public.gmane.org \
--cc=j@w1.fi \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).