netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jae-Hyun Hwang <jhhwang@os.korea.ac.kr>
To: netdev@vger.kernel.org
Subject: [PATCH] tcp: for tcp westwood
Date: Mon, 4 Jan 2010 17:18:49 +0900	[thread overview]
Message-ID: <alpine.WNT.2.00.1001041709170.3252@jhhwang> (raw)

From: Jae-Hyun Hwang <jhhwang@os.korea.ac.kr>

Current net/ipv4/tcp_westwood.c seems to be unnatural when compared with Westwood papers.
Since Linux TCP calls '.ssthresh' interface whenever packet loss is 
detected, it is more natural that the interface points to 'tcp_westwood_bw_rttmin' function, not Reno's function.
This patch also enables Westwood to perform its algorithm when CA_EVENT_LOSS event is generated as explained in the papers.

Signed-off-by: Jae-Hyun Hwang <jhhwang@os.korea.ac.kr>

--- linux-2.6.32.2/net/ipv4/tcp_westwood.c.orig	2009-12-28 13:35:42.000000000 +0900
+++ linux-2.6.32.2/net/ipv4/tcp_westwood.c	2009-12-28 13:36:54.000000000 +0900
@@ -232,12 +232,7 @@ static void tcp_westwood_event(struct so
 		westwood_fast_bw(sk);
 		break;
 
-	case CA_EVENT_COMPLETE_CWR:
-		tp->snd_cwnd = tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk);
-		break;
-
 	case CA_EVENT_FRTO:
-		tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk);
 		/* Update RTT_min when next ack arrives */
 		w->reset_rtt_min = 1;
 		break;
@@ -274,9 +269,8 @@ static void tcp_westwood_info(struct soc
 
 static struct tcp_congestion_ops tcp_westwood = {
 	.init		= tcp_westwood_init,
-	.ssthresh	= tcp_reno_ssthresh,
+	.ssthresh	= tcp_westwood_bw_rttmin,
 	.cong_avoid	= tcp_reno_cong_avoid,
-	.min_cwnd	= tcp_westwood_bw_rttmin,
 	.cwnd_event	= tcp_westwood_event,
 	.get_info	= tcp_westwood_info,
 	.pkts_acked	= tcp_westwood_pkts_acked,
--

             reply	other threads:[~2010-01-04  8:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-04  8:18 Jae-Hyun Hwang [this message]
2010-01-04 16:43 ` [PATCH] tcp: for tcp westwood Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.WNT.2.00.1001041709170.3252@jhhwang \
    --to=jhhwang@os.korea.ac.kr \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).