From: Florian Westphal <fw@strlen.de>
To: Zhiling Zou <zhilinz@nebusec.ai>
Cc: pablo@netfilter.org, netfilter-devel@vger.kernel.org,
netdev@vger.kernel.org, phil@nwl.cc, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, kaber@trash.net, zhaojignmin@hotmail.com,
vega@nebusec.ai
Subject: Re: [PATCH nf v3 1/1] netfilter: validate L4 headers after userspace packet writes
Date: Sat, 1 Aug 2026 14:58:08 +0200 [thread overview]
Message-ID: <am3tYPxeqwqOo9kP@strlen.de> (raw)
In-Reply-To: <587830a57a593c4b621f7e8e94b2ddc73e6becb0.1785468829.git.zhilinz@nebusec.ai>
Zhiling Zou <zhilinz@nebusec.ai> wrote:
> Extend NFQUEUE payload validation to check the final L4 protocol and
> known base headers after IPv4 options or IPv6 extension headers. Reject
> packets whose L4 protocol no longer matches an attached non-template
> conntrack entry, and validate TCP data offset before reinjection. Unknown
> L4 protocols are left to their normal protocol handlers.
Nfqueue part will need to check for the ip frag case as noted by AI review, but other than that this LGTM.
This also means we should return false (i.e. drop) in case we have an
ip fragment with a conntrack attached to it.
prev parent reply other threads:[~2026-08-01 12:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 3:48 [PATCH nf v3 1/1] netfilter: validate L4 headers after userspace packet writes Zhiling Zou
2026-08-01 12:58 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=am3tYPxeqwqOo9kP@strlen.de \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kaber@trash.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
--cc=vega@nebusec.ai \
--cc=zhaojignmin@hotmail.com \
--cc=zhilinz@nebusec.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox