From: Jiri Pirko <jiri@resnulli.us>
To: Leon Romanovsky <leon@kernel.org>
Cc: linux-rdma@vger.kernel.org, cgroups@vger.kernel.org,
netdev@vger.kernel.org, linux-s390@vger.kernel.org,
linux-kselftest@vger.kernel.org, jgg@ziepe.ca, parav@nvidia.com,
mbloch@nvidia.com, cmeiohas@nvidia.com,
roman.gushchin@linux.dev, bvanassche@acm.org,
zyjzyj2000@gmail.com, shuah@kernel.org, tj@kernel.org,
mkoutny@suse.com, hannes@cmpxchg.org, alibuda@linux.alibaba.com,
dust.li@linux.alibaba.com, sidraya@linux.ibm.com,
wenjia@linux.ibm.com, yanjun.zhu@linux.dev, cui.tao@linux.dev
Subject: Re: [PATCH rdma-next v3 00/14] RDMA: Make device names unique per net namespace
Date: Wed, 22 Jul 2026 15:01:30 +0200 [thread overview]
Message-ID: <amC-_-7QZCPckp6e@FV6GYCPJ69> (raw)
In-Reply-To: <20260722115323.GY110966@unreal>
Wed, Jul 22, 2026 at 01:53:23PM +0200, leon@kernel.org wrote:
>On Wed, Jul 22, 2026 at 01:19:00PM +0200, Jiri Pirko wrote:
>> Thu, Jul 16, 2026 at 03:23:01PM +0200, jiri@resnulli.us wrote:
>> >From: Jiri Pirko <jiri@nvidia.com>
>> >
>> >RDMA device names are unique system-wide today:
>> >__ib_device_get_by_name() checks a requested name against every
>> >registered device regardless of the network namespace it lives in.
>> >A device in one network namespace therefore cannot use a name already
>> >taken in another, even in exclusive netns mode (netns_mode=0) where
>> >the two are otherwise isolated. Net devices have no such restriction -
>> >their names only need to be unique within a network namespace.
>> >
>> >This series makes RDMA device names unique per network namespace,
>> >matching net device semantics, and adapts the users that assumed
>> >system-wide unique names.
>> >
>> >Scoping reuses the existing rdma_dev_access_netns() predicate, so
>> >behavior only changes in exclusive mode:
>> > - shared mode (default): names stay unique system-wide, no change;
>> > - exclusive mode: names only need to be unique within a namespace;
>> > - CONFIG_NET_NS=n: everything is init_net, names stay system-wide
>> > unique.
>> >
>> >There are two users that cannot be made per-namespace and are
>> >documented as known limitations instead of changed:
>> > - the rdma_cm configfs tree: configfs has no network namespace
>> > support, so it cannot represent two same-named devices;
>> > - SELinux ibendport labelling: endports are labelled by (device
>> > name, port) from a global policy; distinguishing same-named
>> > devices would need net namespace support in the SELinux policy
>> > language and tooling.
>> >
>> >Tested with the new rxe_netns_names kselftest added in the last patch.
>>
>> This looks like good to go. All Sashiko findings are false positive or
>> unrelated. Care to merge? Thanks!
>
>We usually take extra time before merging complex changes touching
>core or UAPI code.
Sure, I just wanted to let you know the ball is on your side. Take your
time of course :)
Thanks!
prev parent reply other threads:[~2026-07-22 13:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 13:23 [PATCH rdma-next v3 00/14] RDMA: Make device names unique per net namespace Jiri Pirko
2026-07-16 13:23 ` [PATCH rdma-next v3 01/14] RDMA/core: Pass the net namespace to the device name lookups Jiri Pirko
2026-07-16 13:23 ` [PATCH rdma-next v3 02/14] RDMA/core: Handle device name conflicts when changing net namespace Jiri Pirko
2026-07-16 13:23 ` [PATCH rdma-next v3 03/14] RDMA/core: Support renaming a device when changing its " Jiri Pirko
2026-07-16 13:23 ` [PATCH rdma-next v3 04/14] RDMA/nldev: Report net namespace move errors through extack Jiri Pirko
2026-07-16 13:23 ` [PATCH rdma-next v3 05/14] RDMA/nldev: Allow setting the device name while changing net namespace Jiri Pirko
2026-07-16 13:23 ` [PATCH rdma-next v3 06/14] net/smc: Look up the pnetid ib device within the " Jiri Pirko
2026-07-16 13:23 ` [PATCH rdma-next v3 07/14] RDMA/srp: Make the SRP sysfs class net namespace aware Jiri Pirko
2026-07-16 13:23 ` [PATCH rdma-next v3 08/14] RDMA/cgroup: Disambiguate devices across net namespaces Jiri Pirko
2026-07-16 13:23 ` [PATCH rdma-next v3 09/14] RDMA/cma: Document that CM configfs cannot be net namespace scoped Jiri Pirko
2026-07-16 13:23 ` [PATCH rdma-next v3 10/14] RDMA/core: Document the SELinux ibendport net namespace limitation Jiri Pirko
2026-07-16 13:23 ` [PATCH rdma-next v3 11/14] RDMA/core: Make device names unique per net namespace Jiri Pirko
2026-07-16 13:23 ` [PATCH rdma-next v3 12/14] RDMA/rxe: Allow queue VMAs to outlive ucontexts Jiri Pirko
2026-07-16 13:23 ` [PATCH rdma-next v3 13/14] RDMA/rxe: Implement disassociate_ucontext callback Jiri Pirko
2026-07-16 13:23 ` [PATCH rdma-next v3 14/14] RDMA/selftests: Add rxe_netns_names test Jiri Pirko
2026-07-17 4:22 ` Zhu Yanjun
2026-07-22 11:19 ` [PATCH rdma-next v3 00/14] RDMA: Make device names unique per net namespace Jiri Pirko
2026-07-22 11:53 ` Leon Romanovsky
2026-07-22 13:01 ` Jiri Pirko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amC-_-7QZCPckp6e@FV6GYCPJ69 \
--to=jiri@resnulli.us \
--cc=alibuda@linux.alibaba.com \
--cc=bvanassche@acm.org \
--cc=cgroups@vger.kernel.org \
--cc=cmeiohas@nvidia.com \
--cc=cui.tao@linux.dev \
--cc=dust.li@linux.alibaba.com \
--cc=hannes@cmpxchg.org \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=mkoutny@suse.com \
--cc=netdev@vger.kernel.org \
--cc=parav@nvidia.com \
--cc=roman.gushchin@linux.dev \
--cc=shuah@kernel.org \
--cc=sidraya@linux.ibm.com \
--cc=tj@kernel.org \
--cc=wenjia@linux.ibm.com \
--cc=yanjun.zhu@linux.dev \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox