From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA587411FA5 for ; Wed, 22 Jul 2026 17:20:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784740812; cv=none; b=iArQlIjdImIQ/zSjQDfNtfdEwfB0Xv36heZWAqC3q6F1gio3VxT5BNg/RaIdDRMc9hU7bQ96NEbguBKeUZylOUDG/dtJnVTJVq4i0cKSbtXP4wzMfuCPCTmUOhelEVQVQzu45T427f4FgjvMxmEC+kz15Ix2nNC+03vHhlBi27o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784740812; c=relaxed/simple; bh=2DNM5hwTyYjmClgefcOyZjDARMLTZoKh5uOhfdL0aZ4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jJUFHK3ciE8eVTz1ba9RarB+rtGURTa+cMim6CKJcQQ8kAG7hXbFPoty5VlF2E4fgtsph2YTYWQ3GwAUTf2mbDlqxm0j0ez9ahloWqPAz60+cvAgFxupySWXCckqwlCV8YXAG+g26J/eQitmvSsQ/Kcpn9V34CWXyGIpyQFRSkE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ENV5ITnW; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ENV5ITnW" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2caf228a910so102418395ad.2 for ; Wed, 22 Jul 2026 10:20:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784740810; x=1785345610; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=L/P5jmNBEnuW7gDGxtookRVKN0SYP+YjEdzh1uXpFYw=; b=ENV5ITnWAyFfjyKmrc/Xq8YW8xaiVOqYAi/1bsRbF9239teiy8RNDNge0y40wcP1/U TAhXb//pGwrgyO7Gmq60e+4ca/8JiklzyMt2n8dNS3Pv3jJBdK8SNc0ckSog/DJ6NM9t s0TcP3rCvlHfuewKAfYm2I0r1J+AYDg1NG6nCUeeiyTBJvMq1LESpEhdqVqOrMGPAtBI WUtEc8L7qHrJ5gR2H2yTbGYA6cFUNcPAYyErFJzJyhpm4/lRqwvRtOdiJ/AirNQPayqN BuOqzStBPXlt1pfQyYcaxPwqkZmxcLnDtstbkVQGQChVuw7vLDIObGWRgMVKw8hQ3b16 xzug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784740810; x=1785345610; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=L/P5jmNBEnuW7gDGxtookRVKN0SYP+YjEdzh1uXpFYw=; b=TIt1t4MTz1InKRqu95P5U4unVADbIBOlH45h45y3TmXRhnzY5B/Cf10eiDkQs096Y9 nDjvEWGR5qzHSpnIh5qdoADSUCnUaAD/A2Q+PwBVtAaIQetrTzFzp9eMRzskSTHyOd0/ GFH/Y/mOGhLQojDiRRKlAPhSLY2m9lpNsBBe7aUSDE80XOYYPDITr/OyvJIBZzM8pmWw 4LHGv+zDX7BszIUf9VMvifoKEjnFyV0akLOh15ia/u920qEOkaXUajuzONcb/evom0X/ SkQdXjQ6FBf1wDTUlPMtJjZ1TJnwUQarxEkgMz373mGs7i593duet3xqbtLwnZ3ZkxJ2 nZRw== X-Forwarded-Encrypted: i=1; AHgh+RpEBnpNRfZt/RI/9TTsSDoq5OqyE6qpUO06ccAI7U//yZRx2eyO3Dm34dn/mpYyiZN4A0c/Oqs=@vger.kernel.org X-Gm-Message-State: AOJu0YySdkes7ywlWTnWTfGs7W46yFBAuaU6j+qePNz+gKIMbRd2Xk4Q q5UrsG3INNtNGYXS+WQJpzEECy8zlE4AjZ5cgrKzyk0fkovqpuZs+aD8xv5vFGh1 X-Gm-Gg: AR+sD11NDjfvJs+2oiPi1Bz/x1sxKFIwcM969HfrOIigdPH8HINtY/fE5IrzstvJ1UV aXfryo4nWu5zAJQeu9q8B2OVdl3Xz5/L3ttgzXrAKDZHq3b2L6tVZ53a8EFsQQvhTicm94iTh4W pg6Zeexs+bTaVI3S/9Od8ibB3ezUvr2tvvlBhwo3Ff1dWm9S25XAepmVB91100HMiLHBnVNhr/m PUPPSLW/IYm6se8RWGWstzz1V8WzFwyZYLHqmtpfmCn7npBmbXnjoTKfwKMTNndAvj6br26KY+X 0pQuijkq0zG4BNnB7XanjUpaKEzrxWOrIqpV2/qSYO+FCVlTvOgy7oFZFwweCwehT00buBY79PX C5YutgbJ2D7+cDKN0V8apakkSTF1l201pVHWqQXSDmQIbmFCsBMqEJXTYx7qI9pJ4FgyRNSZgC4 ye1LJBfyUCn/qMU/IKX9AP0q9XioNnw+Mxcg== X-Received: by 2002:a17:903:1c8:b0:2cc:f7c6:834e with SMTP id d9443c01a7336-2cf349a3e33mr255048305ad.32.1784740810011; Wed, 22 Jul 2026 10:20:10 -0700 (PDT) Received: from devvm29614.prn0.facebook.com ([2a03:2880:ff:45::]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf8f2e6247sm18204425ad.54.2026.07.22.10.20.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 10:20:09 -0700 (PDT) Date: Wed, 22 Jul 2026 10:20:07 -0700 From: Bobby Eshleman To: Gal Pressman Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , netdev@vger.kernel.org, Shuah Khan , Andy Gospodarek , Pavan Chebbi , Michael Chan , linux-kselftest@vger.kernel.org, Nimrod Oren Subject: Re: [PATCH net] selftests: drv-net: rss_ctx: fix persist tests skip on IPv6 setups Message-ID: References: <20260722123844.1673299-1-gal@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260722123844.1673299-1-gal@nvidia.com> On Wed, Jul 22, 2026 at 03:38:44PM +0300, Gal Pressman wrote: > test_rss_context_persist_ifupdown() cycles the interface down/up and > pings the remote host before verifying the contexts survived. > > When using IPv6, the down operation deletes the configured IPv6 address > (default keep_addr_on_down=0) and nothing restores it after the up, so > all ping attempts fail and both tests skip with "Cannot reach remote > host after interface up". > > Set the interface's keep_addr_on_down sysctl around the flap to retain > the address. > > Fixes: ce5a0f4612db ("selftests: drv-net: rss_ctx: test RSS contexts persist after ifdown/up") > Reviewed-by: Nimrod Oren > Signed-off-by: Gal Pressman > --- > Disclaimer: I'm not sure if this should go to net or net-next. > --- > tools/testing/selftests/drivers/net/hw/rss_ctx.py | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/tools/testing/selftests/drivers/net/hw/rss_ctx.py b/tools/testing/selftests/drivers/net/hw/rss_ctx.py > index f36f76d6ca59..eeea2fb292ac 100755 > --- a/tools/testing/selftests/drivers/net/hw/rss_ctx.py > +++ b/tools/testing/selftests/drivers/net/hw/rss_ctx.py > @@ -938,6 +938,13 @@ def test_rss_context_persist_ifupdown(cfg, pre_down=False): > ethtool(f"-X {cfg.ifname} equal 2") > defer(ethtool, f"-X {cfg.ifname} default") > > + # IPv6 addresses are deleted on admin down and not restored on up > + knob = f"net/ipv6/conf/{cfg.ifname}/keep_addr_on_down" > + probe = cmd(f"sysctl -n {knob}", fail=False) > + if probe.ret == 0: > + cmd(f"sysctl -qw {knob}=1") > + defer(cmd, f"sysctl -qw {knob}={probe.stdout.strip()}") > + > ifup = defer(ip, f"link set dev {cfg.ifname} up") > if pre_down: > ip(f"link set dev {cfg.ifname} down") > -- > 2.54.0 > Makes sense to me. Reviewed-by: Bobby Eshleman