Netdev List
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jaeyeong Lee <iostreampy@proton.me>
Cc: netfilter-devel@vger.kernel.org, fw@strlen.de, phil@nwl.cc,
	sveyret@gmail.com, coreteam@netfilter.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: conntrack: prevent helper extension relocation
Date: Thu, 23 Jul 2026 12:14:51 +0200	[thread overview]
Message-ID: <amHpm2FBj8QSgI4W@chamomile> (raw)
In-Reply-To: <20260715144755.00ea7dfcd9f@proton.me>

Hi,

On Wed, Jul 15, 2026 at 02:48:23PM +0000, Jaeyeong Lee wrote:
> nf_ct_ext_add() may relocate an unconfirmed conntrack's extension blob
> when the current allocation is too small. struct nf_conn_help embeds the
> hlist head for the master's expectations. The first expectation's
> lnode.pprev therefore points into that extension blob.
>
> An nftables CT expectation object can link an expectation before a later
> NAT expression adds extensions to the same unconfirmed conntrack. If an
> addition relocates the blob, the copied hlist head still points to the
> expectation, but the expectation's pprev continues to point into the
> freed old blob. Removing the expectation later executes hlist_del_rcu()
> and writes through this stale pointer.

Thanks for your patch.

For the record, I'm exploring an alternative fix from nft_ct
expectation support itself, patch should be available in the next
days.

      reply	other threads:[~2026-07-23 10:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-15 14:48 [PATCH nf] netfilter: conntrack: prevent helper extension relocation Jaeyeong Lee
2026-07-23 10:14 ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=amHpm2FBj8QSgI4W@chamomile \
    --to=pablo@netfilter.org \
    --cc=coreteam@netfilter.org \
    --cc=fw@strlen.de \
    --cc=iostreampy@proton.me \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=phil@nwl.cc \
    --cc=sveyret@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox