From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: Cen Zhang <blbllhy@gmail.com>
Cc: Stanislav Fomichev <sdf.kernel@gmail.com>,
<magnus.karlsson@intel.com>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<sdf@fomichev.me>, <horms@kernel.org>, <netdev@vger.kernel.org>,
<bpf@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<AutonomousCodeSecurity@microsoft.com>,
<tgopinath@linux.microsoft.com>, <kys@microsoft.com>
Subject: Re: [PATCH net v2] xsk: reject undersized tx_metadata at runtime validation
Date: Thu, 23 Jul 2026 14:18:59 +0200 [thread overview]
Message-ID: <amIGs3ek+0vOp5cd@boxer> (raw)
In-Reply-To: <CAB8m9WjDoHb67ixPVs=6XgFfGP2D4kqM_SSUj5as=xegF63NMQ@mail.gmail.com>
On Thu, Jul 23, 2026 at 08:06:10AM -0400, Cen Zhang wrote:
> On Wed, Jul 22, 2026 at 10:55:17AM -0700, Stanislav Fomichev wrote:
> > Hmm, the AI review points out another set of TOCTOU issues :-/ I wonder
> > whether want to go all in and rewrite the users to have a copy
> > of metadata? Something like the following below, build tested only,
> > any issues with that?
>
> I applied your proposed patch and tested it against my local reproducer
> -- the bug is gone.
>
> > Maybe you want to take ownership of this patch and run the proposed
> > resolution against internal AI review?
>
> Please go ahead and carry this forward. Happy to help test further
> if needed.
Let's see whether Stan is ok with that, you can get credit via
Reported-by: tag or you can continue working on this, that was only a
suggestion, so I hope you did not find it offensive.
next prev parent reply other threads:[~2026-07-23 12:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 4:13 [PATCH net v2] xsk: reject undersized tx_metadata at runtime validation Cen Zhang (Microsoft)
2026-07-22 17:55 ` Stanislav Fomichev
2026-07-23 10:34 ` Maciej Fijalkowski
2026-07-23 12:06 ` Cen Zhang
2026-07-23 12:18 ` Maciej Fijalkowski [this message]
2026-07-23 12:26 ` Cen Zhang
2026-07-23 17:14 ` Stanislav Fomichev
2026-07-23 15:16 ` Alexander Lobakin
2026-07-23 17:15 ` Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amIGs3ek+0vOp5cd@boxer \
--to=maciej.fijalkowski@intel.com \
--cc=AutonomousCodeSecurity@microsoft.com \
--cc=blbllhy@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf.kernel@gmail.com \
--cc=sdf@fomichev.me \
--cc=tgopinath@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox