Netdev List
 help / color / mirror / Atom feed
From: Charles Perry <charles.perry@microchip.com>
To: Nathan Whitehorn <nwhitehorn@pa.msu.edu>
Cc: <netdev@vger.kernel.org>, <theo.lebrun@bootlin.com>,
	<conor.dooley@microchip.com>, <charles.perry@microchip.com>,
	<andrew@lunn.ch>
Subject: Re: [PATCH net-next v2 0/2] net: macb: Updated patches for 1000BASE-X support
Date: Thu, 23 Jul 2026 12:01:15 -0700	[thread overview]
Message-ID: <amJk+0Yew01OV6lz@bby-cbu-swbuild03.eng.microchip.com> (raw)
In-Reply-To: <20260721180158.13014-1-nwhitehorn@pa.msu.edu>

On Tue, Jul 21, 2026 at 01:56:00PM -0400, Nathan Whitehorn wrote:
> This series adds support for 1000BASE-X autonegotiation to the Cadence macb driver
> when using the MAC-internal PCS. The existing driver code is oriented toward the PCS
> being used with an on-board SGMII PHY, so uses Cisco SGMII-style autonegotiation
> exclusively and does not anticipate e.g. link state changes arising from fiber
> attach/detach events. The first patch changes the driver to monitor the PCS's
> link; the second extends the existing SGMII autonegotiation code to also support
> 1000BASE-X autonegotiation.
> 

Your first version of the patch mentioned that this was tested on a
Polarfire SoC. This is some useful info that you can put in the cover
letter. I'd also be interested in knowing if you tested with a copper or
fiber SFP.

Also you shouldn't post newer versions of a patch set as a reply to the
previous version.

Thanks,
Charles

      parent reply	other threads:[~2026-07-23 19:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-14 20:09 [PATCH net-next] net: macb: add support for 1000BASE-X autonegotiation to PCS Nathan Whitehorn
2026-07-14 22:49 ` Andrew Lunn
2026-07-15 16:29 ` Charles Perry
2026-07-15 16:35   ` Nathan Whitehorn
2026-07-15 17:03     ` Andrew Lunn
2026-07-15 17:52     ` Charles Perry
2026-07-21 17:56 ` [PATCH net-next v2 0/2] net: macb: Updated patches for 1000BASE-X support Nathan Whitehorn
2026-07-21 17:56   ` [PATCH net-next v2 1/2] net: macb: Poll for link state changes when using the internal PCS Nathan Whitehorn
2026-07-23  1:19     ` Andrew Lunn
2026-07-23  1:20       ` Nathan Whitehorn
2026-07-21 17:56   ` [PATCH net-next v2 2/2] net: macb: add support for 1000BASE-X autonegotiation to PCS Nathan Whitehorn
2026-07-23  1:20     ` Andrew Lunn
2026-07-23 19:01   ` Charles Perry [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=amJk+0Yew01OV6lz@bby-cbu-swbuild03.eng.microchip.com \
    --to=charles.perry@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=conor.dooley@microchip.com \
    --cc=netdev@vger.kernel.org \
    --cc=nwhitehorn@pa.msu.edu \
    --cc=theo.lebrun@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox