From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f9.google.com (mail-pj2-f9.google.com [74.125.227.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EB4244210D for ; Fri, 24 Jul 2026 16:01:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.137 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784908884; cv=none; b=kBWhzgCgymC1mYdB7s22Rwj8ZWUYgZ26mETfxY2LATlRvkQQpwA7XUC1RDxFY828e/twkB8Xnk/Rsti+GhSsMaRxqkjTzmsslLdWCA+m4TIyYmMGaoJg8YKmT51Wu1sDGtzKIWUll7E1yBJZI+NuGwppD2Z/XhZpyim+dFx4CUE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784908884; c=relaxed/simple; bh=9gB3FZ/URecrVzXEqePsQErtHg6htVk+48ctF0yoBW8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Xo61mUo1xW6+YxJTqR39EU3FNRCBy5X0JhOQ8UeIvH38EktvlagGXjbT7lDVisB/FljI1cd5RU9ugJVFTu6vIvEVPNW9sOBVSBaI5vnaI9fNXyDEuXCIR2X2DkLXw7Gnb3exdrd1w4HqcLcIGoyZtX5QT7iXp6LrMMhuVUE+7yM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XZEWqhgu; arc=none smtp.client-ip=74.125.227.137 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XZEWqhgu" Received: by mail-pj2-f9.google.com with SMTP id 98e67ed59e1d1-38eca9b7114so348984a91.1 for ; Fri, 24 Jul 2026 09:01:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784908882; x=1785513682; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=7lGCvGc0qmAYP5540gpiXw7B0oJUHKRWl+SM1YR+Tyg=; b=XZEWqhguWqCuR6Mbb1GfWoZW/e2T09RsnYxRThexKogcaD7WQtrUSX0tHLuN9Qe7cQ Y2NLaxuYsz8xoevEJDhJXLLpuvsSEGZAvkqoPwTqb9gvEbJ8rKV6mcfU4IxKxUWC8PYF Un69Upu0aqg5lguOBvvJorf2mGNpvyxyAk+u2rCXGGMhaSdQaDVwk9KvMwZ+fHg2VqrI nXBP8LqitlJT8Wwh36YPkzezKeXCgKWZwVTbFm3q2179qNRzLoGR3ZhFEuPlUKlVsm0O JkT46Wwq5IAD9xxeEB6CDLbJE33p1HtC9KX+GO63YTPaisA58ugzJGz+yPuq037L6DGD sfDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784908882; x=1785513682; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7lGCvGc0qmAYP5540gpiXw7B0oJUHKRWl+SM1YR+Tyg=; b=qGXNEksRE39v0gNSuvVnmZKplZn9A2XEfksqztA+9R0wRf71Om8i8kbocL4x4MxTMh 9Diq6XRM2xD7y5QbW3/9Gtje5YEJsU+3umqkkhOrtui2YufEXTWElUc7kXT4wM0kAryX 9DVFAdqKDS3RsYaMaVCSzm3NjFX6Z4xfkOMF5u9Ny4PQEUCz6kzjK3SVYJC+OvbKdT7K c5sB3m08L5MSX4VSDAfqQFbZ1lpSWiVkGlAh11VgpsCsJi7Pm3Er91vkntuF1qGe9QOz wjN3t+Fg16xNPMO1t2btMdCRkMaZs7GaWD7BswNilqNjQSu5HXzXA8UqLyM6z4Rm1nPV B3XQ== X-Forwarded-Encrypted: i=1; AHgh+RpruytIndbdNVOH0cybu4i8YHu9ufO5mHm31VCs6ms8ELHbAJZydkZhFBXlTHVMmRyyBsw/f6g=@vger.kernel.org X-Gm-Message-State: AOJu0YwTIj/TO6RPGmXxEIyaM/c84/UX//nj5IzByuTiejYCI3C+7FIG agz0Drg28IcvYBwX3n+sUzmszR5ltVpYMPr//lduRlkmqsHaseMGIf5F X-Gm-Gg: AR+sD133xSHf1aL4+nvMUzzvMgq7a6FNevdljTngxvCBf5SaQXC/R9hI9PrDGZenrtb Gsi5g9LZun+VcOvOIS4OGCyxs3vMGHV4B4L+lvDXPpBFkMiovP/GXrfTBu5a5B4lnQg7KV8dwsY ACHCjDAWtd8FQWlVaoEnI591+OoBp5rm2KehUsivia7UC1AKyYk243gqVeqOBvYYwsaOfOd6B3A Qn2SLSzUAm3mv48WrjwCLNLpYFqqeCGczeGkOdgZ9bUVWoEffDVxPFHwxqplDKZ/SGKXKlK5/Qx ez0XwZWV/MzpW/eWqys9T95utRgMinK2feftW8mbU1ZuAWqI6XUzFf1gpBG1M8plaJ/459mrUfR q7tN2msZYMIPrqakKdUWzijjbtL70v0KzjDPi0DPM0eRPNev0ogo1QK8Cd3PtcPBSayMxcj0= X-Received: by 2002:a17:90a:d64c:b0:381:bc4c:da5b with SMTP id 98e67ed59e1d1-38ec6985236mr7668458a91.18.1784908882110; Fri, 24 Jul 2026 09:01:22 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:43::]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f056202cesm902393a91.0.2026.07.24.09.01.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 09:01:21 -0700 (PDT) Date: Fri, 24 Jul 2026 09:01:16 -0700 From: Stanislav Fomichev To: Doruk Tan Ozturk Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Mina Almasry , Stanislav Fomichev , Donald Hunter , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH net] netdev: require admin permission for the bind-tx netlink operation Message-ID: References: <20260724150156.72816-1-doruk@0sec.ai> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260724150156.72816-1-doruk@0sec.ai> On 07/24, Doruk Tan Ozturk wrote: > The netdev generic-netlink bind-rx operation (NETDEV_CMD_BIND_RX) is > flagged uns-admin-perm, so binding a dmabuf into a device RX datapath > requires CAP_NET_ADMIN. The symmetric bind-tx operation > (NETDEV_CMD_BIND_TX), added later, was given no permission flag. The > netdev family sets netnsok and has no pre_doit, and > netdev_nl_bind_tx_doit() performs no capability check, so any > unprivileged process can bind a dmabuf into a netmem-TX-capable device > TX datapath. > > net_devmem_bind_dmabuf() attaches and DMA-maps the caller-supplied > dmabuf to the device and installs TX device-memory state, the same > class of privileged device operation that bind-rx restricts. Gate > bind-tx behind uns-admin-perm to match bind-rx. TX is permission-less by design, it does not modify the netdev in any way.