From: Jakub Raczynski <j.raczynski@samsung.com>
To: muhammad.nazim.amirul.nazle.asmade@altera.com
Cc: netdev@vger.kernel.org, rohan.g.thomas@altera.com,
pabeni@redhat.com, rmk+kernel@armlinux.org.uk,
richardcochran@gmail.com
Subject: Re: [PATCH net] net: stmmac: Fix E2E delay mechanism
Date: Mon, 27 Jul 2026 17:29:46 +0200 [thread overview]
Message-ID: <amd5aoSrOSPrcB5e@AMDC4622.eu.corp.samsungelectronics.net> (raw)
In-Reply-To: <20260727022524.7521-1-muhammad.nazim.amirul.nazle.asmade@altera.com>
[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]
On Sun, Jul 26, 2026 at 07:25:24PM -0700, muhammad.nazim.amirul.nazle.asmade@altera.com wrote:
> From: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index 2a0d7eff88d3..24d8c6e9f1df 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -755,7 +755,8 @@ static int stmmac_hwtstamp_set(struct net_device *dev,
> config->rx_filter = HWTSTAMP_FILTER_PTP_V2_EVENT;
> ptp_v2 = PTP_TCR_TSVER2ENA;
> snap_type_sel = PTP_TCR_SNAPTYPSEL_1;
> - if (priv->synopsys_id < DWMAC_CORE_4_10)
> + if (priv->synopsys_id < DWMAC_CORE_3_70 &&
> + !priv->plat->has_xgmac)
This change does not compile, as has_xgmac no longer exists
since 26ab9830beabd. Please check patchwork for more details.
But on my test kernel 6.18 from a while ago where E2E is broken,
it fixes the issue.
So Tested-by me but not really.
BR
Jakub Raczynski
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2026-07-27 15:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20260727152949eucas1p2a8679cd740d0bccf89db7d0af8904225@eucas1p2.samsung.com>
2026-07-27 2:25 ` [PATCH net] net: stmmac: Fix E2E delay mechanism muhammad.nazim.amirul.nazle.asmade
2026-07-27 7:52 ` Maxime Chevallier
2026-07-27 7:59 ` Nazle Asmade, Muhammad Nazim Amirul
2026-07-27 15:29 ` Jakub Raczynski [this message]
2026-07-28 1:21 ` Nazle Asmade, Muhammad Nazim Amirul
2021-10-20 7:04 Kurt Kanzenbach
2021-10-20 13:50 ` patchwork-bot+netdevbpf
2021-10-21 6:44 ` Wong Vee Khee
2021-10-21 6:55 ` Kurt Kanzenbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amd5aoSrOSPrcB5e@AMDC4622.eu.corp.samsungelectronics.net \
--to=j.raczynski@samsung.com \
--cc=muhammad.nazim.amirul.nazle.asmade@altera.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=rohan.g.thomas@altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox