Netdev List
 help / color / mirror / Atom feed
From: Vincent Jardin <vjardin@free.fr>
To: Ivan Vecera <ivecera@redhat.com>
Cc: Vincent Jardin via B4 Relay <devnull+vjardin.free.fr@kernel.org>,
	Prathosh Satish <Prathosh.Satish@microchip.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Vadim Fedorenko <vadim.fedorenko@linux.dev>,
	Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
	Jiri Pirko <jiri@resnulli.us>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dpll: zl3073x: add ZL30643 chip support
Date: Thu, 30 Jul 2026 19:08:07 +0200	[thread overview]
Message-ID: <amuE9yIaBsFSgRhL@L30177.local> (raw)
In-Reply-To: <4CCA3CCC-C687-4658-8ACD-BC0CB3294A39@redhat.com>

Hi Ivan,

> Hi Vincent,
> I'm not sure that all driver's functionality is supported by ZL3064x. Did you test everything?
> 
> I need to check datasheets for this chip models, maybe some device flags will be needed.

I checked both datasheets. They are the same registers:

  - the register descriptions are verbatim identical

  - same chip-ID encoding (base / A +0x1000 / B +0x2000 / 7x7 +0x8000)

So ZL_CHIP_INFO(0x0E3B, 3, ZL3073X_FLAG_REF_PHASE_COMP_32) is correct
and no new device flag is needed: the ref-phase mechanism the flag
governs is identical between the families.

The only differences seem to be non-register related: line card vs
central system and the min input-frequency spec (1 kHz vs 0.5 Hz).

I tested with:

  devlink dev param set spi/spi0.0 name clock_id value 3733 cmode driverinit
  devlink dev reload spi/spi0.0

  devlink dev param set spi/spi2.1 name clock_id value 3643 cmode driverinit
  devlink dev reload spi/spi2.1

  dpll device show | grep clock-id
    clock-id: 3733
    clock-id: 3733
    clock-id: 3733
    clock-id: 3643
    clock-id: 3643
    clock-id: 3643

Best regards,
  Vincent

  reply	other threads:[~2026-07-30 17:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-23 23:09 [PATCH 0/2] dpll: zl3073x: add Microchip ZL30643 support Vincent Jardin via B4 Relay
2026-07-23 23:09 ` [PATCH 1/2] dt-bindings: dpll: zl3073x: add ZL30643 compatible Vincent Jardin via B4 Relay
2026-07-24 16:46   ` Conor Dooley
2026-07-30 17:01     ` Vincent Jardin
2026-07-23 23:09 ` [PATCH 2/2] dpll: zl3073x: add ZL30643 chip support Vincent Jardin via B4 Relay
2026-07-27  8:36   ` Ivan Vecera
2026-07-30 17:08     ` Vincent Jardin [this message]
2026-08-03 11:51       ` Ivan Vecera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=amuE9yIaBsFSgRhL@L30177.local \
    --to=vjardin@free.fr \
    --cc=Prathosh.Satish@microchip.com \
    --cc=arkadiusz.kubalewski@intel.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=devnull+vjardin.free.fr@kernel.org \
    --cc=ivecera@redhat.com \
    --cc=jiri@resnulli.us \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=vadim.fedorenko@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox