From: Breno Leitao <leitao@debian.org>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: netdev@vger.kernel.org,
"'Mengyuan Lou'" <mengyuanlou@net-swift.com>,
"'Andrew Lunn'" <andrew+netdev@lunn.ch>,
"'David S. Miller'" <davem@davemloft.net>,
"'Eric Dumazet'" <edumazet@google.com>,
"'Jakub Kicinski'" <kuba@kernel.org>,
"'Paolo Abeni'" <pabeni@redhat.com>,
"'Richard Cochran'" <richardcochran@gmail.com>,
"'Russell King'" <linux@armlinux.org.uk>,
"'Aleksandr Loktionov'" <aleksandr.loktionov@intel.com>,
"'Jacob Keller'" <jacob.e.keller@intel.com>,
"'Simon Horman'" <horms@kernel.org>,
"'Kees Cook'" <kees@kernel.org>,
"'Rongguang Wei'" <weirongguang@kylinos.cn>,
"'Uwe Kleine-König (The Capable Hub)'"
<u.kleine-koenig@baylibre.com>, "'Joe Damato'" <joe@dama.to>,
"'Larysa Zaremba'" <larysa.zaremba@intel.com>,
"'Chenguang Zhao'" <zhaochenguang@kylinos.cn>,
"'Fabio Baltieri'" <fabio.baltieri@gmail.com>
Subject: Re: [PATCH net-next v13 2/5] net: wangxun: add Tx timeout process
Date: Fri, 31 Jul 2026 02:30:56 -0700 [thread overview]
Message-ID: <amxrL9y6Nab35KVI@gmail.com> (raw)
In-Reply-To: <04f701dd20ce$d21842a0$7648c7e0$@trustnetic.com>
On Fri, Jul 31, 2026 at 05:27:34PM +0800, Jiawen Wu wrote:
> On Fri, Jul 31, 2026 5:01 PM, Breno Leitao wrote:
> > On Fri, Jul 31, 2026 at 02:18:34PM +0800, Jiawen Wu wrote:
> > > @@ -1275,6 +1288,7 @@ enum wx_pf_flags {
> > > WX_FLAG_NEED_DO_RESET,
> > > WX_FLAG_RX_MERGE_ENABLED,
> > > WX_FLAG_TXHEAD_WB_ENABLED,
> > > + WX_FLAG_NEED_PF_RESET,
> > > WX_PF_FLAGS_NBITS /* must be last */
> > > };
> >
> > You need WX_FLAG_NEED_PF_RESET and also WX_FLAG_NEED_DO_RESET? isn't one
> > of them enough?
>
> Sorry I didn't notice flag WX_FLAG_NEED_DO_RESET introduced by VF driver here.
> I'll fix to reuse it in the next version.
Right, WX_FLAG_NEED_DO_RESET might be enough for you here.
> But I think 'wx_pf_flags' needs to be renamed to 'wx_flags', since VF is also used.
Agreed!
next prev parent reply other threads:[~2026-07-31 9:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 6:18 [PATCH net-next v13 0/5] net: wangxun: timeout and error Jiawen Wu
2026-07-31 6:18 ` [PATCH net-next v13 1/5] net: ngbe: implement libwx reset ops Jiawen Wu
2026-07-31 8:38 ` Breno Leitao
2026-07-31 6:18 ` [PATCH net-next v13 2/5] net: wangxun: add Tx timeout process Jiawen Wu
2026-07-31 9:01 ` Breno Leitao
2026-07-31 9:27 ` Jiawen Wu
2026-07-31 9:30 ` Breno Leitao [this message]
2026-07-31 9:42 ` Breno Leitao
2026-07-31 9:55 ` Jiawen Wu
2026-07-31 6:18 ` [PATCH net-next v13 3/5] net: wangxun: add reinit parameter to wx->do_reset callback Jiawen Wu
2026-07-31 6:18 ` [PATCH net-next v13 4/5] net: wangxun: implement soft quiesce for PCIe error recovery Jiawen Wu
2026-07-31 6:18 ` [PATCH net-next v13 5/5] net: wangxun: add pcie error handler Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amxrL9y6Nab35KVI@gmail.com \
--to=leitao@debian.org \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fabio.baltieri@gmail.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=jiawenwu@trustnetic.com \
--cc=joe@dama.to \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=larysa.zaremba@intel.com \
--cc=linux@armlinux.org.uk \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=weirongguang@kylinos.cn \
--cc=zhaochenguang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox