From: Karl Mehltretter <kmehltretter@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH net-next] net_shaper: fix net_shaper_ops kernel-doc
Date: Sat, 15 Aug 2026 00:49:41 +0200 [thread overview]
Message-ID: <an-ZnZWVWtDemvSv@gmail.com> (raw)
In-Reply-To: <984e036c-0d90-435f-a56b-ea39a2adf923@infradead.org>
On Fri, Aug 14, 2026 at 12:04:05PM +0100, Randy Dunlap wrote:
> On 8/14/26 10:14 AM, Jakub Kicinski wrote:
> >
> > Isn't this a problem in kernel-doc extraction / how we embed it for
> > rendering? Heading are quite useful and IMHO far more natural to use.
> > My understanding was that kdoc should be able to use basic ReST
> > formatting.
> >
> > Ack on the list indent fix
> >
>
> I don't know of another reasonable solution for this (although I'm no expert
> on ReST), so
>
Yes, this is a problem in how Documentation/sphinx/kerneldoc.py embeds
kernel-doc output. It parses generated content into a detached node while
retaining the surrounding title hierarchy.
The key kerneldoc.py change is replacing the parser call:
- self.state.nested_parse(result, 0, node, match_titles=1)
+ nested_parse_with_titles(self.state, result, node)
This preserves the headings.
I tested the networking documentation with Sphinx 9.1.0 and Docutils
0.21.2 and 0.22.4, and a full htmldocs build with Docutils 0.22.4. The
full build produced only unrelated existing warnings.
I can send this as a two-patch v2, with the list correction first.
Thanks,
Karl
next prev parent reply other threads:[~2026-08-14 22:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 19:21 [PATCH net-next] net_shaper: fix net_shaper_ops kernel-doc Karl Mehltretter
2026-08-14 17:14 ` Jakub Kicinski
2026-08-14 19:04 ` Randy Dunlap
2026-08-14 22:49 ` Karl Mehltretter [this message]
2026-08-14 22:56 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=an-ZnZWVWtDemvSv@gmail.com \
--to=kmehltretter@gmail.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox