From: Breno Leitao <leitao@debian.org>
To: Sidraya Jayagond <sidraya@linux.ibm.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, alibuda@linux.alibaba.com,
dust.li@linux.alibaba.com, horms@kernel.org,
mjambigi@linux.ibm.com, tonylu@linux.alibaba.com,
guwen@linux.alibaba.com, hidayath@linux.ibm.com,
pasic@linux.ibm.com, netdev@vger.kernel.org,
linux-s390@vger.kernel.org
Subject: Re: [PATCH net] net/smc: fix TOCTOU race between smc_listen_out() and listener close
Date: Mon, 3 Aug 2026 05:54:43 -0700 [thread overview]
Message-ID: <anCPZl_Rvqj2B7vI@gmail.com> (raw)
In-Reply-To: <20260803070701.126339-1-sidraya@linux.ibm.com>
> @@ -1931,11 +1931,12 @@ static void smc_listen_out(struct smc_sock *new_smc)
> atomic_dec(&lsmc->queued_smc_hs);
>
> release_sock(newsmcsk); /* lock in smc_listen_work() */
> + lock_sock_nested(&lsmc->sk, SINGLE_DEPTH_NESTING);
> if (lsmc->sk.sk_state == SMC_LISTEN) {
> - lock_sock_nested(&lsmc->sk, SINGLE_DEPTH_NESTING);
> smc_accept_enqueue(&lsmc->sk, newsmcsk);
> release_sock(&lsmc->sk);
> } else { /* no longer listening */
> + release_sock(&lsmc->sk);
> smc_close_non_accepted(newsmcsk);
> }
Do you need to call smc_close_non_accepted() without the lock? otherwise
you can have the lock around the whole if/else clause.
next prev parent reply other threads:[~2026-08-03 12:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 7:07 [PATCH net] net/smc: fix TOCTOU race between smc_listen_out() and listener close Sidraya Jayagond
2026-08-03 12:54 ` Breno Leitao [this message]
2026-08-04 7:22 ` Sidraya Jayagond
2026-08-04 8:02 ` Breno Leitao
2026-08-05 7:21 ` Dust Li
2026-08-05 12:29 ` Sidraya Jayagond
2026-08-06 11:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anCPZl_Rvqj2B7vI@gmail.com \
--to=leitao@debian.org \
--cc=alibuda@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=dust.li@linux.alibaba.com \
--cc=edumazet@google.com \
--cc=guwen@linux.alibaba.com \
--cc=hidayath@linux.ibm.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjambigi@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=sidraya@linux.ibm.com \
--cc=tonylu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox