Re: [PATCH] vhost: clear vq->worker under vq->mutex when freeing workers

[Stefano Garzarella <sgarzare@redhat.com>]

On Thu, Aug 06, 2026 at 06:53:12AM -0700, Sean Christopherson wrote:
>On Thu, Aug 06, 2026, Stefano Garzarella wrote:
>> On Thu, Jul 23, 2026 at 06:33:10PM +0300, Andrey Drobyshev wrote:
>> > The effect is harmless in practice, as this only happens while the
>> > owning process (and thus the whole device) is dying, but the lockless
>> > write is inconsistent with the rest of the code.  Clear vq->worker under
>> > vq->mutex, like everyone else, so that all writers of vq->worker follow
>> > the same locking rule.
>> >
>> > This issue was found by Sashiko AI review.
>>
>> Can you share a link to the review?
>>
>> I don't know if it's common or not, but having the link in the commit or
>> after --- will help the reviewers.
>
>+1.  FWIW, I've been using and encouraging the "standard" Reported-by+Closes, e.g.
>
>    Reported-by: Sashiko Bot <sashiko-bot@kernel.org>
>    Closes: https://lore.kernel.org/all/20260625212001.3B6561F000E9@smtp.kernel.org
>

Yeah, this makes a lot of sense to me! I'll encourage the same.

Thanks,
Stefano