From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.white.stw.pengutronix.de (mx1.white.stw.pengutronix.de [185.203.200.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A47F343D63; Fri, 7 Aug 2026 04:26:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.200.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786076797; cv=none; b=GZK/F7nh5wug4nfTd40TvwHtNS6OiShDkxB0Kj+pZyXQDhg8Z09MQW6QSZFRS6WazW2xkO4oUzUBi2MfU+yYZb7qXJ4T7LSz/c0rKUdyrD2molwLCfVjAg3BltOSfZRoMQYXK7Ep7mbAuhdth9yiGNnqpj7nbbqVCqXtVbhN8Rw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786076797; c=relaxed/simple; bh=yln42IKi00e1pvpPiNXQrNfS9kBjRe+eQK1DP9DNHpg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qhYrSKpyhIDg9qb1RuzQYF+GBQcgwD+ap68kLQcxzug0mST7LYd7fZUsQenK+Mj413lQ6NcJwRNuTnWRaIbW+GPIL7efCLYz/Ftlq6WkfZ+IDh2UAc7Hpq++bVfJn81fCfdB7fBGRPrAZjIM57ccGEPlCOGIiu4+SOPicyBKQJI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.200.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de (drehscheibe.grey.stw.pengutronix.de [IPv6:2a0a:edc0:0:c01:1d::a2]) (Authenticated sender: relay-from-drehscheibe.grey.stw.pengutronix.de) by mx1.white.stw.pengutronix.de (Postfix) with ESMTPSA id 17164200C57; Fri, 07 Aug 2026 06:26:31 +0200 (CEST) Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wsCAA-000CK7-3C; Fri, 07 Aug 2026 06:26:31 +0200 Received: from ore by pty.whiteo.stw.pengutronix.de with local (Exim 4.98.2) (envelope-from ) id 1wsCAA-00000000mz3-3beQ; Fri, 07 Aug 2026 06:26:30 +0200 Date: Fri, 7 Aug 2026 06:26:30 +0200 From: Oleksij Rempel To: Linus Walleij Cc: Ahmad Fatoum , Mark Brown , Andrew Lunn , Conor Dooley , Paolo Abeni , Rob Herring , netdev@vger.kernel.org, Luiz Angelo Daros de Luca , linux-kernel@vger.kernel.org, Liam Girdwood , Eric Dumazet , kernel@pengutronix.de, Alvin =?utf-8?Q?=C5=A0ipraga?= , Jakub Kicinski , Krzysztof Kozlowski , Vladimir Oltean , Alvin =?utf-8?Q?=C5=A0ipraga?= , "David S. Miller" , devicetree@vger.kernel.org Subject: Re: [PATCH net-next v1 2/2] net: dsa: realtek: rtl83xx: add support for enabling supplies Message-ID: References: <20260806140239.3518906-1-o.rempel@pengutronix.de> <20260806140239.3518906-3-o.rempel@pengutronix.de> <9181f24b-cd5e-46c8-8e57-cbf309ac1a98@lunn.ch> <02a51eff-3782-4012-8475-1047a9be4dd3@pengutronix.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain On Thu, Aug 06, 2026 at 07:40:29PM +0200, Linus Walleij wrote: > On Thu, Aug 6, 2026 at 5:56 PM Ahmad Fatoum wrote: > > [Andrew says] > > > static inline int __must_check clk_bulk_get_optional(struct device *dev, > > > static inline int __must_check devm_clk_bulk_get_optional(struct device *dev, > > > static inline int __must_check devm_clk_bulk_get_optional_enable(struct device *dev, > > > > > > If clk has them, maybe regulators should as well? > > > > clk and regulator have different interpretations of _optional > > when encountering a non-existent resource: > > > > clk_get return error > > clk_get_optional return NULL > > regulator_get return handle dummy regulator > > regulator_get_optional return error code > > > > So devm_regulator_bulk_get() is already the "optional" variant, but it causes > > all existing users to get dummy supply warnings. > > So is this a big problem? Does it cause any other issues than > dmesg noise? As tested with local sashiko setup, new warnings for existing system without good reason will be reported as regression, so it will be blocker for net-next inclusion. -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |