Netdev List
 help / color / mirror / Atom feed
From: Felix Maurer <fmaurer@redhat.com>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: Simon Horman <horms@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Lukasz Majewski <lukma@denx.de>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Hangbin Liu <liuhangbin@kylinos.cn>,
	syzbot+fbf74291c3b7e753b481@syzkaller.appspotmail.com,
	Xin Xie <xiexinet@gmail.com>
Subject: Re: [PATCH net] hsr: Avoid holding seqnr_lock while transmitting packets
Date: Fri, 7 Aug 2026 15:16:36 +0200	[thread overview]
Message-ID: <anXatDPkcVsCTB36@thinkpad> (raw)
In-Reply-To: <anXStphPD0z-ystm@fedora>

Hi Hangbin, hi Simon,

On Fri, Aug 07, 2026 at 08:42:30PM +0800, Hangbin Liu wrote:
> Hi Simon,
> On Fri, Aug 07, 2026 at 10:43:25AM +0100, Simon Horman wrote:
> [ ... ]
> > Simon says:
> >
> > I don't think the advice on how to annotate this is correct
> >
> > Tags trump freeform text, but Depends-on is a not a standard tag and as
> > such should not be used.
> >
> > I believe that the correct approach would be a tag like this:
> >
> >   Cc: <stable@vger.kernel.org> # aae9d6b616b5: hsr: Implement more robust duplicate discard for HSR
> >
> > Link: https://docs.kernel.org/process/stable-kernel-rules.html#option-1
>
> Thanks, I will update with this.

Thank you for the patch! Just to let you know, there is a patch
addressing the same thing in an in-flight patchset [1]. Unfortunately, I
didn't have a lot of time to review in the last weeks, so I'll just
leave this note here so you can coordinate if necessary :)

Thanks,
   Felix


[1]: https://lore.kernel.org/netdev/20260803222211.877-3-xiexinet@gmail.com/


  reply	other threads:[~2026-08-07 13:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-05  3:09 [PATCH net] hsr: Avoid holding seqnr_lock while transmitting packets Hangbin Liu
2026-08-07  9:43 ` Simon Horman
2026-08-07 12:42   ` Hangbin Liu
2026-08-07 13:16     ` Felix Maurer [this message]
2026-08-07 14:12       ` Hangbin Liu
2026-08-07 14:18         ` Xin Xie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=anXatDPkcVsCTB36@thinkpad \
    --to=fmaurer@redhat.com \
    --cc=bigeasy@linutronix.de \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liuhangbin@gmail.com \
    --cc=liuhangbin@kylinos.cn \
    --cc=lukma@denx.de \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=syzbot+fbf74291c3b7e753b481@syzkaller.appspotmail.com \
    --cc=xiexinet@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox