From: Ratheesh Kannoth <rkannoth@marvell.com>
To: <bpf@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>
Cc: <andrew+netdev@lunn.ch>, <ast@kernel.org>, <daniel@iogearbox.net>,
<davem@davemloft.net>, <edumazet@google.com>, <hawk@kernel.org>,
<john.fastabend@gmail.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <sdf@fomichev.me>, <sgoutham@marvell.com>
Subject: Re: [PATCH v8 net-next] octeontx2-pf: add mqprio bandwidth offload for NIX TX schedulers
Date: Mon, 17 Aug 2026 08:33:50 +0530 [thread overview]
Message-ID: <aoJ6FhtWue0FHDQV@rkannoth-OptiPlex-7090> (raw)
In-Reply-To: <20260813082754.1165329-1-rkannoth@marvell.com>
On 2026-08-13 at 13:57:54, Ratheesh Kannoth (rkannoth@marvell.com) wrote:
> Add TC_SETUP_QDISC_MQPRIO handling to offload per-queue MDQ CIR/PIR
> shaping for mqprio channel mode with TC_MQPRIO_SHAPER_BW_RATE. When
> bandwidth offload is enabled, allocate one SMQ per non-QoS transmit
> queue, parent all MDQs under TL4[0], and program min/max rates by
> dividing each traffic class byte/s limit across its queues.
>
> Setting up or tearing down the offload restarts the netdev via
> ndo_stop()/ndo_open() to rebuild the TX scheduler hierarchy. That
> clears carrier, tears down IRQ/NAPI and drops in-flight traffic; if
> ndo_open() fails the interface is left administratively down. Offload
> setup is rejected unless the interface is already running.
>
> Reject incompatible configurations (HTB, PFC, XDP, SDP rep, missing
> CIR+PIR support) and out-of-range rates. Validate queue mappings
> against hw.non_qos_queues and reject per-TC rates smaller than the
> queue count that integer division would truncate to zero. Track offload
> state in mqprio_rate_limit instead of pfvf->flags to avoid races with
> the mbox up-handler, skip spurious teardown on tc qdisc replace, and
> clear all MDQ shapers before applying a new mapping so queues dropped
> from a TC layout do not retain stale limits. Restore cached shapers
> across routine netdev stop/open via otx2_mqprio_up().
>
> Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com>
Will address sashiko comments in v9.
pw-bot: changes-requested
prev parent reply other threads:[~2026-08-17 3:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 8:27 [PATCH v8 net-next] octeontx2-pf: add mqprio bandwidth offload for NIX TX schedulers Ratheesh Kannoth
2026-08-17 3:03 ` Ratheesh Kannoth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoJ6FhtWue0FHDQV@rkannoth-OptiPlex-7090 \
--to=rkannoth@marvell.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox