From: Hangbin Liu <hangbin.liu@linux.dev>
To: Qingshuang Fu <fffsqian@163.com>
Cc: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
SeongJae Park <sjpark@amazon.de>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Qingshuang Fu <fuqingshuang@kylinos.cn>
Subject: Re: [PATCH net v2 0/2] selftests/net: fixes for fin_ack_lat
Date: Fri, 21 Aug 2026 14:45:40 +0800 [thread overview]
Message-ID: <aof0FLTs59t5tNvE@fedora> (raw)
In-Reply-To: <20260821030922.1123754-1-fffsqian@163.com>
On Fri, Aug 21, 2026 at 11:09:20AM +0800, Qingshuang Fu wrote:
> From: Qingshuang Fu <fuqingshuang@kylinos.cn>
>
> This series fixes two bugs in the fin_ack_lat self-test.
>
> Patch 1 fixes the swapped kill() arguments in sig_handler(), so the
> server actually forwards SIGTERM to the client. It also makes the
> wrapper script's cleanup tolerant of ESRCH, since the client may now
> exit before the kill command reaches its PID.
>
> Patch 2 adds a missing fork() error check: on failure the code falls
> into server()'s infinite accept loop, producing empty output that the
> wrapper script treats as a passing test.
>
> Qingshuang Fu (2):
> selftests/net: fix kill() argument order and wrapper cleanup in fin_ack_lat
> selftests/net: check fork() return value in fin_ack_lat
>
> tools/testing/selftests/net/fin_ack_lat.c | 5 +++-
> tools/testing/selftests/net/fin_ack_lat.sh | 2 +-
> 2 files changed, 5 insertions(+), 2 deletions(-)
> ---
> v1: https://lore.kernel.org/all/20260817091017.281104-1-fffsqian@163.com/
>
> v2:
> - Split into two patches
> - Add shell cleanup tolerance for ESRCH per Sashiko-AI review
> - Add missing fork() error check per Sashiko-AI review
> --
> 2.25.1
>
LGTM, for the series
Reviewed-by: Hangbin Liu <liuhangbin@kylinos.cn>
prev parent reply other threads:[~2026-08-21 6:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 3:09 [PATCH net v2 0/2] selftests/net: fixes for fin_ack_lat Qingshuang Fu
2026-08-21 3:14 ` [PATCH net v2 1/2] selftests/net: fix kill() argument order and wrapper cleanup in fin_ack_lat Qingshuang Fu
2026-08-21 3:14 ` [PATCH net v2 2/2] selftests/net: check fork() return value " Qingshuang Fu
2026-08-21 6:45 ` Hangbin Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aof0FLTs59t5tNvE@fedora \
--to=hangbin.liu@linux.dev \
--cc=apw@canonical.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fffsqian@163.com \
--cc=fuqingshuang@kylinos.cn \
--cc=horms@kernel.org \
--cc=joe@perches.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=sjpark@amazon.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox