Netdev List
 help / color / mirror / Atom feed
From: Hangbin Liu <hangbin.liu@linux.dev>
To: Eric Dumazet <edumazet@google.com>
Cc: Ido Schimmel <idosch@nvidia.com>,
	"David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>, David Ahern <dsahern@kernel.org>,
	netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next] selftests: icmp_redirect: remove xfail support
Date: Tue, 8 Sep 2026 10:40:16 +0800	[thread overview]
Message-ID: <ap91kK58_DL2P9DH@fedora> (raw)
In-Reply-To: <CANn89iKAFuAKgR=pZSfNWtNj9aT_PgmZzfu04mt14S1UFfeN=Q@mail.gmail.com>

On Mon, Sep 07, 2026 at 05:52:13PM +0200, Eric Dumazet wrote:
> On Mon, Sep 7, 2026 at 5:37 PM Ido Schimmel <idosch@nvidia.com> wrote:
> 
> > Reviewed-by: Ido Schimmel <idosch@nvidia.com>
> >
> > FTR, I don't think cd51b74bdd0b ("ipv6: Fix redirect exception creation
> > for UDP/RAW sockets") is what fixed the xfail (I never saw xfail, even
> > before my patch). It's more likely that it was fixed by commit
> > 0e02bf5de46a ("selftests: icmp_redirect: IPv6 PMTU info should be
> > cleared after redirect"):
> >
> > 1. The redirect message quotes an echo request, so it's going through
> > icmpv6_err() which calls ip6_redirect() using the correct oif. It's
> > possible that rawv6_err() later called ip6_sk_redirect(), but by then
> > the exception was already present / populated.
> 
> Ah right,  I will send a V2 with an updated changelog, thanks!

Good, I will rebase my log_test() cleanup on your patch.

Thanks
Hangbin

      reply	other threads:[~2026-09-08  2:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-07 13:24 [PATCH net-next] selftests: icmp_redirect: remove xfail support Eric Dumazet
2026-09-07 15:37 ` Ido Schimmel
2026-09-07 15:52   ` Eric Dumazet
2026-09-08  2:40     ` Hangbin Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ap91kK58_DL2P9DH@fedora \
    --to=hangbin.liu@linux.dev \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox