From: Ratheesh Kannoth <rkannoth@marvell.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<andrew+netdev@lunn.ch>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>,
<sgoutham@marvell.com>, Hariprasad Kelam <hkelam@marvell.com>,
Leon Romanovsky <leon@kernel.org>
Subject: Re: [PATCH v2 net-next] octeontx2-pf: report port connector type in ethtool link ksettings
Date: Tue, 8 Sep 2026 08:01:55 +0530 [thread overview]
Message-ID: <ap9zm3g92LgXyAcE@rkannoth-OptiPlex-7090> (raw)
In-Reply-To: <20260907144038.0937d6ff@kernel.org>
On 2026-09-08 at 03:10:38, Jakub Kicinski (kuba@kernel.org) wrote:
> On Mon, 7 Sep 2026 09:58:27 +0530 Ratheesh Kannoth wrote:
> > otx2_get_link_ksettings() already fills speed, duplex, autoneg, link
> > modes and FEC from CGX firmware data, but leaves cmd->base.port unset.
> > As a result, ethtool does not show the physical connector type even
> > though the firmware provides it in fwdata.port.
> >
> > Populate cmd->base.port from rsp->fwdata.port so users can see values
> > such as PORT_TP or PORT_AUI via ethtool.
>
> I said:
>
> drivers should not blindly pass values between uAPI and the FW.
>
> That means you have to add some explicit validation/translation
> for each value even if they are numerically identical.
A field_get() would be OK to satisfy this translation ?
cmd->base.port = FIELD_GET(GENMASK(7, 0), rsp->fwdata.port);
next prev parent reply other threads:[~2026-09-08 2:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 4:28 [PATCH v2 net-next] octeontx2-pf: report port connector type in ethtool link ksettings Ratheesh Kannoth
2026-09-07 7:23 ` Leon Romanovsky
2026-09-07 11:01 ` Ratheesh Kannoth
2026-09-07 11:35 ` Leon Romanovsky
2026-09-07 21:40 ` Jakub Kicinski
2026-09-08 2:31 ` Ratheesh Kannoth [this message]
2026-09-08 20:59 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ap9zm3g92LgXyAcE@rkannoth-OptiPlex-7090 \
--to=rkannoth@marvell.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkelam@marvell.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox