From: Joe Damato <joe@dama.to>
To: Michael Chan <michael.chan@broadcom.com>
Cc: netdev@vger.kernel.org, Pavan Chebbi <pavan.chebbi@broadcom.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Colin Winegarden <colin.winegarden@broadcom.com>,
Rukhsana Ansari <rukhsana.ansari@broadcom.com>,
Kalesh AP <kalesh-anakkur.purayil@broadcom.com>,
horms@kernel.org, linux-kernel@vger.kernel.org,
raphaelcf@meta.com, stable@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH net v3] bnxt_en: Bound SW TPA IDs to prevent crashes
Date: Thu, 27 Aug 2026 16:12:47 -0700 [thread overview]
Message-ID: <apDEb/LIqcrI9LoV@devvm20253.cco0.facebook.com> (raw)
In-Reply-To: <CACKFLikJiCdjej4ezF=U16Leef3oAjSZGQAyetRnF=nLRvUfZA@mail.gmail.com>
On Thu, Aug 27, 2026 at 04:07:16PM -0700, Michael Chan wrote:
> On Thu, Aug 27, 2026 at 11:57 AM Joe Damato <joe@dama.to> wrote:
>
> > @@ -3831,6 +3834,7 @@ static int bnxt_alloc_tpa_info(struct bnxt *bp)
> > int i, rc;
> >
> > bp->max_tpa = MAX_TPA;
> > + bp->max_tpa_roundup_size = MAX_TPA;
>
> This is strictly not needed. If we return early below, it means the
> chip does not support TPA at all. We skip allocating the TPA array
> for every ring, so it really makes no difference.
>
> BNXT_SUPPORTS_TPA() will be false if we return early. LRO and HW_GRO
> will not be supported. So I would say it's a false positive from
> Sashiko. Thanks.
I see, OK.
I suppose that means I'll have to resubmit the v2 over again in 24hr?
next prev parent reply other threads:[~2026-08-27 23:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-27 18:56 [PATCH net v3] bnxt_en: Bound SW TPA IDs to prevent crashes Joe Damato
2026-08-27 23:07 ` Michael Chan
2026-08-27 23:12 ` Joe Damato [this message]
2026-08-27 23:41 ` Joe Damato
2026-08-28 0:00 ` Michael Chan
2026-08-28 3:03 ` Joe Damato
2026-08-28 18:48 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apDEb/LIqcrI9LoV@devvm20253.cco0.facebook.com \
--to=joe@dama.to \
--cc=andrew+netdev@lunn.ch \
--cc=colin.winegarden@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=justinstitt@google.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=michael.chan@broadcom.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=raphaelcf@meta.com \
--cc=rukhsana.ansari@broadcom.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox