Netdev List
 help / color / mirror / Atom feed
From: Hangbin Liu <hangbin.liu@linux.dev>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Jakub Kicinski <kuba@kernel.org>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org,
	Hangbin Liu <liuhangbin@kylinos.cn>
Subject: Re: [PATCH net-next 1/2] netdevsim: add link speed support
Date: Tue, 1 Sep 2026 14:39:32 +0800	[thread overview]
Message-ID: <apZzJDVtENpAluhT@fedora> (raw)
In-Reply-To: <53215678-05bb-4191-b5ff-aa236b16a96a@lunn.ch>

On Mon, Aug 31, 2026 at 02:16:46PM +0200, Andrew Lunn wrote:
> >  static void nsim_ethtool_ring_init(struct netdevsim *ns)
> > @@ -250,12 +276,16 @@ void nsim_ethtool_init(struct netdevsim *ns)
> >  	ns->ethtool.fec.active_fec = ETHTOOL_FEC_NONE;
> >  
> >  	ns->ethtool.channels = ns->nsim_bus_dev->num_queues;
> > +	ns->ethtool.duplex = DUPLEX_FULL;
> > +	ns->ethtool.speed = SPEED_5000;
> >  
> >  	ethtool = debugfs_create_dir("ethtool", ns->nsim_dev_port->ddir);
> >  	ns->ethtool_ddir = ethtool;
> >  
> >  	debugfs_create_u32("get_err", 0600, ethtool, &ns->ethtool.get_err);
> >  	debugfs_create_u32("set_err", 0600, ethtool, &ns->ethtool.set_err);
> > +	debugfs_create_u32("speed", 0600, ethtool, &ns->ethtool.speed);
> > +	debugfs_create_u8("duplex", 0600, ethtool, &ns->ethtool.duplex);
> 
> debugfs_create_bool() ?

I'm not sure if anyone want to set nsim duplex to unknown for testing.
Do you think that we should disable this behavior?

Thanks
Hangbin

  reply	other threads:[~2026-09-01  6:39 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-31  3:28 [PATCH net-next 0/2] netdevsim: add link speed support Hangbin Liu
2026-08-31  3:28 ` [PATCH net-next 1/2] " Hangbin Liu
2026-08-31 12:16   ` Andrew Lunn
2026-09-01  6:39     ` Hangbin Liu [this message]
2026-09-01 12:43       ` Andrew Lunn
2026-09-02  1:53         ` Hangbin Liu
2026-09-02 12:38           ` Andrew Lunn
2026-08-31 12:24   ` Andrew Lunn
2026-09-01  6:31     ` Hangbin Liu
2026-08-31 22:08   ` Jakub Kicinski
2026-09-01  6:58     ` Hangbin Liu
2026-09-01  8:23       ` Hangbin Liu
2026-09-01 14:21         ` Andrew Lunn
2026-09-02  2:01           ` Hangbin Liu
2026-09-02 12:49             ` Andrew Lunn
2026-09-01 14:18       ` Andrew Lunn
2026-08-31  3:28 ` [PATCH net-next 2/2] selftests: netdevsim: add speed testing Hangbin Liu
2026-08-31 22:06   ` Jakub Kicinski
2026-09-01  6:42     ` Hangbin Liu
2026-09-01 15:06       ` Jakub Kicinski
2026-09-02  2:04         ` Hangbin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=apZzJDVtENpAluhT@fedora \
    --to=hangbin.liu@linux.dev \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=liuhangbin@kylinos.cn \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox