From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1B885519A2 for ; Wed, 9 Sep 2026 18:55:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788980123; cv=none; b=VWF8r4Xj/9bDUNaivuh9Ly1U0W3HkKejd1omaSmNvEcb9dunjZKUXyyGNXY5L+lBN/uHtdClQ0v9kWCBqJYI/sdGeks3dhktGwsNzFgAF5HvkiIDdHj5mr9kLESGe2433EdcXKlEITaEEFHE40wb51UKDVZ/qm+FC8QBHRheYyw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788980123; c=relaxed/simple; bh=U1NdQA2aJNUMNdQHV1yvInMQLf5QuGfXhDOBIEUVFTg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Gqq+Tnpykxd2aUBNR4Fvz626mFyvYXJSgjmyQ88hobnEDAYtMt6Dm2V4i8gzEiATerMLd+gykYwqoI8nSfQ9C+zpVgI9BpIjfi08w2zRjwRACCSWciI987ANAOEDDctmE1oBxbaHIeK40HiyOJ26X+bu0ZCrIlMJ7Ab596HfgSs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UBKV82pF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IirCt3Gu; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UBKV82pF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IirCt3Gu" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 689IgHXK2147058 for ; Wed, 9 Sep 2026 18:55:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=M5rvIWGTIvOTCE3UxEp1CtwJ p24SA8aalhpVBxX9P4c=; b=UBKV82pFgJhLWH2fGpTDOEjWYD13vt/8iJpHl8CP Wr99KKnwqJFy13Qd4uny+m/WphgkXa5cJ/2iqk8KchWGMv5GOzJvBZtqW0J53X5e DWwKK2h8e1LdBzzOU2ilj3+96RVr853RiUg4DYPAh/ekLdJUW2vgs6Qah9bZKqzn KKlCQF1AO6wDQd7rTmmaXaUUWjurunrQcUcPH50lY3way1V77/rcx5jZnZSdakXk QoFrzV2r0wmw4j+vXJLlgjQk80PSz1wG92C0GQiY8FcFYOZsu2bsWmlCXHsExeCK TOAWRQYBg3W1cogKlmAWR3bNqjA89QvEyn6+ocAG5M1UEA== Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gkcyfg2yx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 09 Sep 2026 18:55:18 +0000 (GMT) Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-78fa7ff1a44so342645137.1 for ; Wed, 09 Sep 2026 11:55:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788980118; x=1789584918; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=M5rvIWGTIvOTCE3UxEp1CtwJp24SA8aalhpVBxX9P4c=; b=IirCt3GuGiCMboTbA3d4HgfwpRQGh4tvs3IA9686PXb2KsPWswH4WeZ7rkML9EJX60 NAo+k+NA+ipBJu/MOAH5VNnroxp9po9TqPOmO/0U+f0TslYncH+WDxbM8JdajdY1bK2U 8YsuMxbkXM5rZ0DjAzyQUb0GymdPbHcH+cLhdULSiNh2M+9V38ahujt2O4Pcz5ZqTHjA hife1/IjTndzyC/NiXfBiKnlzbw+wOk4nqcyCfq4fcJltMhGygPVjwdOlkd+DPvGfZI6 jHtDWEW4+lRiaiSfADliZPDbmpBtzoaOpQkU33bkLl052XejRxlgrYCfUgYmJnT7r0SJ gANw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788980118; x=1789584918; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=M5rvIWGTIvOTCE3UxEp1CtwJp24SA8aalhpVBxX9P4c=; b=QvHhzBuVT2I9lPTcRmdhGmtAR+87WdAW7vmNmv/iqIdEZBHjXtqPKaZ332nsWN1Lkl lhIZzgqDC8caVwIquVHkyF4T5giPmDQ/przaTVqQGs2czngJmldX7uR6zM/GsqZZTwWD vE5BG2c9zg8bgbX/+iuBYSe9GH9KsD8l4ImRJZa1svFliWyqYDIWvgQCOx8CUR2FNmA4 bTQohVyaGLDXJmsmw4WnRX560zARteQunn5JeIeZn6oHcQIaJQ0r2CQqeaLtyamg0Oqb ZO2Spq8Zjis5hCXDWiNQSMmoyXJtptolcf9/gI9v1XFC3AjWmf1K3Pp0mt7XD6sy2jH1 imfw== X-Forwarded-Encrypted: i=1; AKwUvBxt9WwNap+pOvMwtsNbVSK/Cp7KEzTPPeZBeg0qk53Vk54WZL3X6tSQUJLFl7QGXzm6efw4Er0=@vger.kernel.org X-Gm-Message-State: AFuF++lzAPlqofrW9t8VoHdxdadjhcZThA0Qc5dILBKLBPM9Mlp54gP0 JXHdk3ShAT1Tk+l2LZZjI/dSTWrcZKrU3dvVfpno3HKZ9e4mST3EBUv3QcPzL55G92ehELLe/PC dpT/+amTKYvn0BvhbBQ0J2MCZ4aHDQlSZn6yp4V+zFNEnRyZ51CXYcJDr4FQ= X-Gm-Gg: AYBFou2TDsVyAMXVrGX55Yxk46MfTStrjX+D0uUaEoDvcGvtjOCoVx3cwka46aZhVW9 K7ZCYLgfzDSpJwVTH8FGxM/Lg+CH5+AoZiJm/LLdLiEEcOhY01UTEzLzVJSEwbKnhyTmI9HJrZG V7swStmDYtARFoeIfTkSlfGBMJ6E3EOG35cdRge0DFh580tUYoPmwRPWtCuLRFvYID8yCMMwHSU eekrovABfjhah2TXKHs1OWnaoU6bbUFfT2s/Ad8o4Tr+AL2HSjoryh2Ls6udt8pLSSxVnULypr+ 4mVntvgx8sHvC9mnaM0Oj42u/XUTAt8vckmsmu8lbwwb0uDAJyRYEI4XGuV2dz6RmzhoDucYkZd 5zBfA7fplJyBqoQ== X-Received: by 2002:a05:6102:6b01:b0:785:3211:f5e4 with SMTP id ada2fe7eead31-78a4a6c8a04mr16623478137.4.1788980117975; Wed, 09 Sep 2026 11:55:17 -0700 (PDT) X-Received: by 2002:a05:6102:6b01:b0:785:3211:f5e4 with SMTP id ada2fe7eead31-78a4a6c8a04mr16623409137.4.1788980116994; Wed, 09 Sep 2026 11:55:16 -0700 (PDT) Received: from localhost ([188.216.77.92]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49d26d49d57sm9738765e9.14.2026.09.09.11.55.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2026 11:55:15 -0700 (PDT) Date: Wed, 9 Sep 2026 20:55:15 +0200 From: Lorenzo Bianconi To: Mohd Ayaan Anwar Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Davis , Andrew Lunn , Heiner Kallweit , Russell King , Richard Cochran , Bjorn Andersson , Konrad Dybcio , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next v2 9/9] net: stmmac: qcom-ethqos: add Shikra EMAC support Message-ID: References: <20260908-shikra_ethernet-v2-0-bbe3389d0652@oss.qualcomm.com> <20260908-shikra_ethernet-v2-9-bbe3389d0652@oss.qualcomm.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hx4+qUIsDXNsQO4F" Content-Disposition: inline In-Reply-To: <20260908-shikra_ethernet-v2-9-bbe3389d0652@oss.qualcomm.com> X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA5MDIxMSBTYWx0ZWRfX9w9Rg2E3w9Hb 7eiv/CUb5qLChFMP9Oaeqg+ZGCDcWPLEWfoC2j52MOHpPnhaKSP2SfhtDvPTKBdxCyri1QlKDhe hZagphy16L8b0SbsgQOsWV2mFB/LDts= X-Proofpoint-ORIG-GUID: dHbZt6L06yHHmPSEuOjB81abeZc06ps8 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA5MDIxMSBTYWx0ZWRfX+/AoCPdpktV8 K/+e+vGXZox5IM/LGtuorUJYe3vTBGSAdOlGcWi3w5PeCqgmXxNeIvSyKkMuIk42Ed69vD5Gm43 3dB0wVU1mcopYHGnC9kEpaohfGPJZtNyqcDKSeM+rMVIGjsr3/b7u/0HeD2NgSwDJhMKKbq7iuo LQ/deyPY4jOm790RUnMJtYZasvXmlFGa0+O0zN9YKSNGTNBeLS85QZidYPu9XL1NxrqiFPQZIwj xTMmarnJBxyuw0D9pqz9DBaqZX2lF5y4gWEVwYCocSzwfV4y/iw0J5gw6Os6ocGKub9uLI8tHtz 2EqaOWU46vXRIAEM5d/1hdfmqXaVodrlMwW3dYnUFsy20TQ0zuGQXWyVBTvWPBDfoJ0RPtg0NrY hlm6gnyxkqluMuntCkTH3FtmkdgzD7JSdNDBKXfJPkEHW0O/RxaVsYvr9BAfObGv7nG8q1VYPZq 0RMDG/m2LR8rtDQ67jA== X-Authority-Analysis: v=2.4 cv=H5pOUOYi c=1 sm=1 tr=0 ts=6aa1ab96 cx=c_pps a=5HAIKLe1ejAbszaTRHs9Ug==:117 a=WpTaRW6qxYHRGzLzQsVYzg==:17 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=DFbXc3gujWXi7Ms4cGQA:9 a=CjuIK1q_8ugA:10 a=AyJwBSL0_NbV6ZD5tKsA:9 a=gYDTvv6II1OnSo0itH1n:22 X-Proofpoint-GUID: dHbZt6L06yHHmPSEuOjB81abeZc06ps8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_03,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 spamscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609090211 --hx4+qUIsDXNsQO4F Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > Shikra integrates two Qualcomm ETHQOS controllers based on the Synopsys > GMAC IP, similar to previous platforms. Register qcom,shikra-ethqos > backed by a new shikra_data descriptor that enables the three NOC clocks > required for DMA memory access (axi-noc, pcie-tile-axi-noc, stmmaceth) > all at 120 MHz, and the 36-bit DMA address width. >=20 > As part of the NOC clock voting logic, the qcom-ethqos glue driver takes > a second enable reference on the "stmmaceth" clock, which is already > enabled by the stmmac core. All three clocks in shikra_noc_clks[] must > run at 120 MHz for NOC access, and managing "stmmaceth" through the same > clk_bulk path keeps the rate-setting and enable/disable together. >=20 > Signed-off-by: Mohd Ayaan Anwar > --- > .../ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 31 ++++++++++++++++= ++++++ > 1 file changed, 31 insertions(+) >=20 > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/dr= ivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > index 8871d285941162c72e2a8f79d2eef915d9283796..c474f1e5a043777a52bcbff8a= 488640f6dbdca30 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > @@ -328,6 +328,36 @@ static const struct ethqos_emac_driver_data emac_v4_= 0_0_data =3D { > }, > }; > =20 > +static const struct ethqos_noc_clk_cfg shikra_noc_clks[] =3D { > + { "axi-noc", 120000000 }, > + { "pcie-tile-axi-noc", 120000000 }, > + { "stmmaceth", 120000000 }, > +}; > + > +static const struct ethqos_emac_driver_data shikra_data =3D { > + .dma_addr_width =3D 36, > + .has_emac_ge_3 =3D true, > + .noc_clk_cfg =3D shikra_noc_clks, > + .num_noc_clks =3D ARRAY_SIZE(shikra_noc_clks), > + .rgmii_config_loopback_en =3D false, > + .dwmac4_addrs =3D { nit: this part seems in common between emac_v3_0_0, emac_v4_0_0 and shikraemac_v3_0_0, emac_v3_0_0 and shikra. Can we add a common definition? E.g. static const struct dwmac4_addrs qcom_emac_dwmac4_addrs { ... }; Regards, Lorenzo > + .dma_chan =3D 0x00008100, > + .dma_chan_offset =3D 0x1000, > + .mtl_chan =3D 0x00008000, > + .mtl_chan_offset =3D 0x1000, > + .mtl_ets_ctrl =3D 0x00008010, > + .mtl_ets_ctrl_offset =3D 0x1000, > + .mtl_txq_weight =3D 0x00008018, > + .mtl_txq_weight_offset =3D 0x1000, > + .mtl_send_slp_cred =3D 0x0000801c, > + .mtl_send_slp_cred_offset =3D 0x1000, > + .mtl_high_cred =3D 0x00008020, > + .mtl_high_cred_offset =3D 0x1000, > + .mtl_low_cred =3D 0x00008024, > + .mtl_low_cred_offset =3D 0x1000, > + }, > +}; > + > static int ethqos_dll_configure(struct qcom_ethqos *ethqos) > { > struct device *dev =3D ðqos->pdev->dev; > @@ -962,6 +992,7 @@ static const struct of_device_id qcom_ethqos_match[] = =3D { > { .compatible =3D "qcom,qcs404-ethqos", .data =3D &emac_v2_3_0_data}, > { .compatible =3D "qcom,sa8775p-ethqos", .data =3D &emac_v4_0_0_data}, > { .compatible =3D "qcom,sc8280xp-ethqos", .data =3D &emac_v3_0_0_data}, > + { .compatible =3D "qcom,shikra-ethqos", .data =3D &shikra_data}, > { .compatible =3D "qcom,sm8150-ethqos", .data =3D &emac_v2_1_0_data}, > { } > }; >=20 > --=20 > 2.34.1 >=20 >=20 --hx4+qUIsDXNsQO4F Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCaqGrkwAKCRA6cBh0uS2t rArrAP9R8xEG+zLWVTIluHMbwn06eRZVDw4njA5XwSEu+LwHrQEAo4TJM5euvbra 4jutQknO4Wvvhxx1ELycGgKuzOGCTw0= =m+rn -----END PGP SIGNATURE----- --hx4+qUIsDXNsQO4F--