From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D21965476E3 for ; Thu, 10 Sep 2026 17:10:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789060249; cv=none; b=Tem2DU4Axz4Gbqcj+g26SULBjOw51FP7gYjP4Ib1fy+CUaLgslu8uFIzYK9Zak7tJWMQAz+uzt4il+/gbuYszmnTIqL17ZljW6q91FNzISxlLX/KxLC2uX8nixhaSohdCqgvHLH3s/NqnRNIxYvjKXk+pmxVwjlCNugkiJDZy/o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789060249; c=relaxed/simple; bh=AwlQr01gOaB0513mqpwbFOstgch6p4TPUaapjmXe+RY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BJACBRFrRkQ9N3kOL+3D9yMVkXpO+yyi/OkNT/CCAXII6cK3owQ4KX9ih9Kiv6fGlOG+gR/DkWfwszHt+Q4fB1C94dnc8MuOhsZQ8HG/BT1HU86mQrnOkT7w6zNu4aNONgK+3nP5fJjI3oVzXSkHFrfjpGj5Wc8tjZSj6RDOmzU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OCZlT8j0; arc=none smtp.client-ip=209.85.210.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OCZlT8j0" Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-7f4b94d72acso6469038a34.1 for ; Thu, 10 Sep 2026 10:10:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789060233; x=1789665033; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=SKblG7QGgHAKfTpoP5V52jptdTaAh+yb1fvW/oZI/IE=; b=OCZlT8j0W2JHYXYuFrVsfFyBxVmmuswYK2evkd+cQVjm4wogqIAXwfkXYm3TDRigyU LrWNq+tV3Iq/Mk4R0UZZTxQIm0HW3z4H2EvIyMbz3dp9AtxADgl/oBAdclNEq4cKKmi1 INzVHWPGQDzygJc+grrGVlDqrCyNTfoZamId2UOaDTVXUZvCoxvIrT76q4kGNsbUbMKz xsVR84gssQUocZLpWf1/QED5StTp7baWw3NlrmL0Vcr0opFYtqj3rGthmsixO4HGQsP9 5ULnT2jrYy0EiPIms6jJC+DK6RCezYFZe7CfOY0uoxfiw5n4osqL31IMjeO0UAVD+5/j Zi3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789060233; x=1789665033; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=SKblG7QGgHAKfTpoP5V52jptdTaAh+yb1fvW/oZI/IE=; b=KgWKWi9msA3BZK6vDm0D7XeMNzdPX1p3Ugu8CdIXaUKsgdO51WldX3FXGZCnK2ogdq 4L0D3PG4AuRF3RBsugMQIkCcSWbsRRj0cvZ7Ci+gLbRsVVHwOM9eZL552YKAbnWPGV5I bkAAlQW9YV/JP0GYEb03OQN+72lbpjOGTbtS6SXZvEal0gCRXtJrfv93a4ELzZVjo4G2 Uk+a4EhyCQoi8Moil4SWFUUPjqnrczuaqT1SBD6cTAbTYfSFUfn2YCSBWOQZo4QL1W1E MGfQYsxv7T+bT65AYTPKBccGnya0skxsgMN4i0uGhMbeKMRz5yz8x2l8bxKFgYMinhFW wmXA== X-Forwarded-Encrypted: i=1; AKwUvBy4Lbl3KyDQQqR8dBNuHrCIrU0vcrZKunpbX/p0sDFyHBVZ84geJx893jwQgbQh4QTgAQmsB0M=@vger.kernel.org X-Gm-Message-State: AFuF++lcHO2YgsOb3O9+9bkrt7iO/t+P7T2grG+r22NbdRNYRzIWIsDz Nt5r/VbU6OjSzflxG5msr67di1XX5vbBu6gtoJ5W28YGjKYECyp56Qz0 X-Gm-Gg: AYBFou3XOPcu4LDn+eHX/WTrAOUD4urFE4Z0zrm53+m+wZsMaxcCSluar2CRUCdtDSa o/OquXCdXrUKUOYfHOGtCytLA48L0284YREEp6j5LqR+2kF6x+C7+Jdby0JcUOdAq7kp/a380gl 5ptniy/f2cENrNz5EF3YCa3WJrB0p8UGqM3M4sdU0YNUiy8AZ8D2FwPFeB74PDGyKC+etlDQdHn Rp+vx4RQlyb50Z32b45WnmFixTT0uvdK1UQl7mhqL/AD2P5nZchSP247aAoQnEWZdEb0L6+9U6L tbk1e5iUFpc2IovxgSw35FWjM8NgxB4Zx7EMq6pXQrFurH6m7f6CxLkiW4co0IEQr56/AKs0WJB UJYYLh0vYc7W+Hk/2Y88F1T7++3piCYLqYZA8frEQYrMkAGBTvuInMVw9z23lDkBJhbg5ez9R27 Qd3jl42CdJBwB76D75cSbtE/2vgqrhL4px0wRxO5UNT5vdbkfguG6v1YG8leFFLWwD5D44eEb7V FhN11dhk/g+EiWCj1YdjFd4yLut6w== X-Received: by 2002:a05:6830:258d:b0:7f6:6618:e506 with SMTP id 46e09a7af769-7fa207af645mr26042050a34.14.1789060233518; Thu, 10 Sep 2026 10:10:33 -0700 (PDT) Received: from devvm29614.prn0.facebook.com ([2a03:2880:ff:8::]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7fcc45d7852sm14860896a34.20.2026.09.10.10.10.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2026 10:10:32 -0700 (PDT) Date: Thu, 10 Sep 2026 10:10:29 -0700 From: Bobby Eshleman To: "Maxime Chevallier (Netdev Foundation)" Cc: Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Donald Hunter , Simon Horman , Shuah Khan , matttbe@kernel.org, Stanislav Fomichev , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, linux-kselftest@vger.kernel.org Subject: Re: [PATCH net-next] tools: ynl: Fix out-of-tree build for ynltool Message-ID: References: <20260909071155.1234922-1-maxime.chevallier@bootlin.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260909071155.1234922-1-maxime.chevallier@bootlin.com> On Wed, Sep 09, 2026 at 09:11:54AM +0200, Maxime Chevallier (Netdev Foundation) wrote: > After the blamed commit, running a out-of-tree build for ynltool fails : > > # make -C tools/net/ynl/ynltool O=/tmp/o1 > make: Entering directory 'tools/net/ynl/ynltool' > make: *** No rule to make target '/tmp/o1/json_writer.o', needed by '/tmp/o1/ynltool'. Stop. > > ynltool's Makefile correctly accounts for $(OUTPUT) to get the list of > object files to generate : > > OBJS := $(patsubst %.c,$(OUTPUT)%.o,$(SRCS)) > > but it never actually set $(OUTPUT) before the blamed commit, meaning > that out-of-tree buils of ynltool were always actually in-tree. > > Now, the O= parameter is correctly accounted for, and the %o: %c rule fails. > > Let's update the %o: %c rule to also use $(OUTPUT). > > Reported-by: Bobby Eshleman > Closes: https://lore.kernel.org/all/aqCyWQxqKDuQnZYR@devvm29614.prn0.facebook.com/ > Fixes: 917f713b4ec4 ("tools: ynl: Allow cross-compiling ynl and associated tools") > Signed-off-by: Maxime Chevallier (Netdev Foundation) > --- > Targetting net-next, as the blamed commit lives there. > > tools/net/ynl/ynltool/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/net/ynl/ynltool/Makefile b/tools/net/ynl/ynltool/Makefile > index b8c67cdb4fdf..1053e7606c86 100644 > --- a/tools/net/ynl/ynltool/Makefile > +++ b/tools/net/ynl/ynltool/Makefile > @@ -31,7 +31,7 @@ $(YNLTOOL): ../libynl.a $(OBJS) > $(Q)echo -e "\tLINK $@" > $(Q)$(CC) $(CFLAGS) -o $@ $(OBJS) ../libynl.a -lm > > -%.o: %.c ../libynl.a > +$(OUTPUT)%.o: %.c ../libynl.a > $(Q)echo -e "\tCC $@" > $(Q)$(COMPILE.c) -MMD -c -o $@ $< > > -- > 2.55.0 > Reviewed-by: Bobby Eshleman