Re: [PATCH v2 2/3] usb: misc: Use %pe to print error pointers

[Frank Li <Frank.li@oss.nxp.com>]

On Sat, Aug 01, 2026 at 05:59:51PM +0530, Subasri S wrote:
> Use the %pe format specifier instead of %ld with PTR_ERR() for printing
> error pointers in various drivers across usb subsystem.
> This prints symbolic error names (e.g.-ENOMEM) instead of
> errno numbers (e.g. -12), making error logs more readable.
>
> Fix coccinelle reported warnings:
> WARNING: Consider using %pe to print PTR_ERR()
>
> Compile tested only.
>
> Signed-off-by: Subasri S <subasris1210@gmail.com>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  drivers/usb/atm/usbatm.c               | 4 ++--
>  drivers/usb/core/hub.c                 | 3 +--
>  drivers/usb/dwc2/pci.c                 | 3 +--
>  drivers/usb/gadget/function/u_serial.c | 4 ++--
>  drivers/usb/misc/usb3503.c             | 3 +--
>  5 files changed, 7 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/usb/atm/usbatm.c b/drivers/usb/atm/usbatm.c
> index 9600e1ec0993..c78caa1b57c9 100644
> --- a/drivers/usb/atm/usbatm.c
> +++ b/drivers/usb/atm/usbatm.c
> @@ -979,8 +979,8 @@ static int usbatm_heavy_init(struct usbatm_data *instance)
>  	t = kthread_create(usbatm_do_heavy_init, instance, "%s",
>  			instance->driver->driver_name);
>  	if (IS_ERR(t)) {
> -		usb_err(instance, "%s: failed to create kernel_thread (%ld)!\n",
> -				__func__, PTR_ERR(t));
> +		usb_err(instance, "%s: failed to create kernel_thread (%pe)!\n",
> +				__func__, t);
>  		return PTR_ERR(t);
>  	}
>
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index 5262e11c12cd..8c750a93c350 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -5671,8 +5671,7 @@ static void hub_port_connect_change(struct usb_hub *hub, int port1,
>  			descr = usb_get_device_descriptor(udev);
>  			if (IS_ERR(descr)) {
>  				dev_dbg(&udev->dev,
> -						"can't read device descriptor %ld\n",
> -						PTR_ERR(descr));
> +						"can't read device descriptor %pe\n", descr);
>  			} else {
>  				if (descriptors_changed(udev, descr,
>  						udev->bos)) {
> diff --git a/drivers/usb/dwc2/pci.c b/drivers/usb/dwc2/pci.c
> index f3a1e4232a31..7ff9c4df941e 100644
> --- a/drivers/usb/dwc2/pci.c
> +++ b/drivers/usb/dwc2/pci.c
> @@ -68,8 +68,7 @@ static int dwc2_pci_probe(struct pci_dev *pci,
>
>  	phy = usb_phy_generic_register();
>  	if (IS_ERR(phy)) {
> -		dev_err(dev, "error registering generic PHY (%ld)\n",
> -			PTR_ERR(phy));
> +		dev_err(dev, "error registering generic PHY (%pe)\n", phy);
>  		return PTR_ERR(phy);
>  	}
>
> diff --git a/drivers/usb/gadget/function/u_serial.c b/drivers/usb/gadget/function/u_serial.c
> index cdd1dfc666c4..da31e5cea0a5 100644
> --- a/drivers/usb/gadget/function/u_serial.c
> +++ b/drivers/usb/gadget/function/u_serial.c
> @@ -1311,8 +1311,8 @@ int gserial_alloc_line_no_console(unsigned char *line_num)
>  	tty_dev = tty_port_register_device(&port->port,
>  			gs_tty_driver, port_num, NULL);
>  	if (IS_ERR(tty_dev)) {
> -		pr_err("%s: failed to register tty for port %d, err %ld\n",
> -				__func__, port_num, PTR_ERR(tty_dev));
> +		pr_err("%s: failed to register tty for port %d, err %pe\n",
> +				__func__, port_num, tty_dev);
>
>  		ret = PTR_ERR(tty_dev);
>  		mutex_lock(&ports[port_num].lock);
> diff --git a/drivers/usb/misc/usb3503.c b/drivers/usb/misc/usb3503.c
> index 759770a13260..1160dc594b1c 100644
> --- a/drivers/usb/misc/usb3503.c
> +++ b/drivers/usb/misc/usb3503.c
> @@ -202,8 +202,7 @@ static int usb3503_probe(struct usb3503 *hub)
>
>  		hub->clk = devm_clk_get_optional(dev, "refclk");
>  		if (IS_ERR(hub->clk)) {
> -			dev_err(dev, "unable to request refclk (%ld)\n",
> -					PTR_ERR(hub->clk));
> +			dev_err(dev, "unable to request refclk (%pe)\n", hub->clk);
>  			return PTR_ERR(hub->clk);
>  		}
>
>
> --
> 2.43.0
>