From: Dominique Martinet <asmadeus@codewreck.org>
To: Ze Tan <tanze@kylinos.cn>
Cc: ericvh@kernel.org, lucho@ionkov.net, linux_oss@crudebyte.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
v9fs@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] net/9p: safely abort fd RPCs on fatal signals
Date: Mon, 14 Sep 2026 00:59:31 +0900 [thread overview]
Message-ID: <aqbIY53PWehECvuQ@codewreck.org> (raw)
In-Reply-To: <cover.1784186316.git.tanze@kylinos.cn>
Ze Tan wrote on Thu, Jul 16, 2026 at 03:30:48PM +0800:
> This series fixes a hung task reported by Syzkaller when a thread blocked
> in a 9p fd RPC receives a fatal signal while another thread in the same
> group is waiting in coredump_wait(). The interrupted RPC currently enters
> the TFLUSH path and can wait indefinitely if the 9p server is no longer
> responding, preventing the thread from exiting and the coredump from
> completing.
Thanks for the patches and sorry for lack of reply
I'm sorry but I'm cutting this out for the forseeable future:
You can't just abort a request you sent without flushing, for example
if a mkdir() call is interrupted it should be failed and the next
mkdir() must succeed (if it wasn't raced) but with an aborted request
you could have the directory be created in the back of the aborted
request.
I actually had a branch with 'async flush' a few years back but there
were subtle regressions and I never had to look further into it, and I
have even less time now, so I'm sorry but unless you're very convincing
I won't take these (other maintainers may have different opinions if you
can get any of them to look, that won't be my problem then)
--
Dominique Martinet | Asmadeus
prev parent reply other threads:[~2026-09-13 15:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 7:30 [PATCH v2 0/3] net/9p: safely abort fd RPCs on fatal signals Ze Tan
2026-07-16 7:30 ` [PATCH v2 1/3] net/9p: handle replies racing with interrupted RPCs Ze Tan
2026-07-16 7:30 ` [PATCH v2 2/3] net/9p: prepare fd transports for asynchronous aborts Ze Tan
2026-07-16 7:30 ` [PATCH v2 3/3] net/9p: abort interrupted fd RPCs on fatal signals Ze Tan
2026-09-13 15:59 ` Dominique Martinet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqbIY53PWehECvuQ@codewreck.org \
--to=asmadeus@codewreck.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ericvh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=netdev@vger.kernel.org \
--cc=tanze@kylinos.cn \
--cc=v9fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox