From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F37342DC331 for ; Wed, 16 Sep 2026 12:30:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789561828; cv=none; b=ainpzDXZNH9p0NQ01FKJuy1slkO/oi+t7XqiQjxQpGTDbCqeJWo4Xy+y61EbgQpJCUdRI9qjvG5jlkK4QWCBVsDCXJsHO55a66Qb7abvkPTR0z3nQM4vGiSSw187jQ3dMxea3pl9+cpjI0LaazFM3avCSjn96IEqhZ8UYf9RjVs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789561828; c=relaxed/simple; bh=Fmhcgo0917MgP6Yewu3ZjCmJzTY2NacAiSJbTsPkO7k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ehvHN0bRtGs8FMBO7ZeQFusOf9mwW3/un8ZE991PlhlNuF3KWJqZg6mNQ0FNZg+p6dhQzwsDfSQFAWNMkkg9N86uEArGfedqIbpGGOCssvBEQLhPJ2+KiU2Kkm4Lh4eCPc2k+Lh0FGpsUGNGN6tYTpPH2+eOrVID2Bre4I9gYx4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=XQaeTSyF; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=gEL8QAVM; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XQaeTSyF"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="gEL8QAVM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1789561825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Rqm8tyx2h9IoJaqWWUmjhp0Aa68nUfNy8FsMl7kX/nI=; b=XQaeTSyFLzbvk/4KmviPYJcLD1lDd456NbMxkg3+nr/wjOU834Ar1LMRlADilD4LKwUB9J QkPAbuj9iUyu18pf8C8UsLhdG5XoxYy7qxOvejuBIBm+59W4uzr1tovto8CQ3oip9k028G TgmJgLgB3SoSEzkXvJm2oIuu+k3wlAc= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-324-xDHXFnwMP6eXO4PpWdT6kQ-1; Wed, 16 Sep 2026 08:30:23 -0400 X-MC-Unique: xDHXFnwMP6eXO4PpWdT6kQ-1 X-Mimecast-MFC-AGG-ID: xDHXFnwMP6eXO4PpWdT6kQ_1789561822 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-48589603501so3265370f8f.3 for ; Wed, 16 Sep 2026 05:30:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1789561822; x=1790166622; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Rqm8tyx2h9IoJaqWWUmjhp0Aa68nUfNy8FsMl7kX/nI=; b=gEL8QAVM+uTzeFyDj8Fo0B1Bnboxr3hiqPOHoxCqsnGp8AOJ4cncQb8H7QNbsz4hMf TxKnkv7WqKBN00wwF7cyTkMo+Bhdp1Ejr9MXEZCQ95kJ/L1cMj2D27VBNdi2+KNS5Wt5 HYsiw4PjlFkW/JTEtd1jIKirB+VOFjIijfZjKCrBI94A4eGZCttCladspb8tQyxFg+XZ 7TK/KwOx9VvlfuSiCEyaslKeGzLzi8O3ohO6Vw9jyWRL3yeFQQfnVVu3iIjqCVga4DoV fpENBwQgt1GsiuRHPg1euRt7bZc3gmu3FpO9MT0YX42J5D+j1y5BK7y/Lb9C+wFhj0Ah abdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789561822; x=1790166622; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Rqm8tyx2h9IoJaqWWUmjhp0Aa68nUfNy8FsMl7kX/nI=; b=dKGFEdbY8KEj6P2zmRQiwPAdlJdlPQcpUSSjhZGAqBHXRZePLH6ySao1Qk6nwLXk3i HXoeF7rji5JqZy+PPC7/4YIWuJ7tCcXDvbkSQnG+uurDjc3nuKSIm1Jm0Je34RDgMDDl d5zaHoav0LMQ8JAfDY6FKMjlWBKnejG6Yr+dj3Mayrj7kiNMZRqtrSDW7p4Ne8ZphZ1B V7A2Ub+8tXi0XFcPFJ9RU/F3BoVdazCgkJv/f0fcTSUDT1M6K68k0RKi7g61H4Ya50By ++oNoleCidZQzlhBBlYS4OErM2zO74GqEpCSOJl3uDTTOxMYAOnWgZUYRvlrhfFaNloO A0WQ== X-Forwarded-Encrypted: i=1; AKwUvBxEKU3h7dVUAXZMTodyOAPkIRxgBKzgicGzWa/dYb3igZyHHM37PRnmB3p2g20WMw7QhpuSq+k=@vger.kernel.org X-Gm-Message-State: AFuF++lU7x9irx2QhUvbTzXdGFBPWDOAMnBT8D7caXuiLsus+CbS67YJ k9PJwa8enYpfs2C/T4SvjH+QU9qot/4Y9sL+iQf3MZ7dJ07v23x4gsf6ZDdnrmR9W+yVdauMTMh KbRdEm7jv2Dj+5ij7i2CXbBK/5QKAk/6isfExovghJZt93EKzpwwJj/uwvQ== X-Gm-Gg: AYBFou38TpoRtvIE/3/jt+/v4GGoiVZRse9uBEVk0Oo0ofQiJmhNv/eNR+Z5yMnpGBI CGc9iPDgTbMrn/JypbNGXxSetm/rMnZnMoRCFh++xQ9fibSPw29m4q9uOGqFUMxvcJpgAC04nQw iyMy/e0Y6uaDOKppN6uqLcK4ONXyT3oWk8343TkuiCDoCndQwTov6qUY255ecLFVC+RV4wL8cpb 0bWERbOknZ9Boc9Sa1EE19rnycEgoC3NAxb91EavT75FFIhyEk2bxc7tue2L1lCIE9GytUASXjG 8abC+hmGZiiOihmLTr9+7vVuWmwUNgeM8uw/vx072yT6ewG/dJLz42pCrcp+ZU+KR4zW/rA2Qnr SNfYr3jsx1EwefqLDRXXDldxDqGfjaJ2tfpnxFnQwKoxtxA== X-Received: by 2002:a05:6000:2003:b0:487:41c:175e with SMTP id ffacd0b85a97d-4870d03fdabmr2882243f8f.22.1789561822265; Wed, 16 Sep 2026 05:30:22 -0700 (PDT) X-Received: by 2002:a05:6000:2003:b0:487:41c:175e with SMTP id ffacd0b85a97d-4870d03fdabmr2882180f8f.22.1789561821702; Wed, 16 Sep 2026 05:30:21 -0700 (PDT) Received: from sgarzare-redhat (host-79-53-30-11.retail.telecomitalia.it. [79.53.30.11]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4870bf413dcsm6941143f8f.31.2026.09.16.05.30.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 05:30:21 -0700 (PDT) Date: Wed, 16 Sep 2026 14:30:14 +0200 From: Stefano Garzarella To: Michal Luczaj Cc: Stefan Hajnoczi , "Michael S. Tsirkin" , Jason Wang , Eugenio =?utf-8?B?UMOpcmV6?= , "David S. Miller" , Xuan Zhuo , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Asias He , kvm@vger.kernel.org, virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v2 2/5] vsock/virtio: Streamline socket reset on transport/PM event Message-ID: References: <20260915-vsock-connect-reset-closing-v2-0-a1d9abb472f7@rbox.co> <20260915-vsock-connect-reset-closing-v2-2-a1d9abb472f7@rbox.co> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20260915-vsock-connect-reset-closing-v2-2-a1d9abb472f7@rbox.co> On Tue, Sep 15, 2026 at 03:15:13PM +0200, Michal Luczaj wrote: >Follow vhost's vhost_vsock_reset_orphans() and VMCI's >vmci_transport_handle_detach(): set SHUTDOWN_MASK, which will come handy >later in the series. IMO it would be better to include the reason here as well. Every commit should explain why doing a change. > >Note that commit c38f57da428b ("vhost/vsock: fix reset orphans race with >close timeout") fixed a race between pending close timer, i.e. >virtio_transport_close_timeout(), and a transport/PM reset. But here we >never set SOCK_DONE, hence no race. > >Fixes: 0ea9e1d3a9e3 ("VSOCK: Introduce virtio_transport.ko") >Signed-off-by: Michal Luczaj >--- > net/vmw_vsock/virtio_transport.c | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c >index 4f9aa9c4c3aa..4d6991321699 100644 >--- a/net/vmw_vsock/virtio_transport.c >+++ b/net/vmw_vsock/virtio_transport.c >@@ -413,11 +413,14 @@ static void virtio_vsock_event_fill(struct virtio_vsock *vsock) > > static void virtio_vsock_reset_sock(struct sock *sk) > { >+ struct vsock_sock *vsk = vsock_sk(sk); >+ > /* vmci_transport.c doesn't take sk_lock here either. At least we're > * under vsock_table_lock so the sock cannot disappear while we're > * executing. > */ > >+ vsk->peer_shutdown = SHUTDOWN_MASK; In all other places we use WRITE_ONCE/READ_ONCE on vsk->peer_shutdown, should we do the same here? Thanks, Stefano > sk->sk_state = TCP_CLOSE; > sk->sk_err = ECONNRESET; > sk_error_report(sk); > >-- 2.55.0 >