From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1341357D0F for ; Fri, 18 Sep 2026 05:18:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789708701; cv=none; b=sN6MDCrZRRrlM5Bk6fz8K92epqLzUoPwves6J330rk4EdTPUhA65DCA1m/S6Aw9J/wlNQViCB197gW28RH9AEs2ZWCadFAK/hppnp7uzvicHKhntMZ063WfawhWFWFfhiDfyOFpbEot8mxRN/R3txoMqjF/zZfAFGR8TYUypO+4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789708701; c=relaxed/simple; bh=KpCOGBtg1kn7vEKf3x1UtZtSMIts6JSL1bQ3R6nvIMU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WLaYx/YorJzkJTFVuzUtet1/gZ/sVf2DvPP2FtXjXgSeNcqibZJg0Y5RtWaZbx1x6Gnnjhb61GRDSiUb5oV7/FPw4F763rIa6wjEGrj9JeM2qAoe1Qc0twQFtz0RpLUxuJhqHHbygEajJ7wzeeo4QqXKrfMehKHnS8uSom2LzVk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=INqJ3+Oa; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fuiiAUNy; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="INqJ3+Oa"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fuiiAUNy" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68I3FUuk3588896 for ; Fri, 18 Sep 2026 05:18:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= HsKz2/5LlR7nT+hESyfXy9LutazAFBvD636fITNFVss=; b=INqJ3+OaRZXqNIYA n6WQvl7GM6ZXVB7ZmEAT9qRWU5sq911XCkwihzWGZs9FTioZJwhN1OeUc+WEt8T4 jTYUi+0NzQ2erJ3GkPeUVMSTNuvecWq2xh9zV0Td0jpD50Le3mQyVkIo9py94O6l uFar4yzNvwwVfSu078qqGINrmsvyTqLw4Dfsx5l1U8zi5ROY/uHgMkP4AEB0s7Mq z1znaSbAQ9oEpnO1d1zdsK9nmf5DMPrtVqmt1Dn4tXPrZbiN2TF/AbGLHjY/njmm 0rQtqN6RyD0Z7WHJt65ZsGWEke5q0Cs9LPWuF2lrRTprzYMsLnHA/n2OQg10ednG fZ83ww== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4grjkt38ms-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 18 Sep 2026 05:18:18 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2dd667770efso16041165ad.0 for ; Thu, 17 Sep 2026 22:18:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789708698; x=1790313498; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=HsKz2/5LlR7nT+hESyfXy9LutazAFBvD636fITNFVss=; b=fuiiAUNyu9rnmV64fRFgGZ6Zo0Ar4Cpm+/bHQIsfi1rktH4WuiZwql2NobCPwqINlV 2aOyE0FyjlM4aMPR42lSdnT+k+IxhrFLYyCXQnQjpR9qRiNJ5V2C3s+2fOYKupixQyrT XbaNp5x0ChZ4LdkTIPs9T28IwHGS7LNyON8MGyLLHtzntbpFehE3RAxQFMibJlKHjPMH d8Kf5k/dCajVNivxxbo/mphzudrSMcPJhYv6xmMXwOAtNff6SW8zdk/nxCQfhCo51XB6 ktpzvTo4ZQggjIYa/vrNIU5BuZxUgjvis5O42qQxBYqb/aB9MdJVPwtOBo3NqqZFPo9f ZCaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789708698; x=1790313498; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=HsKz2/5LlR7nT+hESyfXy9LutazAFBvD636fITNFVss=; b=aLkLaVIZ/tVKwm09W9AczQR6Z2K4AmA77dzzelUrGlexW1F5eYANOnupncQT0/dVwt 4Ss9yTDZJphy9DudYhgGllqqg6AsglHa16bPa244TfA7qAb7jboU3Q6Tlcb5O8AOZkln BEUBpPWY4GLjgZnnXFdYKy/h8hpmc5PfN3CkJzQdbi6rt6mJedTeawr/o776Be8IdKPV CJgGi3/5oEVl/e7SkcXXrG6+3PV692FIyYiCx8b7ltZ6mJZuikragw2sVff9PkSw5TDB /Xcdj2st8bk/nBIyoOreNhGYdHECOOIanQOlJ4sbwUfuvhjWrKquYdvBfmcGv92C8Jko lP2g== X-Forwarded-Encrypted: i=1; AKwUvBybg+mArwhZOjAISeGofe7IXO270DPWT3yjI29smDbXa3KLHfF2YQ4wJkSU3wqdnBqfZwa3h1k=@vger.kernel.org X-Gm-Message-State: AFuF++ktDwMfg1QEja0IsLkp3xU5EOxlT34bX9B8hlphIKllnN8hY2vX TTh0GctmtBSZ5y8UnMVx+ZjdqGX1FQev8Kolwfkr+rikEJ+3zOnQlcIIKQiyQCXREQfKsQFHwXT gIkGkrCTg3H2SWBjIlwhKS92A4MrvENuR008Id11AICaxriMYiN1mNMZd+Eg= X-Gm-Gg: AYBFou1xo3wF9JiV/kVa1RkdQr1imnfjvE+avO4NlndngKEOIc4yAr3sxl+nhZsaVWX ub9/4nXGxn907fAit2wxJ2TS//TtJB83pk7cgFeOZ9X8IW7XWkOnGQ+25Bis1KWThA957nkyopa 5oPvThlLw+JR/HoEf2TI914EfJ5GpqReQDMYt+PMQUBwqvNxZLhaEPsjVvzBWooTsX+C3SVHINa KjbFm1AFhD3pDM0QoV/eGjtVhxNkiOdNMf4lI3/u0hyUpQT7EY7hQYt2WWZ/vj4RobNCFEQvnDQ lxpV0TmWER+i3VsRIrA6c8kn14xBkqlALEfcWtraJ47lMg7jh739v/cCgq239pK0MITw4I1czUs 3/xFciwpMfnS2yg== X-Received: by 2002:a17:902:f68b:b0:2d0:401c:2edc with SMTP id d9443c01a7336-2dd9c6b9174mr80332885ad.1.1789708697640; Thu, 17 Sep 2026 22:18:17 -0700 (PDT) X-Received: by 2002:a17:902:f68b:b0:2d0:401c:2edc with SMTP id d9443c01a7336-2dd9c6b9174mr80332495ad.1.1789708697155; Thu, 17 Sep 2026 22:18:17 -0700 (PDT) Received: from oss.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33c286d98c6sm1220454eec.5.2026.09.17.22.18.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2026 22:18:16 -0700 (PDT) Date: Fri, 18 Sep 2026 10:48:09 +0530 From: Mohd Ayaan Anwar To: Thomas Karpiniec Cc: Coia Prant , Maxime Chevallier , netdev@vger.kernel.org, Russell King , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Choong Yong Liang , Bartosz Golaszewski , Russell King , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net 2/2] net: stmmac: qcom-ethqos: advertise supported SerDes interfaces Message-ID: References: <97924d2f-45f9-44d5-b482-97fcbb70abdc@bootlin.com> <3bdf2ecc-9dd1-428c-8841-36b1f19916e7@bootlin.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE4MDA2NyBTYWx0ZWRfX8xksmcfsDmfy O4ke0oKGgAEcaDGN7DgOLp5/DJCXV6Nr3kcB7/t0XqSOjTypl+gpL59NMuwlk8bys234ds1MOXK gUATMYVLOcx3QThliLja2gRxBiuEDwdYSkyCRn4yE+9+MsSCcZbJaeKgJxMnF5zMQ49UdYKv96s o/v1VMM9zFgQrjpjDZRcJhylSAfV/h8BBenWXGDdX/hUv3vPQjWEAxgU9qa3xk3MQXDMRfMu93q GeZRVWrus0JWMge5dxzgTvQDw4D9OYgvcSmnUd6zzGIwEmYU+UzQxupfqmapsmBKwxyXD7i2b1P PxxO6g+Z+cs1d5nZOEY8ZWwbgZanbwOkF0VKZCZP9tVt/uKdTPCGvy+g5k4P42cHi7Ur8lKbaAd JCtZ77qxRCyH87cJThpi61j7qtMAM67MD0I2+YXBuEUUYGWCCA8f1CrITOFpx8B97EhMT3C6ph4 WlZrbWStTWd0OhCH82g== X-Proofpoint-GUID: kmU-wPKSLQb6zoRJ106n2NW5i_dZJe0E X-Proofpoint-ORIG-GUID: kmU-wPKSLQb6zoRJ106n2NW5i_dZJe0E X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE4MDA2NyBTYWx0ZWRfX8n+PLavlM5Vz at5d0o33yoY3nfekoJRreLEiNtwfQIb3XyjNm8kgaTp9EegFPabneAjsU/9wMFIupTiC+7zufWJ ePcYOTmAEyIxhdHtT4niqLhrPNc7iFE= X-Authority-Analysis: v=2.4 cv=Y/VtIReN c=1 sm=1 tr=0 ts=6aacc99a cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=P-IC7800AAAA:8 a=zWtJOzQAR9QYW-IJ8IAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-18_01,2026-09-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 suspectscore=0 spamscore=0 adultscore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609180067 On Fri, Sep 18, 2026 at 02:36:04PM +1000, Thomas Karpiniec wrote: > On 17/09/2026 6:21 pm, Coia Prant wrote: > > Maxime Chevallier 于2026年9月17日周四 13:36写道： > > > On 9/17/26 06:29, Thomas Karpiniec wrote: > > > > I tested setting STMMAC_FLAG_SERDES_SUPPORTS_2500M on hardware and unfortunately the flag alone doesn't solve the problem. > > > > > > Yeah, but it's still the right first move. Russell planned to do that as well > > > > > I think there are a couple of things missing. stmmac_phylink_setup doesn't use the integrated PCS bitmap to populate config->supported_interfaces, so SGMII is still not advertised to phylink as a usable host interface. Also stmmac_integrated_pcs_init is adding 1000BASE-X unconditionally, which wouldn't be appropriate here. > > > > > > Ok so, the missing bit seems to be that priv->integrated_pcs isn't taken > > > into account in stmmac_phylink_setup(). This needs to be added then :) > > > > > > Looks like there's also the inband support that needs addressing > > > On the qcom issue: the missing bit seems to be that > > stmmac_phylink_setup() only looks at priv->hw->xpcs and > > priv->hw->phylink_pcs, not priv->integrated_pcs. Extending the existing > > OR to cover the integrated PCS would let qcom-ethqos work without a > > new get_interfaces() callback. > Thanks all for the feedback! Including the integrated PCS in > stmmac_phylink_setup makes sense and I've now confirmed that this works > end-to-end on my QCA8081 board. > > I've prepared a v2 that replaces the get_interfaces change with two commits: > one to set STMMAC_FLAG_SERDES_SUPPORTS_2500M in qcom-ethqos, and one to > include the integrated PCS in config->supported_interfaces > > I reviewed the work that Russell was doing and I see the problem. Both the > integrated PCS and the ethqos code are configuring in-band negotiation. On > SGMII this occurs twice - both turn it on - and on 2500BASE-X the PCS > briefly turns it on before ethqos turns it off. On my board, it finishes in > the correct state. Right, I think that was the primary concern at the time. Ideally, ethqos shouldn't have to touch any PCS setting. > > I have tested cold boot connected at both 1 Gbps and 2.5 Gbps, and > transitions in both directions. However, this is a slow transition where I > am physically unplugging the cable. > > I attached kprobes to dwmac_integrated_pcs_config and > ethqos_fix_mac_speed_sgmii, which are the generic and Qualcomm functions > leading to ANE configuration. We see this on 1 -> 2.5 Gbps: > > 464.233469 integrated_pcs_config interface=2500BASE-X neg_mode=OUTBAND > 464.234778 fix_speed interface=2500BASE-X speed=2500 > > 2.5 Gbps -> 1 Gbps: > > 279.018122 integrated_pcs_config interface=SGMII neg_mode=OUTBAND > 279.019708 fix_speed interface=SGMII speed=1000 > > During the cable swaps, Linux briefly reasserted carrier at the previous > speed before the link went down again and came up at the new speed. The log > contained several PCS Link Down/Up and ANE-complete interrupts. I'm not > seeing any evidence of churn or link instability once connected. > > Russell's wider change is compelling but affects a much wider range of > hardware. I believe this targeted fix can work separately. > > I'll post the updated version shortly. Thanks for your time. > Sure, I will share some test results of my own (with v2) in a couple of days. Ayaan