From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D8993BCD27 for ; Fri, 18 Sep 2026 07:07:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789715277; cv=none; b=iOlG2rsa/P3649ZcAc2JBU4XbSh2h6Q5bp1015W5zY1QtbfEVGgLd5d7bSGZ/+cnPg7YTXGnm9gFg9SntbFfz+DcSLuKXjp+lafZBe3IytAPIlLGTYBXbhjOWx7c/hsSXxj0r07YrJKv0Wpj2GiztvDs5fUYP6nNteHauRuNl+k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789715277; c=relaxed/simple; bh=DhkCDXL1J9V6TBCIwgo21k3TW4GK7I7AbwxdOh7IJLE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PxBaobH4ru8AtZMe2muhqhab6UjvwGobIVB6+CUsPlU4Ac9rB5J2vBPDaRxlhkQb0dbo6FCyO6TZLyIt482i+DpoZuzGFHSzgL4YF1OQ69/ThGfjA5AWuQWhc4HOXlPNb14PiuyLdmYc70UWnEoQGothAUdHEoPftu+Yja16DpU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lM8iLofE; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YdVN719y; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lM8iLofE"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YdVN719y" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68I5xrMf204093 for ; Fri, 18 Sep 2026 07:07:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=AkytsX2493oZhSqMdRdXpM7s sRvUOFLQTqg/Kr4r0k4=; b=lM8iLofEdhDCimhKaod0wVawIEDPcSuiJsLG7h+j /PvYZxiS0UHvyRoxfBnCuzB0BTgGAHTkzTUbACWDuPzcdC8LpDXU/lJzLiugB2fe TuOGJ3KF5HHKSMpeDUQfVtftXat96Zdb7maX1YktqctjvZS9h3skeYOaItvz4EDY 5jIb879lAn26EsIzxt2Rwyn49YOA4ikuuEX8dWjeUq6uvCannUkdJBqhxsSm+gsb owv6b8OEZ4V04IaXUWuHhfTp+O8x5k5CTi0I/1psDZqH2/UePehYTwmwXGV5Rha3 OMNp0Tfg+CVnGPxYdqNjz5GQcfmBSpki7sNG7jfN6jtCTQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4grxp2rfkq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 18 Sep 2026 07:07:54 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-936e393061dso69006685a.2 for ; Fri, 18 Sep 2026 00:07:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789715274; x=1790320074; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=AkytsX2493oZhSqMdRdXpM7ssRvUOFLQTqg/Kr4r0k4=; b=YdVN719y4VPxfFEE0FK1/G+W9I7HF8QuZHxjMcQ7LTSHsSvdzoXvRsDN2CYpq3KBeu gLrRrJal6ULJDJNDqNeNZ9aPlCiuvb0oYL9fNT+qVqQwkicII+kNc3KA/Wq/fIX23uPu KAum4v9tqgInCC8JZFhQjD5xRzoCxzBCwV2i/W7D7vjHCKbBs8gBKS3KUgPRLSY0Z6P7 8ZdhTn4hwHZ2fJGnCMUwouvQKHoBPQ6AvOPcBjhjF/6b5e1MDxjAUKHv1kzYXP42e8Gr qz8IExXiccMFzNi4yPEH0Hn92gCeyUseHEtqsOpBNNUckmJdMWR6SDi3KdODKG7Kd5Tr IcWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789715274; x=1790320074; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=AkytsX2493oZhSqMdRdXpM7ssRvUOFLQTqg/Kr4r0k4=; b=V/KC1sWciGqAJY1XqXwduNb9OCAOMavwkjvKgmBQLwjTms67D47d+Qo0wDw29Oeg+Q NQADDBhu85vip8PEICfQhFahTDmx5t24QwE0GVRT6tUYictNivQBj60d1o+sU5kZ4O0O m8CayBroOS7kV/o6bgbx4F9QXJoH5rW4AVo4qUU28R7Ehz9JotUQZUkbj/wWcl5t7out aUE6AdlM4uwfPYbBVgKbyG/v10+mol79W01Wo0V/Pv55kNwggAcdC3Qx1c0K25DdkB91 zf8grSXx7hWCblSnPFzxE81lwykF76a0XhRnosJtYFZTiD7i3CInPpYArH4CB30CgQDB rNjQ== X-Gm-Message-State: AFuF++nOxpNJVLJ3Hfc2b+k/DrSJP6ZNg9F8RVUEWNzaAH6TAvvZ2Zkx XsXYHEinLm17LvdrBwrDc4DVD0b+AFA+N/A4WWztJFOi7T1HsEa+JtMPOIdNojyvH/CRzm7MP2n 066XISJQ0xTxlz+AC2Gt9GSwKc+0Z9fxCvW/fcWickE1MIjSadMY64UwXubk= X-Gm-Gg: AYBFou25SGsgjDpP5a7Zl0DsN5iKCDkO5gBUbhYOx+j2gKnkeVWCyHhj5qZq4F1RulP Oce1Va1YUNfDpkDfl07hUNFGNS0SiPyOYllKT0q+57XAiZTkV1HspBXW5+rNagmTq3G6Om0Ao5K 1FMIshJojWBW9DoRn0Xww34Xv0QQCDI1pBwoJ2u5sTf9JvGfMOIKppPopz9kIGvH+2RHNQalJMW SCg4DSJd9RoP0K6E1YOmiwiMgp4lcpJlLnWATD96UrD0B/0zu8k1Z9y7KjgqCvArfY5aM65202a 9r27HVkauMZiO7pr8lQupdpV2bVDUmSENse38vpzauWdKwYU6y80etBEdWRqIQkcGievbJ8HZB0 HSmUG5aS/reP4dBybpyQXhVIWJVlgzfLAXQ5xwg== X-Received: by 2002:a05:620a:6012:b0:915:a953:4b9c with SMTP id af79cd13be357-93bdc698a93mr190968385a.3.1789715274351; Fri, 18 Sep 2026 00:07:54 -0700 (PDT) X-Received: by 2002:a05:620a:6012:b0:915:a953:4b9c with SMTP id af79cd13be357-93bdc698a93mr190965285a.3.1789715273806; Fri, 18 Sep 2026 00:07:53 -0700 (PDT) Received: from localhost (77-32-99-124.dyn.eolo.it. [77.32.99.124]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fbd24034esm161065645e9.15.2026.09.18.00.07.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2026 00:07:52 -0700 (PDT) Date: Fri, 18 Sep 2026 09:07:50 +0200 From: Lorenzo Bianconi To: Thomas Karpiniec Cc: netdev@vger.kernel.org, Mohd Ayaan Anwar , Maxime Chevallier , Maxime Coquelin , Alexandre Torgue , Russell King , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Choong Yong Liang , Bartosz Golaszewski , Coia Prant , linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v2 1/3] net: stmmac: propagate platform mac_finish errors Message-ID: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="y1ppLvKxKDdIbxN5" Content-Disposition: inline In-Reply-To: X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE4MDA5NSBTYWx0ZWRfX+1oobt6nWBqg CeX2sEBHxksbsq9x0l3R3mudMGVvjdEQ+g5tGF/e145CCZzDFnRfDGrkOSfX/pCag5TZteYxXTq 4ITbw5KqSQ+6dMZlhnJudY/mg9wkAjo= X-Proofpoint-GUID: VLc6oMhWA8tvVtAodrQUmQzRTA3Vr-ZJ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE4MDA5NSBTYWx0ZWRfXwbsrtakBOn+z uXgOZp4uravgac0FgNUZ7Qi+a8XKgng2/+n/5Gz1pPONJniHTR47tieMm2AgfJ5muSusNy57AFv lK8ZWSqQsQAJAHYMu1qKTcvmmQ6EUrxVlPk0a5IqEpowqfuNmqaCQr0MyvZQVSn6uAIy6bRpsOv 1PPJJXvvnR9hDxS19/eBZi+yAxmLvQxqFjgHUU64Tm4YeUzAejjAivu6N2w90+1gNNUZf6ML/RX PxArfct1Iee9PyJbqAL0eX75eWFI5VCqUleF9KxUfJ6+HA5znBuKPHLsEZ/LjKPWp+S8pxJhm5s Zwczu1Cyj9Oi5o6swOaPt+imdj3SWo7tBE4MGovUzzCl39nj9tSAF0urQfeo4OAfya6CjzSjVfo 5XXxjrOVzSrSew+vdkmP8uGByIYmPbizqrYT3VsVh6fNBHsvl84FEacW9QHd53jPFnkwIwYm+Po APa2+YUrPaBjBv2niYw== X-Proofpoint-ORIG-GUID: VLc6oMhWA8tvVtAodrQUmQzRTA3Vr-ZJ X-Authority-Analysis: v=2.4 cv=cNF1IVeN c=1 sm=1 tr=0 ts=6aace34b cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=oN7owVyBLNHHe3W6XE6vpg==:17 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=P-IC7800AAAA:8 a=9dhsta6yqxhMeNE18noA:9 a=CjuIK1q_8ugA:10 a=l3wzEGKSjxwMGPmveUEA:9 a=bTQJ7kPSJx9SKPbeHEYW:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-18_02,2026-09-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 impostorscore=0 spamscore=0 phishscore=0 bulkscore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609180095 --y1ppLvKxKDdIbxN5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > From: Thomas Karpiniec >=20 > stmmac_mac_finish() discards the platform callback's return value and > always reports success to phylink. For example, the Qualcomm ETHQOS > callback can return an error from phy_set_mode_ext() if SerDes > configuration fails. Phylink then treats the interface as successfully > configured and can report carrier even though the SerDes is not ready. >=20 > Return the platform callback's result so that phylink can report the > failure and keep the link down until a subsequent configuration succeeds. > Keep returning zero when no platform callback is installed. >=20 > Fixes: e654cfc718d4 ("net: stmmac: configure SerDes on mac_finish") > Cc: stable@vger.kernel.org > Assisted-by: LLM sparse > Signed-off-by: Thomas Karpiniec > Acked-by: Mohd Ayaan Anwar > Reviewed-by: Maxime Chevallier Acked-by: Lorenzo Bianconi > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/= net/ethernet/stmicro/stmmac/stmmac_main.c > index 1fb5f804ea23..1350e92943ac 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -1048,8 +1048,8 @@ static int stmmac_mac_finish(struct phylink_config = *config, unsigned int mode, > struct stmmac_priv *priv =3D netdev_priv(ndev); > =20 > if (priv->plat->mac_finish) > - priv->plat->mac_finish(ndev, priv->plat->bsp_priv, mode, > - interface); > + return priv->plat->mac_finish(ndev, priv->plat->bsp_priv, mode, > + interface); > =20 > return 0; > } > --=20 > 2.54.0 (Apple Git-157) >=20 >=20 --y1ppLvKxKDdIbxN5 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCaqzjRQAKCRA6cBh0uS2t rAQQAP9pZYjJEEjVyy6ZeDwCbVXtT7BVVF5T0zNpP2F2lURjvAD/RWQFaNQLdsGC gsAp0m8owRMLJRx+SUPf+1FAkHDhMAo= =GAAQ -----END PGP SIGNATURE----- --y1ppLvKxKDdIbxN5--