From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pz2-f12.google.com (mail-pz2-f12.google.com [74.125.228.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95E5A518132 for ; Wed, 30 Sep 2026 17:09:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790788143; cv=none; b=FOSXosXpBqk2R+esjkWI67NZLJmvCMVfr0CPBGaTAlK1wz7NdsW3Q105/GViIfE9QNPS+RdgD/hhZgNI5n2CBL3YCAUsDEqBIDmUtF42o/TUveytT/V6GXugSJqhMxzYJJrlSMne+nn677QZqGSSGrqvzJXh/lMbwJe/ZwGFXMg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790788143; c=relaxed/simple; bh=ktfBIjCa0CIvknEpl0ZQy+RUTPio7skXi7Noh7PuGm0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qvlSno1NxjG27wo+UaerqvS2pmE+zkorL9klVuMxY3LWoAo/xPQYjyWgeSN3u3lCES/E7cI44RTXgN3c6uc6IY1MRfrwUSyviKrMYdtXHTKk/Bwzh5MDmyC5AsupavOhOAD4plrFtQqK1g23+c7eUQlJO1tIxxyDpq2a0o4PF4k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b=Ys77FQGQ; arc=none smtp.client-ip=74.125.228.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b="Ys77FQGQ" Received: by mail-pz2-f12.google.com with SMTP id d2e1a72fcca58-8693af0d7c4so3263034b3a.3 for ; Wed, 30 Sep 2026 10:09:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20251104.gappssmtp.com; s=20251104; t=1790788141; x=1791392941; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:mail-followup-to:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=t6oCiS1uRC3fuq7qwf3HrQZfaTBzywLk4ZFO46jPFa8=; b=Ys77FQGQ3zkjzjgLDJIQVf7ow6K4HY/PD29wz4z5n1NBOVMXKEDSkbEUKkZfrLabEd NsyXrmFlrWXxVkMdsHe3FGeTMigsde1zhO/k4F1YhUKrnivGOal8Gmw1pX5vsnzEh06e LMSCjY/Nmby7PDCdGqnu5UFYlckcbuZ6Pg9q5DIB7Wg6AGEnt9KRavrol1Au0h1HqTRF BXC9FXJFI1zf5eM46zEClJ5eYs53UhzTydATJ6lu6HQeoIO1iZ7XkA9H93NC9CoY+Vk4 TxU+11do906IXflCqyKglWAAbWVHoRgRcj8/ia+hIUYuNJFaf5ARhn0xOouWgzPjPpDE uXKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790788141; x=1791392941; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:mail-followup-to:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=t6oCiS1uRC3fuq7qwf3HrQZfaTBzywLk4ZFO46jPFa8=; b=VM11trTd4jDEpJifiwBPAGFbo2Ur9PhhfOHuvALiQcyAoaRz9t2ZGgfWhDqYW9aKnb BfM4GGmC/9yUbq9xbakAgf3pZg2tIGSHOnKkG5jpl4YSfchtHJIhSGsGUTbIdSkmby2V qxVrz8u0qMVJBd9eG5WBo7bhanWS2PTAR32JEVQ6CzcBerMAYw2FdoVaWWbv2FXaKo8H FItAIBamb+W1nezOYuTkNUAfyJMzQBuLvvefBJBuHEyyaM7W5lFwg3+9Bc94pYoAO7hg +swXUoHoyrQQ/SR9bBZGqWQKMyPl2HEH5tKVJBZ1T+rn7JV85mxjo/DRotoNeFjPyi06 e5yA== X-Forwarded-Encrypted: i=1; AKwUvBynxIIHk9rqwoY8Io/DOGR4Z/P7Ph4qA8LYfAbrTwqb+SMyol+KDangbRDsEjb4D8LtgBjelN4=@vger.kernel.org X-Gm-Message-State: AFuF++kBYitUdE4qdzWTXFld5byPB+Ioa8ynfzyH2lCV3Nb6Rn/z+PqD oYHTGHwD5qP71dCfCz0j9WVJteHdMZQMtclk9xABBVcfECCoTLu83B0IBKddBE7gsxU= X-Gm-Gg: AYBFou2Eh/4NpTnrAo5Cj77s69khy+HAM6I+vjBFG+RDUamao2vmcWdbfML7wbOumJx whCDrY3xTO/luwCv42JweotAMIzcXi9HA8AAfPuMHq2Pu/QtgofFBt1MprwtFBA070oANp4VNOf YZzkL7YUBBAWsptr3QkvIZYgyw9L7NxeO8qB7S10OEDBW8dbqdP0gUr5MGPzB9ms78KmIXODwpy rqDpy7qLF5DyhKI7I2XuSggMZcwlp15sWXYUwSv/3shXQwgB+60srLqtBNHJ+bfKQsjCd0iQFTX pzeFEX1MzP2DACtHwgMLZ94MVXtf0+35lrvjN4ArXkuEcItjUg9z9lbCioBUqMwpFz8FCM//RH9 OUTYL9pSi407vLpLaaltCQMK5BB6tDi04yhG16j4jgeo6Fm+qH7AabLQH7nfATl3X/N/WrsEfSE G3md3swQkX3MGvOR4FcFRnpNFVM7m+c12oRI5xjjdty2ZNzmgbN8479cf8W9LsGHq6uNPwXGAvp 1mjQsFR X-Received: by 2002:a05:6a00:1415:b0:880:849d:c07c with SMTP id d2e1a72fcca58-8874b065cfdmr1588192b3a.25.1790788140806; Wed, 30 Sep 2026 10:09:00 -0700 (PDT) Received: from localhost ([2a03:2880:2ff::]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-88725d63827sm1236665b3a.33.2026.09.30.10.08.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2026 10:09:00 -0700 (PDT) Date: Wed, 30 Sep 2026 10:08:59 -0700 From: Joe Damato To: =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= Cc: Alexander Duyck , Jakub Kicinski , kernel-team@meta.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Shuah Khan , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Daniel Borkmann , "Mike Marciniszyn (Meta)" , Mohsin Bashir , Stanislav Fomichev , Bobby Eshleman , Dimitri Daskalakis , Weiming Shi , Maxime Chevallier , Jacob Keller , Breno Leitao , Tao Cui , Pavel Begunkov , David Wei Subject: Re: [PATCH net-next v4 2/5] fbnic: Track BDQ device-page geometry per ring Message-ID: Mail-Followup-To: Joe Damato , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Alexander Duyck , Jakub Kicinski , kernel-team@meta.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Shuah Khan , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Daniel Borkmann , "Mike Marciniszyn (Meta)" , Mohsin Bashir , Stanislav Fomichev , Bobby Eshleman , Dimitri Daskalakis , Weiming Shi , Maxime Chevallier , Jacob Keller , Breno Leitao , Tao Cui , Pavel Begunkov , David Wei References: <20260925104417.2325213-1-bjorn@kernel.org> <20260925104417.2325213-3-bjorn@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260925104417.2325213-3-bjorn@kernel.org> On Fri, Sep 25, 2026 at 12:44:09PM +0200, Björn Töpel wrote: > fbnic derives the BDQ buffer layout from PAGE_SIZE. That decides at > build time how a posted page is split into 4 KiB device pages, and > uses the same completion decoding for HPQ and PPQ. That is wrong once > the queues use different posted-page sizes; completions must be > decoded with the geometry of the queue that produced them. > > Keep PAGE_SIZE as the posted-page size for both queues in this change, > so the descriptor format and runtime behavior stay unchanged. > > Signed-off-by: Björn Töpel > Reviewed-by: Breno Leitao > --- > drivers/net/ethernet/meta/fbnic/fbnic_csr.h | 34 ++------ > .../net/ethernet/meta/fbnic/fbnic_debugfs.c | 5 +- > drivers/net/ethernet/meta/fbnic/fbnic_txrx.c | 83 ++++++++++++------- > drivers/net/ethernet/meta/fbnic/fbnic_txrx.h | 6 ++ > 4 files changed, 72 insertions(+), 56 deletions(-) Reviewed-by: Joe Damato