From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8978485920 for ; Thu, 1 Oct 2026 07:49:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790840969; cv=none; b=E7BI9OHldpHECYE/YgTF1//Z+27WYwWZeevZIFM1b6UeA1yzTR0I/euaiUku+VamD3FvCZuknwiHYx42pg3L3IDr+SIud/tlq99rz9M/TWXVJsjPG/QVuyUQuwwKuUQXDSyi2PT0Qx82t/J4PwBavTpbJxf9Wp/f6oZ33DjJhWI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790840969; c=relaxed/simple; bh=7nC6VU1e+EkD71INuWX4LMYsCXiWV7QzlelrKPrgVfw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=u7ozCGf1KJI0/pzZ8oBzOJbypfxfIy6ksawg5WbJjrUpbjS6itCVajYFpp2OtjTXpdfi4HUq3d+2kMhuhgJkARVuRBsKvXaMWlb+8pnse1780RdUu0+r3JqktFlRST32JMKQuYsUWDNztbuCLCJ027Hf3IlBmMEdOQQ5h2NHsio= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=K5C3bsDl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ei6DQlog; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="K5C3bsDl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ei6DQlog" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6916xPr42887746 for ; Thu, 1 Oct 2026 07:49:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=fcJEazZnT8uURAanK1Vp1Zd7 zXkiTHBM91KnjXvtuLI=; b=K5C3bsDlHExr54kPSs+k42C1Le03azP4hHEclWjd oPVQ8l4jJl0G4i05tME0aYbORdAoY/Zdz3X7IFOJ3gkymDNrQcgkzGTVKhUPKGkQ RIzSjZrPQGcu7xwV42gRDcB2eltkNnnD6zCd6s8etYHjo+EV07hwVzaZqVRp5xY5 qKOmhaOT8zapXKDkYn4Or+VadKDFuqtebUsLwVqeKwgyplsi3AedJMToxoROlnHc DW9t9YdZTZlE22m6jiuNzjtZY+SeP6ctXmJppbhA/sZi3HnKFwkRbb06pWEHLGE1 ySBXtUaKRge/6R13V2oQgIIALQp27IZDO9AMPfJKN9V6cw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4h136tm09n-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 01 Oct 2026 07:49:27 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-93c5ab5c136so855446185a.3 for ; Thu, 01 Oct 2026 00:49:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790840966; x=1791445766; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=fcJEazZnT8uURAanK1Vp1Zd7zXkiTHBM91KnjXvtuLI=; b=Ei6DQlogX96CZXIbpjHYD6Dpfk9QDnHdDpRVnt6equrw5DZ2bNvek1YJNh+bLKVmUN /n3+HMevCZBg7x0VwT/jnCpRbjiVUZmYsBnwz/TrNZSvlApvuzv6PvDKSagpdIkCEcsi M/HU/4YcjR1Unvb2uPFquYIK561FEfB3+vRdD5XJ5cHc9JBZ/6yUURoHi902fySi1aZ4 a8AeOzFIAapTcFYBUwp1tn/om9bAfadvnh9Tp626DNBGsEh8YFawayUMkOeNuMnrhV88 SFFb1lUrrCMxAPC84TIBuDgUUYtMep4KsDOZhr4o69rNn7FT8+n4URf75hwlh/Wh+clI 5URg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790840966; x=1791445766; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=fcJEazZnT8uURAanK1Vp1Zd7zXkiTHBM91KnjXvtuLI=; b=OmempJbZHCxTyhy+4swykXbrxdhbptL7OsgKA1CQMQD1Qs292dpotfgrMq++NYqHkV kVXvSNXQHD/KWIwBvzEHZvwvN0cU+2Fe9inD9cb5jFeQTF+xh0AdBsStID1+a82rRlQf ynAvT7QdIOjauxkZZgqYHcIiZA7Dk5SdazjUq2x4TjNHFNRrfcMP83BuP2R7/Pm1mFIu BV8z2ZCXlNs88o41bwWwAYWKiMmhEql9Q/lXOL+68BoIuFBhzRSPCX3WAjt9q5PTCLOM UmFHp4H5j2fWK1JpON1W1iZ57vsSh0oTEsRHSrI+kyd4TFoC+xwfvCSGG3P5qD2O0geZ 1CjA== X-Gm-Message-State: AFuF++kxcq3n9+kABOc3jpd599te6e2yOlecQuZEnimFJPhfBXDPI8Vn ln7lTnxJwCvmLabIzecBZGu4fwocdvtVY+kZOxMHVNxh+8cDCqQrWhDu5aBL345mMGB1tRX1maO VhcJ9Bk7mVP+LqgDnslRhm3rP9eZPMxJ72k6za39tiOFPmFQ1Y8sr36JTD/w= X-Gm-Gg: AYBFou3xva+eidt/DHIPbGXHJbORt+sfeNq1YsFpPjrtY5K6lLMqQEUBEkAgUE27p9S uWeAGdxd6kfWHDn/Yq9f5PcyNVGaPDBIioQI97TWu9hPd5+MP/3jdH/p7k4wRlpFNfeIRHgP/Zx qG1+B4jpP0YI1yCj0mv8XU9wyqbD9MkdchhP4urDHJEZMUGIjvNM0cLmmtT8roCdoGrf4rbJ+LU HeihazY++i+iH7Cz+uzLZV0PQ+rBO5OoIwqI7rlH91z3TzPbgKEOzLU/NXD+R1JvWk+YTNu+aio 4cwEjEVGftdLWTfTtLsLBWVz/651GPpbmD9lffyfD7KCXBha/PlcRlVlQCN8YKhRCVD0cFME+28 Hdqb92MAQGyq2FA== X-Received: by 2002:a05:620a:6602:b0:939:ede4:a499 with SMTP id af79cd13be357-93ca94f6634mr719060485a.5.1790840962878; Thu, 01 Oct 2026 00:49:22 -0700 (PDT) X-Received: by 2002:a05:620a:6602:b0:939:ede4:a499 with SMTP id af79cd13be357-93ca94f6634mr719054085a.5.1790840962161; Thu, 01 Oct 2026 00:49:22 -0700 (PDT) Received: from localhost ([188.216.77.92]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48b068ff95esm4416843f8f.12.2026.10.01.00.49.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Oct 2026 00:49:20 -0700 (PDT) Date: Thu, 1 Oct 2026 09:49:20 +0200 From: Lorenzo Bianconi To: James Hilliard Cc: netdev@vger.kernel.org, Paolo Abeni , Jakub Kicinski , Andrew Lunn , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Jose Abreu , Russell King , Eric Dumazet , "David S. Miller" , Maxime Coquelin , Alexandre Torgue , Serge Semin , Simon Horman , Maxime Chevallier , Richard Cochran , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Rayagond Kokatanur Subject: Re: [PATCH net-next v4 0/4] net: stmmac: preserve and restore the installed EST schedule Message-ID: References: <20260930-stmmac-est-reapply-after-open-v4-0-9d4366587b73@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5O14Dw0334SoMGBW" Content-Disposition: inline In-Reply-To: <20260930-stmmac-est-reapply-after-open-v4-0-9d4366587b73@gmail.com> X-Proofpoint-Spam-Info: AW1haW4tMjYxMDAxMDAzMSBTYWx0ZWRfXyl0A421iAxNU m/5pjvzcu4XadeD1IuiPPM8G212X6NWHjBR4PRkE0iJEGXMaUPBh3FVurkAdNVhaAXoJuUgzlCh u2CgXT2nCiJG0/6DMmBiDbTaKTG/wCU= X-Authority-Analysis: v=2.4 cv=aPFlOr9m c=1 sm=1 tr=0 ts=6abe1087 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=WpTaRW6qxYHRGzLzQsVYzg==:17 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=NEAV23lmAAAA:8 a=pGLkceISAAAA:8 a=vIXCTXOdsuUdJ7saXm0A:9 a=CjuIK1q_8ugA:10 a=6N3VuSNxPG3FNRDMqtEA:9 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: 3xuaKZb8R7j74wrLxjWtqvw7G7tTesRW X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDAxMDAzMSBTYWx0ZWRfX1ykRdEPFwN0e TGumps/oC2y9raGKEgQkrcD+NGN+xcj++6CA2lPaL7DItIcBKf85sbPhdVMXFOey8kkjhgCKFWE VZemKt0yNzglpuaD/NvPhTf//k+T5/3QPYdaFSBOUQv1e5NgrVGRv4GuCfVVbFbDZ4e4N0BGN/F Ll9q09z0SnnfYxJotooCMDYO7DJjlv82oryDZJP16bFgRMGYABaaz3wsu1A/f0rlVgY54TQRnZ6 VwOioSTJk0SOaYDGsym+SCTI3byhYr4ixO16DuD7desBgwVkK5zcI8TYqXf5EaIsPaiYJIfZuq6 tOdKWOrKUj9nu8O0ZPFG1xP3nZkUWpO++qc7nEnT1ZJ2f7FtHsXd6ZgF+4TbXKFYh1ppX3+Sq0q YCl0Uiazvjs+pdY6Agpj6jq8t7sT3syawa5uZ2HOQMqhjWow5OdA5bFhTBTiKgOOI9W5fHp9flf iXir+NuPkb+W5FeeYRA== X-Proofpoint-GUID: 3xuaKZb8R7j74wrLxjWtqvw7G7tTesRW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-01_03,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 adultscore=0 phishscore=0 spamscore=0 malwarescore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2610010031 --5O14Dw0334SoMGBW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > Continue Lorenzo Bianconi's EST replay series with v4 of the unmerged wor= k: > https://lore.kernel.org/r/20260902-stmmac-est-reapply-after-open-v3-0-e72= a6df5a7ef@oss.qualcomm.com Hi James, My plan is to continue working on this series (the code is available in [0]= ), I am just waiting other patches to be merged upstream before reposting in o= rder to avoid any conflict. I guess it is correct to publicly ask before posting other people patches. Moreover, this is thecnically a fix so this seires should targed net tree. Regards, Lorenzo [0] https://github.com/LorenzoBianconi/net-next/tree/b4/stmmac-est-reapply-= after-open >=20 > The PTP initialization fix from that series is already in the base. > Carry the remaining embedded-state and explicit-enable preparations, > and restore the installed schedule after open and resume reset. >=20 > Build TAPRIO replacements separately so rejected updates cannot > corrupt the installed schedule. Rebase the previous schedule against > the current PHC when rolling back a failed hardware update, and keep > DMA stopped until replay succeeds. These changes do not depend on > the later datapath recovery series. >=20 > Changes in v4: > - Omit the merged PTP initialization patch and adapt the remaining > changes to probe-time PTP locking and current TAPRIO error handling. > - Separate schedule validation/rollback from open and resume replay. > - Reuse the base-time helper for replacement, PHC adjustment and > rollback; propagate errors while preserving the installed cache. > - Start DMA only after the installed schedule has been restored. > - Link to v3: https://lore.kernel.org/r/20260902-stmmac-est-reapply-after= -open-v3-0-e72a6df5a7ef@oss.qualcomm.com >=20 > Changes in v3: > - Guard priv->est.enable update using est_lock mutex. > - Embed stmmac_est in stmmac_priv struct. > - Rework locking in tc_taprio_configure(). > - Fix possible divided by zero crash in tc_taprio_configure(). > - Add missing reconfiguration during stmmac_resume(). > - Honor ptp error code in __stmmac_open() and stmmac_resume(). > - Link to v2: https://lore.kernel.org/r/20260829-stmmac-est-reapply-after= -open-v2-1-5e5ccb185e92@oss.qualcomm.com >=20 > Changes in v2: > - Rename stmmac_est_reconfigure() in stmmac_setup_est(). > - Rely on stmmac_setup_est() in tc_taprio_configure(). > - Link to v1: https://lore.kernel.org/r/20260825-stmmac-est-reapply-after= -open-v1-1-dfa80735e0a1@oss.qualcomm.com >=20 > Assisted-by: Codex:gpt-6-astra > Signed-off-by: James Hilliard >=20 > --- > James Hilliard (1): > net: stmmac: preserve the installed EST schedule on errors >=20 > Lorenzo Bianconi (3): > net: stmmac: embed struct stmmac_est in stmmac_priv struct > net: stmmac: pass the desired EST enable state to est_configure() > net: stmmac: restore EST before starting DMA on open and resume >=20 > drivers/net/ethernet/stmicro/stmmac/hwif.h | 2 +- > drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 +- > drivers/net/ethernet/stmicro/stmmac/stmmac_est.c | 47 ++++++- > drivers/net/ethernet/stmicro/stmmac/stmmac_est.h | 13 ++ > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 38 ++++-- > drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c | 59 ++++----- > drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c | 142 +++++++++++-----= ------ > 7 files changed, 176 insertions(+), 127 deletions(-) > --- > base-commit: 1631d79ae57dce2c5f88ad278307028638a8b4d9 > change-id: 20260824-stmmac-est-reapply-after-open-181d70a15eb6 >=20 > Best regards, > -- =20 > James Hilliard >=20 --5O14Dw0334SoMGBW Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCar4QgAAKCRA6cBh0uS2t rHudAQDRHrkhhNLiQEOGozztlHRmh86K2cUt6Z+4yLFiMw0PWwEA8XYf7p64JJYb H5S88bWzi8YBwiXw36fKmolphF5lWAk= =R8Ou -----END PGP SIGNATURE----- --5O14Dw0334SoMGBW--