Netdev List
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Subham Pal <subhampal789@gmail.com>
Cc: fw@strlen.de, phil@nwl.cc, kaber@trash.net, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	horms@kernel.org, netfilter-devel@vger.kernel.org,
	netdev@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net 0/2] netfilter: nf_conntrack_h323: fixes for NAT bypass and ASN.1 decode
Date: Thu, 1 Oct 2026 10:44:31 +0200	[thread overview]
Message-ID: <ar4db-oTyeSGTpCy@chamomile> (raw)
In-Reply-To: <CAHeizqF--yGMCLGBEv9f7Gs=dmbZO6+DwSh7KZjpDgbNonCotA@mail.gmail.com>

Hi,

On Wed, Sep 23, 2026 at 04:16:48PM +0530, Subham Pal wrote:
> On Wed, Sep 23, 2026 at 2:16 PM Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > I understand these are correctness fixes.
> > Do you have a reproducer/PoC? Do you tests for this?
> 
> Hi Pablo,
> 
> Both issues were found while testing a netfilter based linux
> firewall with communicating devices from multiple vendors
> (Panasonic, PeopleLink, YeaLink and Plycom).

We will need a reproducer here without requiring such hardware.

> 1. For patch 1 (NAT expectation bypass)
> - Environment & Setup
>   Linux firewall performing NAT between internal and external
>   network segment with Panasonic, PeopleLink, YeaLink
>   and Polycom endpoints.
> - Observation
>   Call setup failing due to missing conntrack expectation from
>   initial Q.931.
> 
> 2. For patch 2 (Failed ASN.1 parsing)
> - Environment & Setup
>   The same setup but this problem happened particularly with
>   Panasonic endpoint.
> - Observation
>   Panasonic endpoint advertises sequence extension with missing
>   optional fields during call setup. Due to misaligned check for presence
>   of field, I was getting H323_ERROR_BOUND error in dmesg.

  parent reply	other threads:[~2026-10-01  8:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-23  4:20 [PATCH net 0/2] netfilter: nf_conntrack_h323: fixes for NAT bypass and ASN.1 decode Subham Pal
2026-09-23  4:23 ` [PATCH net 1/2] netfilter: nf_conntrack_h323: do not bypass NAT helpers when tuple source matches reply destination Subham Pal
2026-09-23  4:25 ` [PATCH net 2/2] netfilter: nf_conntrack_h323: check extension bitmap before decoding components Subham Pal
2026-09-23  8:46 ` [PATCH net 0/2] netfilter: nf_conntrack_h323: fixes for NAT bypass and ASN.1 decode Pablo Neira Ayuso
2026-09-23 10:46   ` Subham Pal
2026-10-01  4:39     ` Subham Pal
2026-10-01  8:45       ` Pablo Neira Ayuso
2026-10-01  8:44     ` Pablo Neira Ayuso [this message]
2026-10-01 15:58       ` Pablo Neira Ayuso
2026-10-06  3:57         ` Subham Pal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ar4db-oTyeSGTpCy@chamomile \
    --to=pablo@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fw@strlen.de \
    --cc=horms@kernel.org \
    --cc=kaber@trash.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=phil@nwl.cc \
    --cc=stable@vger.kernel.org \
    --cc=subhampal789@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox