From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16F3335E955 for ; Wed, 23 Sep 2026 13:31:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790170295; cv=none; b=raySnd/bma+6wDCOejTLG7NWzx/Kwn7Z1eCZShUKYlvsxJzmFEl+aFJUgxQM/HYW1dwzZAazWXyrsnGktmYovSjUPu9QId+oaXfuZZE9BR4i9IeIjDjat3wlClULFMBS8iYq99wRW2A5XMJwoEUkjfBtTjjm2T9T1GqvccQGANI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790170295; c=relaxed/simple; bh=ASCO0Lh4SYfqFZo+QWVw9DfS6fnJxkZnm06PI6d+M88=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=f7GUJhsq8k7j8F6/3DXOSEfpVxhnEVkolwGtAhfnGQP9AfjSAAnHNI/4e6vDp/3pNwbQCE74GsD5KYm2pINYkMeSquw57c9lFYyCQOUP1patLQqBedahCY17dHQQnX93+vPE6xMxe7RqQzpsNMDspl8l/BSA2DpT6U17g6UweeY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Xe7bp9sb; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kYriovbz; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Xe7bp9sb"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kYriovbz" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68NBbdXF3414037 for ; Wed, 23 Sep 2026 13:31:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=Qq6xeq+5N6XfyP0fS9pBoOWP w0EfK2lsnoPvPTiFh/k=; b=Xe7bp9sbIhdsqaUU+Tp+K0Y+SLJ+Vscvz99AoTUM JXaeKQTGH7Y2onQk0FVAHZd7oIZxf+r9U/22PbkJ+HFqBn+hhnY6D4NRMDSsOJjw UmFVWC+Ft9yf4ZBtuGLaH99BwdE2GIv9MMgxol+PhoYAk3e+VJtlPpSgUuUMNbu9 bzJk2jbU5YYUQaFMoSPgyss/rCskrML562gC4vToTHNy/NJ3HS3zCN91njsZ5T50 x06PJt34V+fDI90RaNbbz4mU0QlIuCsdg4w8tl+VVR8a+gzI64QLHBcVbkyCqon0 V2D6Zd8YLVfX30mWUn5REjYQf4nFSXPfaOXmqy8XUhccdw== Received: from mail-yx1-f71.google.com (mail-yx1-f71.google.com [74.125.224.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gv78n26xw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 23 Sep 2026 13:31:31 +0000 (GMT) Received: by mail-yx1-f71.google.com with SMTP id 956f58d0204a3-66fae2bc827so1160801d50.3 for ; Wed, 23 Sep 2026 06:31:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790170291; x=1790775091; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Qq6xeq+5N6XfyP0fS9pBoOWPw0EfK2lsnoPvPTiFh/k=; b=kYriovbzX41ksgH3RiD8fBPLYA2dpM8rWtGplPzbDhBzYqkzpGkoo1c6ZdTLWVbyFv Wqxc7cZitQgASM8AwbDKfPWigqCPEKYCrgYjm1kX4BqkMBot8DIoHFbnI9SXqGKTVGh+ jcn0+qBVAgilNSXtvRM5u5BMDRxhXk2mnpsOMqt4+2ijU9ltnqWo1S38bDm+HMGbFhvw JZPcuS6Sm6VaRFhzMtC5Asy38OJxKls28DtDE67NHtzWZhnr8ONcYfe/uKa0qVKfQW/A IFQk4Wp8jH8XAZ+OQEvtoy4cbW27G0CMdrYnaMFey+rZTaUzE3mZni3vvzApxgA8UhV/ wJlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790170291; x=1790775091; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Qq6xeq+5N6XfyP0fS9pBoOWPw0EfK2lsnoPvPTiFh/k=; b=o5bpNa5WpwUrC6MCUOhaDdYiP+eqR8B4wuR84vvYXcifP9VCeaUKDa8Apr2/oPF5zq TGGla10aGdHpdR7Hh262/tJ6VsJGTtKHhx9+nJBJ4JmZhzn5sOwl+aPehJVitr0mLJDL z2hwQSMD4lYkpXaKlkKzC3ttGUcZPrHQCTV9oBYfMPIqICSIkpG9mE3mIg4sU+Omrr4y VeP0qEzsPf23VIT1BNIaakZjYxjMsaFBk2+Tk85cKcMCDnCToiOoryRieEDO+YXG34f9 jd1H7tjkj75LS3/iXBulqXXpksunpw5aUuo6LlDhfP3ZoICQkq26OC/kYyIc5Luvt1Xy 2Gpg== X-Gm-Message-State: AFuF++mQ/f9IZ4vKGasCTe8Y071xAayDW6CwIMq6Xb478keq0O79FQUj Sxoigrxi3CNcxW47cqCj4NbYytYvd1hPkzxxsaSP0uLuMfuOpen0HTVo8wPAbc4ghk3Vqr9UUAy mI4I2DhqlVeKfDRzC+kw7GadpFE0niA6rhkLnJZQ3kyd5hFB4mxWy5aQ7Hro= X-Gm-Gg: AYBFou0aDPafQjAMUtIb9dMG0SILLa8QhLJRwxKo3RK9qCu2BHAibEMoy3LyMwBVQ56 u3MAMLRlMzOniFnRhFvuQhWvSnhWluqZMk6xo0HG+AONl+61oDknPLjTEJ235L7qSifm87PaR19 ilvyMncz6tp8kNBxCj4QQoXgtvJulLqdkbu+I9W3CGnvlU6kC7c9ZXXFKTrJwTNw+ByQaxm5RR5 1tVwYnd3/6r5qNF2HZaBVaH9OjGjPqe0E5nwuNlYFIJWJGFp/g51OwfNVxnIZGyhFwCBbKojNwu P7rZMu/N0sA4WtC6tDfR2r94vA9ItU4GDPrPWPKwJDNZoqI+BOEyGCk2GK4LhSjVimI2ETZA06C b3Pwg2038GHim X-Received: by 2002:a05:690e:4503:20b0:672:a4a6:298c with SMTP id 956f58d0204a3-672d5728d7amr1011733d50.6.1790170291076; Wed, 23 Sep 2026 06:31:31 -0700 (PDT) X-Received: by 2002:a05:690e:4503:20b0:672:a4a6:298c with SMTP id 956f58d0204a3-672d5728d7amr1011687d50.6.1790170290514; Wed, 23 Sep 2026 06:31:30 -0700 (PDT) Received: from oss.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-9140c43b6dfsm20549436d6.31.2026.09.23.06.31.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Sep 2026 06:31:30 -0700 (PDT) Date: Wed, 23 Sep 2026 19:01:18 +0530 From: Mohd Ayaan Anwar To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Serge Semin , Andrew Lunn , Heiner Kallweit , Russell King , Richard Cochran , Bjorn Andersson , Konrad Dybcio , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Lorenzo Bianconi , Shawn Guo , Zhangfei Gao , Jitendra Vegiraju Subject: Re: [PATCH RFC net-next 2/9] net: pcs: xpcs: add USXGMII Clause 37 autoneg support Message-ID: References: <20260923-qcom_xpcs_nord_emac-v1-0-4b1c682af70f@oss.qualcomm.com> <20260923-qcom_xpcs_nord_emac-v1-2-4b1c682af70f@oss.qualcomm.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260923-qcom_xpcs_nord_emac-v1-2-4b1c682af70f@oss.qualcomm.com> X-Proofpoint-Spam-Info: AW1haW4tMjYwOTIzMDA1MyBTYWx0ZWRfX0XHLuFM6Kc4a vILt9+MhlKQNc1g71g/4xdqK5VLgfp6n3UH1AuAtpmW/3qLDzEhI5X9wv1A/BbQSseGrdcvD/h3 eVFl0NmWaYwS84Jk5/om7JcTxBDPJeU= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTIzMDA1MyBTYWx0ZWRfX5SjtnLzUKjmL sOHmELtZNzcZZTNMXMhjfJSKLyYx99sW2vLrmSP8NEcPaJW1oRMb/pus3GzOL5W5oktzBYfw5LX PynCkhDVR8zgKnxtEPPgACVVfjMyYIbWhyg+fhFL1RmFhKwt6YzXs3yiTaJr5fS1qhCS/K/cB2k 7GBpwGxzaBajjJtZ5+lcPNZOVE8cTK7/dUetVGYt5NsVTcTnpydF7kilwI0+HI5l/f7exUYHC4u apPv9sKC3YGomVrShrL6oE+iYN0+Ys7eoibqqFeccwM19v2Ja+/yf1tc785R6I58PQn2x4JYAGE 35qw4BPbI5QkwdeGwwGVBWWgRBIuMccsLx3r7msbnsOmnclNYaqZrl9iOMX6uYOpeJfcOUF8MtQ cL04wfGXn72vStg7S0luueP6Ffy1Orz1RXJqjL7Fop9HlSAllEaWMvDggdYmcz+g/nJelO/np+U BHgmASA/31M8ChKQtVA== X-Proofpoint-ORIG-GUID: e6bz9CuDkHWUKioeLaDhuC3cePOtyBz6 X-Authority-Analysis: v=2.4 cv=aNFlOr9m c=1 sm=1 tr=0 ts=6ab3d4b3 cx=c_pps a=ngMg22mHWrP7m7pwYf9JkA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=kj9zAlcOel0A:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=U1nmBBJXYHZWlwlGUpAA:9 a=CjuIK1q_8ugA:10 a=yHXA93iunegOHmWoMUFd:22 X-Proofpoint-GUID: e6bz9CuDkHWUKioeLaDhuC3cePOtyBz6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-23_04,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 adultscore=0 phishscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609230053 Hi Andrew, On Wed, Sep 23, 2026 at 06:37:28AM +0530, Mohd Ayaan Anwar wrote: > The generic DesignWare XPCS support currently associates USXGMII with > Clause 73 auto-negotiation. The XPCS integration on Qualcomm Nord > instead uses the vendor MII register block and Clause 37 control and > status for USXGMII. > > Add a separate Clause 37 USXGMII mode which configures the PCS for > BASE-R, enables single-port 10G-SXGMII operation and enables > PHY-side Clause 37 auto-negotiation. > > Also decode the negotiated link, speed and duplex from the vendor > Clause 37 status register. This supports 10 Mbps through 10 Gbps link > rates exposed by the USXGMII status fields. > > Signed-off-by: Mohd Ayaan Anwar > --- Seeing your question below, I think I should have probably mentioned here that this sequence is given in the programming guidelines of the XPCS 3.50a databook. Section 7.6 Switching to USXGMII Mode, point 10. states: Set bit(12) of SR_MII_CTRL to 1 to enable CL37 auto-negotiation (paraphrased). So this is a part of the licensed IP, rather than a Qualcomm specific addition. > @@ -687,6 +736,7 @@ static unsigned int xpcs_inband_caps(struct phylink_pcs *pcs, > > case DW_10GBASER: > case DW_2500BASEX: > + case DW_AN_C37_USXGMII: > return LINK_INBAND_DISABLE; > This is incorrect and I did not find out its side effect as I was working with a firmware managed external sitch. The XPCS supports USXGMII with AN always, so this case should return LINK_INBAND_ENABLE. Ayaan