From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBB95485CEF for ; Fri, 25 Sep 2026 11:03:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790334215; cv=none; b=DOLmZKLnOv5f/cvCCS92pcsqO7zbCxNo2isQ7bJeukOnpdQDMau/3OPmhqRDNoyqFHZGuttBQKTaDIsBu/10u8plqV91IhkjBVEKnhr9vEbqlSD39C+P+mFRb1k1/lMLssP6Jwlh77o3Ek+eywqmg+nbZ0TN9d/XuHJO5DzQMA0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790334215; c=relaxed/simple; bh=NrOkTLU9aNS6hrvJ6qdUXdLjRzSoJw9qNpjM9yVrK6U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DZ48ahPuHjhQthjZ5uwmMYb1n+hax53DM/Wi3iKLtDOHyArNYe0GKCZAbwPOEvuqx4r1jgg0mjSzstY+xlk3C+I+B5EpwQCU05Lr4432jg9Kj+3clUwxHXNF82fWCvUhSaOIWaFigAe3QyM9veHxqELPqrp9GRd+kD9yZT/JgF0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=h8SJlM1o; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PUdm+8VF; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="h8SJlM1o"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PUdm+8VF" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68P5J2hb756679 for ; Fri, 25 Sep 2026 11:03:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=KL5UvpKHjzpyxWhNGv3591jL faKqMWyF0eLovdVJgck=; b=h8SJlM1opHmnGymsHaTRDEHKvmL9+e3QVetJkJ3i 9jw5a5FJ7Cp+O1glWFBGzl29UZqmQgNSsq4/6Gs57GWgTNG1ASnk7HELCgciBBMT uSTYoU84eVK+CqNWekYhkLrtbYQFgMOwlcl17YOQrhuAluPwBX3uewKW71EvEa5/ XWhcK2PHbFjl9RordTtUjXuo0VWyXGRs0L4QJMw2kPLhGRjzLaOq5DQsqxUuMOkD j9K0nwJgJM64bMSregfTs3zKL0+KCiC1KwqxBYkxI9Xa8fwKTlYphmQ+AG2syVCK pP2PhKHZfMYG50MdN1LuZ7oECpjVGaXkj4srjuV9Ej631A== Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gwjq091js-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 25 Sep 2026 11:03:32 +0000 (GMT) Received: by mail-vs1-f70.google.com with SMTP id ada2fe7eead31-7961a79fcd8so195449137.3 for ; Fri, 25 Sep 2026 04:03:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790334211; x=1790939011; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=KL5UvpKHjzpyxWhNGv3591jLfaKqMWyF0eLovdVJgck=; b=PUdm+8VFwhf5CvYKq7KppljkUrYN/kohJ6Kb4w2nKl8d3KXqRUVe5bMvjblt67dLQ7 7IB9SC7YtwMd/302fvBXBy9Det2Jk+D1wtwaNFHMPe8393iqBQcfHoRIVULusuia8PTE OtQLQsHZAuewngu0FAxulq/AqFVA1u/cEQ5BOZJnj4PbkXj0I70H6NBd2ddt8tG8h2S5 ZeRfRRnYM0akdYKRNVGYjw7Ewvo3GIfPoDB0xy/mBcKKCREtRYx6OPebnGpcB3dw39Y2 VI28k2lHQtVpbic0M4E61NwoKB+djnsPL+j7rdUOzqgyUqscDhqo7EYcie9nNdJ0oabH IePQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790334211; x=1790939011; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=KL5UvpKHjzpyxWhNGv3591jLfaKqMWyF0eLovdVJgck=; b=bEmUHTGm7+n7mrcqJ7S9vitCQCVeNv9+KQubJezvzHp9qhoxa2K9gkMJvvK1J4j7gL Wpk/lGr+ep80YBJ22rloF1JJOdXlX5mEb8HVE2hLcDsDjeZH+1/wjk9xqxbe0Mh6vFUt sv3nOYVtSv/Jtk9mwnBhLVs3FqBtOKp3Ow8h7kXb5Uu+SkImnNOSrCYP4wcPNyxXSQEc nzKPSPx5AyMfO/8pWtF5xG126xPQmeHDYdvB67EguHdMaVTi5gip8NmwE9Pl8jw3Kc0X R9i+QFY2VyMGJOOqmmhF4bg54lourUMDTanN7v/edxmdINdzG9gi6r/kkxTmRWqgJSWg cQAA== X-Forwarded-Encrypted: i=1; AKwUvBxK578H/4RuX0eQhlDA8NuQao/3v0XvqGhI6118SR+f8BoY3RF/Y6dnXFJaqb/clGRE5xtVUVY=@vger.kernel.org X-Gm-Message-State: AFuF++n+A06ddakr9LRjF4AlJC9L/FMPGIgzvMIvTDPhH7fEdOf1G6HU VCJKQr/n95YIilzJavmO+ylC7m9SbVi8kwVO4UQYKpbxpeW1G9IzN4QiJjVXXuZMp/jcuEDfyqC lZKe8HelrjuWtq2m7bq6Y7gn69oVGNdjtIl/yxQClZHkE5ryrAouwr4QRnSE= X-Gm-Gg: AYBFou3kxG8nxbO3qjm2i9VjkoMjTbRcE2UaRZxc+StluNdXWBvIKK/d+AvaYeIvpAT ZwBOtZr2HVRi/t/KKMr7zFJ1cyfOXSBmlHnJzFfZHKTc7ABrdxtsvUDHJsNB6IluMahN3UvJYaB Q5A9g42oCjTLE/5lbqraq//IamI7BbWwhqnjPpNgRE06IGYwsB2g+ai4/xV/A7ED5ouWHkMGK8r YcvrJ8xA4SQf9tAtUh3BKC3sZaNawvdMB88JC5BN0cNVVS7DJN6yBFbcXNs9A2GhI8RE5TGTD1W xXoAltzkWL9IEOAMVSy15JBzObGBKdvn8KG5nwtXoY4VG8X6sfI/kX56NAgJAE15cen3RsQWDgB isfU0Q1F1MVZLSw== X-Received: by 2002:a05:6102:160c:b0:7a2:4b76:55fe with SMTP id ada2fe7eead31-7af1eaeade3mr2080972137.21.1790334211311; Fri, 25 Sep 2026 04:03:31 -0700 (PDT) X-Received: by 2002:a05:6102:160c:b0:7a2:4b76:55fe with SMTP id ada2fe7eead31-7af1eaeade3mr2080917137.21.1790334209864; Fri, 25 Sep 2026 04:03:29 -0700 (PDT) Received: from localhost ([188.216.77.92]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49ff04440e2sm48935915e9.0.2026.09.25.04.03.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Sep 2026 04:03:28 -0700 (PDT) Date: Fri, 25 Sep 2026 13:03:28 +0200 From: Lorenzo Bianconi To: Mohd Ayaan Anwar Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Serge Semin , Andrew Lunn , Heiner Kallweit , Russell King , Richard Cochran , Bjorn Andersson , Konrad Dybcio , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Shawn Guo , Zhangfei Gao , Jitendra Vegiraju Subject: Re: [PATCH RFC net-next 5/9] net: pcs: xpcs: initialize runtime PM as suspended Message-ID: References: <20260923-qcom_xpcs_nord_emac-v1-0-4b1c682af70f@oss.qualcomm.com> <20260923-qcom_xpcs_nord_emac-v1-5-4b1c682af70f@oss.qualcomm.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lVoFIgUXX7x55kE9" Content-Disposition: inline In-Reply-To: <20260923-qcom_xpcs_nord_emac-v1-5-4b1c682af70f@oss.qualcomm.com> X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI1MDA0MyBTYWx0ZWRfXyElD50inDimy vA7plh81aFpgMAHJmB721bYDhx4wk2a2cxGFgTM8ZEwBEIzMuu2fkxpt8EorUIJRmmkaofvtpqE IL3hE4WPt390MO/czLrQVM3YUZyfG5w= X-Proofpoint-GUID: GjilYHNGrJO7tHKSF-jV6hQMcQkJNpD_ X-Proofpoint-ORIG-GUID: GjilYHNGrJO7tHKSF-jV6hQMcQkJNpD_ X-Authority-Analysis: v=2.4 cv=LNPz05W9 c=1 sm=1 tr=0 ts=6ab65504 cx=c_pps a=N1BjEkVkxJi3uNfLdpvX3g==:117 a=WpTaRW6qxYHRGzLzQsVYzg==:17 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=05hQUwIZQIh6G6I0U8UA:9 a=CjuIK1q_8ugA:10 a=QVkzxUxUNwT0qHlZT5MA:9 a=crWF4MFLhNY0qMRaF8an:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI1MDA0MyBTYWx0ZWRfX0Fh2XLwrLXN3 Q/l1NEkgbCwjHO6DwSKkZyW7SQVaGlJ9fohzexJmvBkrv+LWDTQurTuyOvPHdB4QlzQSo88goG+ kyJniPm8UUHxKzkUzjDeHpv0Xt002hGeyscwIemayp5pocuBBlU4+uiODa4PSYb/pGjIvD4qOZ+ 0azTOVU5nM+7bptOx4zgLvdq23YHIVOXlWM6TjGtqmJpAxXxAvpUOs/+Rk9DaxtRNUb2/jmVciU m1seaQ3yU73Nm8TDajvP7ggUvJDfQOBQuHNyDdXznTgvym9ud4MfPcx03pnN8SbFH4rA0PRL5/6 varAkd8GxpwVTBCbCVM36zzrphOiCBawH4cnS6qqnhZlWkjpmJdVvWR4m+GwB1wDpjVA2H9QZzM F8dlT3M4b8RqUtEYHPu5Z43EPYJ0vKXfoobpyhVqE1N1ag8yodRunVY27x/L+Ccda83q8wsPLPv fMqYpU3v2A09z520CqQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-25_02,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 suspectscore=0 impostorscore=0 malwarescore=0 adultscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609250043 --lVoFIgUXX7x55kE9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > xpcs_plat_init_clk() acquires the optional CSR clock but does not > prepare or enable it. Marking the device runtime-active at that point > makes the PM core assume that the hardware is already powered. >=20 > On Nord, once the XPCS CSR clock was described, the first > pm_runtime_resume_and_get() accessed XPCS registers without invoking > runtime_resume() to enable the clock. The matching runtime put then > invoked runtime_suspend() and attempted to disable a clock which was > never enabled, producing an already-disabled clock warning. >=20 > Initialize the runtime-PM state as suspended instead. The first > register access now runs the resume callback and enables the CSR clock, > while the subsequent suspend callback performs the matching disable. > Check and propagate the state-transition error as part of probe. >=20 > Signed-off-by: Mohd Ayaan Anwar This patch seems a fix to me even for other SoCs. The pcs device is marked as 'PM active' in xpcs_plat_init_clk() but the CSR clock is not actually enabled. Moreover, the CSR clock will not be enabled even in the pm ops since xpcs_plat_pm_runtime_resume() will not be executed (the device is already as PM active). Am I missing something? Regards, Lorenzo > --- > drivers/net/pcs/pcs-xpcs-plat.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/pcs/pcs-xpcs-plat.c b/drivers/net/pcs/pcs-xpcs-p= lat.c > index e013a5253a22651220e62352d03faabc3a3c3658..328c50940d46eb8e7bea06ecd= 1a20214e3cde61c 100644 > --- a/drivers/net/pcs/pcs-xpcs-plat.c > +++ b/drivers/net/pcs/pcs-xpcs-plat.c > @@ -322,7 +322,11 @@ static int xpcs_plat_init_clk(struct dw_xpcs_plat *p= xpcs) > return dev_err_probe(dev, PTR_ERR(pxpcs->cclk), > "Failed to get CSR clock\n"); > =20 > - pm_runtime_set_active(dev); > + ret =3D pm_runtime_set_suspended(dev); > + if (ret) > + return dev_err_probe(dev, ret, > + "Failed to set runtime-PM suspended state\n"); > + > ret =3D devm_pm_runtime_enable(dev); > if (ret) { > dev_err(dev, "Failed to enable runtime-PM\n"); >=20 > --=20 > 2.34.1 >=20 --lVoFIgUXX7x55kE9 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCarZVAAAKCRA6cBh0uS2t rLCrAQCobR+wMwviJitki0D8UXg+bk1Lsss+ylzGxdzBJPlCvwEA06MlQVLUPViq 8IliKoIeVuqVM6Tj5hwuPKqdwtvAwws= =qJHD -----END PGP SIGNATURE----- --lVoFIgUXX7x55kE9--