From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f13.google.com (mail-wm2-f13.google.com [74.125.225.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA8643C108E for ; Sun, 27 Sep 2026 08:14:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790496872; cv=none; b=FONvc9/Q4iEHI9IfVXF8zr0V+VrcPP09ToEidQZUgDiX716NEGZLmQnr4Yvg7P0LwXSSfP03KmEvwZeksLFpc/Q5gBA8VONVMkKB5+X6KxMzKbO9dMIiQBxKSowU4raOnT4lOZsscmuYNiNT16zcuq29112e7zadL+nsnDg6d9Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790496872; c=relaxed/simple; bh=dAWVxC/OYmorFhr2s/I59x2nCgD2yGNjyjqnWaTeP4Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Be0F6zggqguaxVBngRGTbBYB9as4r4IcP2lwDUfxxtMi3BbHufhc2EDVOUzSG99iXf4Ce/4ACvBZYyGHYe134ATrEVwLc9ahGOwGO0f9IDLVQO1RnCPW4FrnXigaRaavgNK3AAfFT/7VtbC3+Gp/mDXVEQDt5fRbUX9uxiHI1pI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PZH82y6D; arc=none smtp.client-ip=74.125.225.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PZH82y6D" Received: by mail-wm2-f13.google.com with SMTP id 5b1f17b1804b1-49e721b5503so20170105e9.0 for ; Sun, 27 Sep 2026 01:14:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790496869; x=1791101669; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=WQUgiPs4tmKVhr6VI6GahJDVSjaQB4aL5i8OrCuC+Dk=; b=PZH82y6DvgkSX4ofsOuPCPF+u1XuAr+zmB9Skm9LYuKDldlbsjFcKhI81M5+f6k0oD JgarPO1LTxkFjot08UlAG/AvfBZcndOma3KbFhgbkg59MSoX70EqV63f8zSxZw4aDgVB uCJTIk7npqTxWgj9QEkSkVZQHBgrESNoikM0jXSfFbwQTvhFvw3C7Vg9nIp8vKZPnHOq DMuBMUbzeXMJIDv370oz9wh91Pazh/PuungkRdkBNpfe+/fYIjeWPBRLeZnxHA2HM6a/ doIo2b3h+u36t/akwCUhubQ7JAA5SZc3fHPAb9mJaxShY3a5tjczyCKmuDNEUstvFofO vdnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790496869; x=1791101669; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WQUgiPs4tmKVhr6VI6GahJDVSjaQB4aL5i8OrCuC+Dk=; b=yYA0RoynumXksxCDepNu9G2sdwDMW0deeyKYk/29VxnHYR9+1fysLzYK3OSDMatlzj MtQIkvypNp5ilkiVxym5k/nvZqUduLBIXceHtk13OK5ZZ2k1NSbeFDetBsTjieLTeMy1 BxgXjbLVjyQv8R8YGmeqkPrFJNEsi7F5tbbEyE3EXTLzs4B459A2PnrexliqTaR5ul8I iJi6J0ML9JQbJQt3+lpWs21h25m+E/+AccJp390wsCtJwI0rDi/OL1m5m4c4t7TPpzky NJvXrvpWYZ91kmmWTIaLZrfETy0EL5oxpdM+LMgd1os89+79+0RJoIXITUi0MzW5hJ/r oD7g== X-Forwarded-Encrypted: i=1; AKwUvByae45aDW+29Oi3pIJ2wM7+LvgYe9mLuy1OMGzQ+Bajtl9lqC5uVonrM+BxEie2IqNyX1I7PuE=@vger.kernel.org X-Gm-Message-State: AFuF++kncqLUXV3jKPALigtpQH2oqbI+wsv+F17laIxyJ2ph5ecVK5pZ 9ENT8GnOq2I6z+dJusHuTmqE38dQORnbARJQzxy9Dv48ALz2a8MjhW4+ X-Gm-Gg: AYBFou1HGsrmed5/QPzU614siu9OleehsE56bDE8Zq9UZkMEdMtbWy0z1CQrPX/oPCz UMwdoRzpJqMuJGyVYdEV+DKyOF6IDa49u5KbTge/VyNu/+zedTUzIj+6tV7bStddWJ/npb9of8Z yEx2xOxHR6Y09QVtyhu4ytkUQ65skUP7GlD2QPfzUmboDlw7qyXIieDBIMvfY7wie1RWrixSAZV 8OHvAqYyJF5NGyxJJQJ1evZsV/GdMr526ht1kMe1D0+CbkzlPypAKBNGglc1+uegdXAeneP+6TI RvHedgXN4nd71c+M/yWPEqmXOOfarmT64/9DJFvQzclzA+ui5a3y8KlH3el+WKkT04VIPQNkZcv F7MkyAjsxTR6UtEnSgTkDY+lleBHq/ho/cNN8iQZLEWuHkFsGUBo4ToFhQJ/0getlLlkdSUtGDJ KyUjKJbM+l2uypJUSc3DGf+rklueH1iPvxfk/aKthQqg6kXJ7R7USK5IYlP74X X-Received: by 2002:a05:600c:3486:b0:49f:f9d4:674d with SMTP id 5b1f17b1804b1-49ff9d4695dmr52148935e9.13.1790496868724; Sun, 27 Sep 2026 01:14:28 -0700 (PDT) Received: from gmail.com ([83.231.69.9]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a00178bebasm42909255e9.11.2026.09.27.01.14.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Sep 2026 01:14:28 -0700 (PDT) Date: Sun, 27 Sep 2026 10:14:26 +0200 From: "Jose A. Perez de Azpillaga" To: syzbot Cc: davem@davemloft.net, dhowells@redhat.com, edumazet@google.com, horms@kernel.org, kuba@kernel.org, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, marc.dionne@auristor.com, netdev@vger.kernel.org, pabeni@redhat.com, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [net?] [afs?] kernel BUG in rxrpc_destroy_all_connections (2) Message-ID: References: <6a73d174.5aeeccc9.207e63.000c.GAE@google.com> <6ab29768.514bccd6.255447.001e.GAE@google.com> <6ab8c8cb.e548f532.1ca396.0037.GAE@google.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6ab8c8cb.e548f532.1ca396.0037.GAE@google.com> I just don't understand why it is failing... :( #syz test: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git a7bfaba4823e diff --git a/net/rxrpc/conn_event.c b/net/rxrpc/conn_event.c index 611c790bc6d0..111f0844b0d6 100644 --- a/net/rxrpc/conn_event.c +++ b/net/rxrpc/conn_event.c @@ -273,6 +273,17 @@ static int rxrpc_process_event(struct rxrpc_connection *conn, int ret; - if (conn->state == RXRPC_CONN_ABORTED) + if (conn->state == RXRPC_CONN_ABORTED) { + /* A CHALLENGE packet queued for processing carries a ref on the + * connection (see rxrpc_post_challenge()). That ref has to be + * dropped here because the caller frees the skb as soon as we + * return. + */ + if (sp->hdr.type == RXRPC_PACKET_TYPE_CHALLENGE && + sp->chall.conn) { + rxrpc_put_connection(conn, rxrpc_conn_put_challenge_input); + sp->chall.conn = NULL; + } return -ECONNABORTED; + } _enter("{%d},{%u,%%%u},", conn->debug_id, sp->hdr.type, sp->hdr.serial);