From: Ratheesh Kannoth <rkannoth@marvell.com>
To: "Jari Seppälä" <jase@nocloud.org>
Cc: <netdev@vger.kernel.org>, <kuba@kernel.org>,
<sgoutham@marvell.com>, <gakula@marvell.com>,
<sbhatta@marvell.com>, <bbhushan2@marvell.com>,
<linux-yocto@lists.yoctoproject.org>
Subject: Re: [PATCH net RESEND] octeontx2-pf: Fix RSS indirection table size
Date: Tue, 29 Sep 2026 08:06:29 +0530 [thread overview]
Message-ID: <arskLfzeW9LNrQuR@rkannoth-OptiPlex-7090> (raw)
In-Reply-To: <20260928084711.2462571-1-jase@nocloud.org>
On 2026-09-28 at 14:17:11, Jari Seppälä (jase@nocloud.org) wrote:
> The conversion to the dedicated RSS context operations replaced the
> pointer to struct otx2_rss_ctx with an inline u32 ind_tbl[] array.
> However, otx2_rss_init() still uses sizeof(*rss->ind_tbl) to set rss_size.
> This now yields the size of one u32 (4), rather than the 256 entries in
> the indirection table.
>
> The RSS initialization and hardware programming loops use rss_size,
> so only four entries are initialized and programmed despite the NIX LF
> being allocated a 256-entry table. On an OCTEON CN102 with eight RX
> queues, the table contained 0, 1, 2, 3 followed by zeros. Traffic was
> concentrated on queue 0 and ethtool -X equal 8 did not correct the table.
>
> Use ARRAY_SIZE() to count the indirection table entries. On the same
> hardware, this restores the full table repeating queue numbers 0 through
> 7, and bidirectional multi-flow traffic increments multiple RX queues.
>
> Fixes: 62e01d8c4170 ("eth: otx2: migrate to the *_rxfh_context ops")
> Cc: stable@vger.kernel.org
> Closes: https://lore.kernel.org/netdev/361df563-e29e-43bf-8806-24bdfefed33d@nocloud.org/
> Signed-off-by: Jari Seppälä <jase@nocloud.org>
Thanks.
Reviewed-by: Ratheesh Kannoth <rkannoth@marvell.com>
next prev parent reply other threads:[~2026-09-29 2:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-26 9:14 [PATCH net] octeontx2-pf: Fix RSS indirection table size Jari Seppälä
2026-09-27 22:48 ` Jakub Kicinski
2026-09-28 8:47 ` [PATCH net RESEND] " Jari Seppälä
2026-09-29 2:36 ` Ratheesh Kannoth [this message]
2026-10-01 0:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arskLfzeW9LNrQuR@rkannoth-OptiPlex-7090 \
--to=rkannoth@marvell.com \
--cc=bbhushan2@marvell.com \
--cc=gakula@marvell.com \
--cc=jase@nocloud.org \
--cc=kuba@kernel.org \
--cc=linux-yocto@lists.yoctoproject.org \
--cc=netdev@vger.kernel.org \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox