From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr2-f34.google.com (mail-wr2-f34.google.com [74.125.225.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96632380FD3 for ; Tue, 29 Sep 2026 05:34:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.98 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790660053; cv=none; b=sJFUdbZKRiJGkDfv4e/EC8YpXz27wxB7b/8DwT7mj8CTnY9rUkp1/AGMe2j51gPWsn/yOi04zCDqgB++F4gGI4qR0oHjmXb5gJ2RiPa6BWWVDKzM7f3yv7PraEMYOAkpG0cgY0Fl2ohKrcph84W8STwduqH9GARD6Yy3+uqvOYA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790660053; c=relaxed/simple; bh=m2lqawFRROq7VOxJCYnJVdA4aB6TI0mUCVIlIeUuTzI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=A+jfzQkRlF4J7BG+sop6pLWPKIVUBsrppswUyv/TVaRpwvaI6yZrFFYduKwyDj0sQcO8PqZHOZX7CBEYruipufNCQobfKi4PJP8nUILv2Fn6euh9kP2zpCRZ9Ng1Ub2TtPPvZPSU62JrR7GIVy88f+7AswDtgUcWaN8364aN8Pg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g+zLSDTB; arc=none smtp.client-ip=74.125.225.98 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g+zLSDTB" Received: by mail-wr2-f34.google.com with SMTP id ffacd0b85a97d-48884b926f0so2441092f8f.3 for ; Mon, 28 Sep 2026 22:34:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790660050; x=1791264850; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=vDrRpA1W/7JjCEY/lfrVQceoo3M5nHbNKEhFmkg5umg=; b=g+zLSDTBN5PBcQHF5j5AAGj8sobOayPMm/lPnpU7fFtjmd3yNMI9nSQHvybIYKg/n+ GnGtfnaSbNuUbTmkxDnLFRqu09paoQmpeHA9gNMpY/dnIiFV2aTWuyoV1ec/eekRx1+w +cFWuPIJoHLHgXUoyu2mRuVcCvIFCsfVnszBEcOfx33IZmpH8ZPyNBUgz3kKmqunn1Tg uKWjYgPIBuXLK+Cs/AqKE+2lqdLlelH0tOcKaTzbAFTopW7ebyce/4Sp1LnRuciwb8ov zrfKTEZqkXuAiXYdLJdO1RPcMxP+iSEhL6TFXWJxtc9mGiJT6dynqKgOppieq46c7rex nwaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790660050; x=1791264850; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=vDrRpA1W/7JjCEY/lfrVQceoo3M5nHbNKEhFmkg5umg=; b=cN/n3sz17P+Y9pgeBdGifTULQAJxtvjFrCitw++tDy7No+3fluyISE9ggCy0yR2yrW 051uXFqT5axSmEJB8qmOE89MnN5EO1aKS6QPG5L39xWJINp3KwddcLgOf02IVY/5Umk8 2DmLCpjvlaid0zCWgBcg+W1xApzgmnFlM4/fWCSWkjQtS9IVfmyNptk1/pn/YYoPnwxz 3VRfhXnScRs9N5V12WVYwnYtEO67LyfioNHysGNq2TFXXm7Vnqk8uZ7DAftjhuBMnK4i bohZiOwg5gLdtZAADkgRtVoJC1qfv95cs5MEF4zExspZReTctGUmNwknBU5gRk/du/3L YKLA== X-Forwarded-Encrypted: i=1; AKwUvBxbsdDBtnccHYgrybTzmfLbt9jKlfPgdh6T5Y54G3AAhRfqnLoKzhLIcO06m+uE234h8sE0R+0=@vger.kernel.org X-Gm-Message-State: AFq9FYLpjErroUHmriYoW4a9SPbQVQyD5lBiHebCZ79LPIiFcx2F0v3M TR4v3oiA25gMaEmjPvtbhMH3VUpA3qf1/xJLwHUqOr8n1oVRkM02KaXA X-Gm-Gg: AYBFou0cTFyrMxkqI7voRH1o72fmJBaeU1eVGLrhZYiJPAae0ZwUjliGCGDYR6BDdQx EpGAXt3oNTuKUrLdgbjILoA8Y/slUkkULNtyk9HsXRd5u5+Z+W4f3ojPL22sYu848HX56qLSwrc 2doJJKmZXZzzEpBBv8LG0is0T5jOQz4hqdRoeJxIcgbBSep1f/IDG69LMV64B7TAe9dPs1gVrgG /fzK9CN9mPyo9poqyiReikXmWxiNoHDxGwQmM7hgOKUabmHBiRUyZpi/+1FLni2rIMIH5XvbiOl LMAYq72YlTM0OZ1DysDi/GAmu75kZWyXUjzbJQNR+3qEq9OLgbLBTfJGLJh+1uHD1a7Q5sAtswj rd1Dvqpyrox5wuCV9q/WWD4kT5w6Gfvc8WW9blte+lNJZDms1LRZFd2X0nn3p2KjH6FIRJZwOha UWX8/iJbyxcXYgc/Kjqnn+Gz4z3L9BIGnd+BxuvOXcjT6sqbFf6Xr+mQKbuD0QZy75t9RPryW9y R10SflDsF+yip359V7Xcx+1HhEC11SmVgITCoBBKkcJVblRBrkazSy6sPb0X/aBRWBzuObNs1a0 TCzlx9W75A3nhaghEi73JleFB8duyRVlrHluM1ZN0sklozmNMAkzUIhvzSNTwSjoS1sosyXtxIw = X-Received: by 2002:a5d:5e83:0:b0:488:84bf:eedf with SMTP id ffacd0b85a97d-48884bff147mr15033151f8f.48.1790660049555; Mon, 28 Sep 2026 22:34:09 -0700 (PDT) Received: from unknown748F3CBA5068 (dynamic-2a02-3100-9c32-f801-0451-cc94-d3ca-f56b.310.pool.telefonica.de. [2a02:3100:9c32:f801:451:cc94:d3ca:f56b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48af506fdc1sm1047634f8f.21.2026.09.28.22.34.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Sep 2026 22:34:08 -0700 (PDT) Date: Tue, 29 Sep 2026 07:34:06 +0200 From: Karl Mehltretter To: Jeremy Kerr Cc: Matt Johnston , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , netdev@vger.kernel.org, Geert Uytterhoeven , Brendan Higgins , David Gow , Rae Moar , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2] net: mctp: Make KUnit tests depend on flow support Message-ID: References: <20260925192510.93840-1-kmehltretter@gmail.com> <20260928205352.30502-1-kmehltretter@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Sep 29, 2026 at 09:02:23AM +0100, Jeremy Kerr wrote: > > This keeps the full flow-test coverage: the suite is available only > > when flow support is enabled, for example by the I2C transport. > > Hardware transports are typically not enabled for kunit test kernels. > > Are you attempting to fix an actual problem you're encountering? What's > the aim with this change? > Hi Jeremy, It's no real-world MCTP workload bug. This came from a similar issue in my 842 KUnit patch: the test selected the decompressor. Geert pointed out that tests should not silently enable otherwise-unused code: https://lore.kernel.org/r/CAMuHMdVcZ5cV4-HrjLYfFKh6UshiVxq5eXCNyp0Z1k_SMAvF5g@mail.gmail.com/ My goal is to keep KUNIT_ALL_TESTS from pulling in otherwise-unused production code. An explicit opt-in could preserve the coverage, following CRC_ENABLE_ALL_FOR_KUNIT and CRYPTO_LIB_ENABLE_ALL_FOR_KUNIT: - MCTP_ENABLE_ALL_FOR_KUNIT depends on KUNIT=y and MCTP=y - it selects MCTP_FLOWS - all_tests.config enables it - MCTP_TEST depends on MCTP_FLOWS This keeps KUNIT_ALL_TESTS from enabling optional flow code, while the explicit kunit.py run --alltests profile opts into it and retains full flow coverage without requiring a hardware transport. Would that approach work for you? Karl