From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pz2-f41.google.com (mail-pz2-f41.google.com [74.125.228.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D3A14E1C93 for ; Tue, 29 Sep 2026 21:29:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790717369; cv=none; b=f4i8mJi5vbAvUCmncRt+GIuQez2U04XUtguMT6El5BhV68WNAjXID6+OhLNMFlXW7h48hG019SuUmIpKfSwnaYkCjqSJUPJzZ1SzVmGm6tnptepD+4LQ/Ih3l4B8945/HcaTT/UTc4cW1sn3yXqOhlFHeWteX6VFoCxl7zG1fxc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790717369; c=relaxed/simple; bh=ySN2jKS9dHhRYoH81doQjhzbQkfdJK+9O/ToilcRwv8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WL1Qt5Pyh6vWugoSOpR3kmS9lN+UMs6SQ9INTDV/vncwYlmnyk5RGpGBbVRcNYz7MeK1ohZ4Gtd0tf6kzmy7GaDltZR6eIeS7NOSU79Lax3ve4zazvgJHMEoLBHsRARW4aNY6NBz3mgfraYZPx45HefH8w6Ngoy8g/pHluSz/Y0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b=qGfmpJKz; arc=none smtp.client-ip=74.125.228.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b="qGfmpJKz" Received: by mail-pz2-f41.google.com with SMTP id d2e1a72fcca58-85469d249c6so2913312b3a.1 for ; Tue, 29 Sep 2026 14:29:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20251104.gappssmtp.com; s=20251104; t=1790717367; x=1791322167; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date:from :to:cc:subject:date:message-id:reply-to:content-type; bh=EyT+xHf5qLUoWCtLPqQerMtkJAwK/AAEHgHwEUT5UR4=; b=qGfmpJKz22igcyl9HcOLCLgvlRDeS/1M3cjnnD4BXcDLJflIYjqgJs3Ut7SfZCklSJ km1knV6Gi+pPUH2b1/jCh2b/Da3tCx4bOtQkQfS6E/EQSce2+MrvaQhMz1PeXhQ5cUU6 wRpKipD7qRJFrGzliGOQbzw88Jkc7tO9uSuMTQN0TQLkQs8txBZppFw2/u9LMNN0h6oj htqKYumDqoTygRGUiQKONS44Bo+pTDkTV0YbKTOcSHXBONRtzjW6D+rAgl/CcFIhxG6D WDzJpHB/1Ec04i1nC7KXTCxJ/Qs5aHNYmfqtLVacUBb+mcF2iVCeP9yJHj8gmJVpq37p OEAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790717367; x=1791322167; h=in-reply-to:content-disposition:content-type:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=EyT+xHf5qLUoWCtLPqQerMtkJAwK/AAEHgHwEUT5UR4=; b=bMGo6yrm0C93Bx6crUj5Jqwm9CbxytYcb5+37cdMSvN5f3m9kZvahefcEA/aNhcOEZ qbK8aB4mL1mS/4qjfWzfu+uBG4MccRfZaV96d7LKHy/MVGVUQCk2mbHmzImTyGfNKnFT PwsCoxS9FOy0Uqbb4j0gyHMwjx2Z5BkjiwQZ18NTyeKv86/dH/HqIvt7A9fiYPnk8ydh hfdorAHTC791ywGFIQ8xtyaDTB0j2c3C48utD9jLOHZExOF9JAsH0TQr7bny9XUON0Wv tcCtU1ZsH/d9XL9ejmsxQlDRvr8jvUzMys8EAWgIt9RHUsfcjlH5VhBltuKu81eOiEPq /cXQ== X-Forwarded-Encrypted: i=1; AKwUvBxuv4L/Ogi97sgeTg1DcbQyflH1E9w7y3KeCuyMiR0RAogYgrPt5DYUb/mYkPLRlrwGDtleT5A=@vger.kernel.org X-Gm-Message-State: AFuF++npIJ1vHACVf2QhrktbjiTb4rbHCx4lrpmTsh7kOyaT0jQsNkBF zh1EQqEr7iP/sH/XAVaTzE41roAk74/QNrT4ms/ZR6/eGaEalHpe1CTdfEKkNnslokI= X-Gm-Gg: AYBFou3ISzxivMbm6zTZPzAYZxAC/ta/I2I2M81oF7Ktp05/HkFbeGLzlYxm1QoiKHL 9VAO8YoJQ+JgZgRmIyMx3gmW7j6ay3+BNbhFX6zEB1enljcpgDgk8jIe2fiYEzdVG+QLYZv6cob xRJSHl+eH5KQZYpd0u/VIJ1cfg+uA2yUDlJLa5G7UHSjgoPamlpnJ3RK7Gkw9eixxW4eOHFlwW1 ZNn4U48iLxi9SAvCsxkIQK0cPEG1UHbpxs3phJaz4zAlgXR5U2Jb+x9c5ZsFtqVd2RD5idH5RZ7 JW/ZEmRDjQKUBMcNm99iI+0m0dVShz80JGLsmKWGZb6PNC54zG2OdkvEG6PjQeoIyYER4cMenT7 tDk6kvY7icbtwJZ6b9c7noGb5VKPqyYBfPMVadi+ssjTRXUQtNN4jRGW+UTV0isSbacZmGwtgtw py14D9oAF1y5B1SqXVdtPqivsJfEWLXYoHOlVheKUNb72jEXKqVGrPORgLepzO7lDooktYz8DoA KRwH2l8vx5Z X-Received: by 2002:a05:6a00:4186:b0:881:f5e1:6e7f with SMTP id d2e1a72fcca58-886c48b54bcmr338925b3a.31.1790717366754; Tue, 29 Sep 2026 14:29:26 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:57::]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8868866150bsm495163b3a.3.2026.09.29.14.29.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Sep 2026 14:29:26 -0700 (PDT) Date: Tue, 29 Sep 2026 14:29:25 -0700 From: Joe Damato To: Frank.Li@oss.nxp.com Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Bartosz Golaszewski , Andre Przywara , bui duc phuc , Arnd Bergmann , Kees Cook , Li Youhong , Frank Li , "open list:NETWORKING DRIVERS" , "moderated list:ARM/Allwinner sunXi SoC support" , "open list:ARM/Allwinner sunXi SoC support" , open list , vkoul@kernel.org, imx@lists.linux.dev Subject: Re: [PATCH 1/1] net: allwinner: remove dmaengine_desc_free() Message-ID: Mail-Followup-To: Joe Damato , Frank.Li@oss.nxp.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Bartosz Golaszewski , Andre Przywara , bui duc phuc , Arnd Bergmann , Kees Cook , Li Youhong , Frank Li , "open list:NETWORKING DRIVERS" , "moderated list:ARM/Allwinner sunXi SoC support" , "open list:ARM/Allwinner sunXi SoC support" , open list , vkoul@kernel.org, imx@lists.linux.dev References: <20260929190640.3516766-1-Frank.Li@oss.nxp.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260929190640.3516766-1-Frank.Li@oss.nxp.com> On Tue, Sep 29, 2026 at 03:06:36PM -0400, Frank.Li@oss.nxp.com wrote: > From: Frank Li > > dmaengine_desc_free() is designed for DMA_CTRL_REUSE. If DMA_CTRL_REUSE > is not set, dmaengine_desc_free() will return -EPERM. > > if (!dmaengine_desc_test_reuse(desc)) > return -EPERM; > > So calling dmaengine_desc_free() does nothing. > dmaengine_terminate_(a)sync() will free all already allocated descriptors. > > Signed-off-by: Frank Li > --- > drivers/net/ethernet/allwinner/sun4i-emac.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) Reviewed-by: Joe Damato