From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pz2-f6.google.com (mail-pz2-f6.google.com [74.125.228.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F6764F55B3 for ; Tue, 29 Sep 2026 23:34:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.6 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790724850; cv=none; b=FT5gIKZ2aM6YToowqy0B/2FNL6CZf7iRn1axKNZhNK1iiJ8Xrcc0loxeSa2ZBMN8r8MkEBVyfBiawNG6kQ5onNVxTUQeFdJWLjiisGZSLnu9haaipbFr6SuWCeWtZJpWwMoucb7FJrIL1dJtTafJTKJbo8XcBxF14hTXB/ososI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790724850; c=relaxed/simple; bh=g2ww5Lqb0Gb1kN7QhMJgAUu5t3a+4EhytDztTbBIkcU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UFq3kfBNqnwi5qIldX3cSP1sj8gmP1Yh9q9LmabeczSnRXbipedMz6zgYvslacwXnr3kzhwk3iU3B2oIVKrR5UJVFzuAMhRy5LwVAopEYm0vmcZOBCzQFZ8IDlEGaoHWW4qOCkpgnoqNHd9Z0TG9Cxv8E4b6G+f9ZgvGIa5GZTg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LIAps85P; arc=none smtp.client-ip=74.125.228.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LIAps85P" Received: by mail-pz2-f6.google.com with SMTP id 41be03b00d2f7-cc790c60953so988380a12.1 for ; Tue, 29 Sep 2026 16:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790724848; x=1791329648; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=cafH7Zvbqt9FpZhYTPG4v0LA/vMmRbIjvfxM/sznOEo=; b=LIAps85PJbXqMVynQ7G3yj8cmeBT8nouQP9659f8Uj3wKkNT54Z49UfyHNMdv8UxL5 xHueqladid4/dg8HO5Ku8dSA53TVdYyhTXxtd6jDXYFu+JNDh4hfZ99yiq4nLivek6T4 6vzM3OVp4Q24yIgLXaqMNdnNb8ZbJx8imi/8nu30J4pQdc4kISXCX+WoTPjy4luey3RW OoPwbxq32o849SD1CBICXPU4jxc/SyJSNCPopG86P1VW++1/tLYYzFeaKVhEzVLAbjOI M9uuguhgF62NyMis0ZUX+smKHSJtVdubt7TvOBFx03Akr/Z0S8X3vC1VRLeR43aFyFLO XGyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790724848; x=1791329648; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=cafH7Zvbqt9FpZhYTPG4v0LA/vMmRbIjvfxM/sznOEo=; b=abgnt0uc/XXJGMpbsewBlc6jkRow342QKargqQccMmLeHQnE66YcnGyMh7C+mivgvc gLL7y5HqYAX2Vqg0U0ACPWIKKmpnUC5qKVTiRx7eS2uuJpeowiPAQ557tNjGQ7zaq9Ab GhoetWW9BALTqjwqGLiF524JDUGk6w8NzyhC2NzlO2LSV0KzJKDxaVweLiVtlrq7oWX4 W2frMs0tEma941hozOOjApqkUZeF5cmDMq6hc4JOwyElyiGUT2c/lWshzeixbvBvGZcF LWZOdWd4CGpOq/FO/JAmhWeHMTR8sFeAusKPU0IgwjHoGyp/qhQDFbgzBOy6gSBehC97 zKEQ== X-Forwarded-Encrypted: i=1; AKwUvBytc4CIEnwVJ4fNbSfP8RuWP17n00lhKlwLGKK7XHulTtcZvQeRBX/zZHe+hP3Mne+3ohz7rf8=@vger.kernel.org X-Gm-Message-State: AFuF++mtUrmwvrs0fmEK7o+JVaYITglSk7XnikNgZeajk909/bHmPv3i xnhbiQ3lozslQXSBN0VauWu8c7pX0gKFmVtq3eRD3xxC2p23L02wqd16 X-Gm-Gg: AYBFou23V/X7JKEVeX8Dd20h/oWqJAXaCNzajbzLNjwALzVcmNj9x1F0KytH0/VQBEP H3Y0MLhnS8OCJTNffpStFhqLjjGNkxBicaGFk2g16mAkjpr2ibKQpRFPhIsJoovqZ1hhdbfkm19 ZDySjf5rpWLgDrb0Rj4rGfwubCWfq+OZMpW/Cm11vsdU/N7xsmFnRnc5Jr7mFcrA+XheRyF2wjH 3tfSYx/HGYNVYMpE/uM2B7as42QNJ9Ga4kfLIxJ/D60lQgBTY2le+CzEVkSW3QIMFuXSX5x0cSY lxUiH9sBqeyV5o3VoEucXCFgSqAINLxt+eYZ4qoAknZPjjHGRLglBoB+WRfJfAelybmpyuJHaDq trt+r5Fq388oedGJjLuS/A99/xNxCHynjbkvdDhUptcvp+bELS84+B5CYTRamXd6wGPLgkxKtRi J6GjkLUKTz9UkMJwLa+rwx5oMgInr1Q40/5PIl4Z2LVFwbmworjBWbnaPmBBAJE7C6 X-Received: by 2002:a05:6a00:1302:b0:880:78ca:8408 with SMTP id d2e1a72fcca58-886c18bf7fcmr577525b3a.7.1790724848564; Tue, 29 Sep 2026 16:34:08 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:4e::]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8868cbca29fsm519003b3a.47.2026.09.29.16.34.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Sep 2026 16:34:08 -0700 (PDT) Date: Tue, 29 Sep 2026 16:32:58 -0700 From: Stanislav Fomichev To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org, jv@jvosburgh.net, hawk@kernel.org, sdf@fomichev.me, emil@etsalapatis.com, liuhangbin@gmail.com, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, willemdebruijn.kernel@gmail.com, aleksander.lobakin@intel.com Subject: Re: [PATCH net-next 4/5] selftests/bpf: check XDP attach on a nested bond slave Message-ID: References: <20260928223648.2739371-1-kuba@kernel.org> <20260928223648.2739371-5-kuba@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260928223648.2739371-5-kuba@kernel.org> On 09/28, Jakub Kicinski wrote: > test_xdp_bonding_attach() already covers a flat bond both ways round: > the master is refused while a slave has a program, and a slave is > refused while the master has one. The nested test only ever checked > that attaching to the outermost master succeeds. > > That left the more interesting half of the nesting untested. Only the > direct upper is consulted when deciding whether a device is already > running XDP, so with bond -> bond_nest1 -> bond_nest2 the check on > bond_nest2 looks at bond_nest1, and it only sees a program there if > bond_nest1 recorded the one it was handed. Before the preceding fix it > did not, and a second program could be attached to bond_nest2 while the > outer bond's program was already running on it. > > Signed-off-by: Jakub Kicinski Acked-by: Stanislav Fomichev