From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta0.migadu.com (out-216.mta0.migadu.com [91.218.175.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47B4B12AAF1 for ; Wed, 30 Sep 2026 00:44:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.216 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790729097; cv=none; b=iuGh1MLGegM3frLKxdjBY8qF3l1tdNNirIsn5QLnGUhojQhTMWSdl8C00q9dNPGtak3XZkSwWlcgvEcIvOkY3IRX4ytk8RrO8YZsl2Yq0mMMDXd2GWLLitIQYbmF7NGsKOHe91X9KJJXA85HayLmcdVq4cyXwJ7adoo+jW1rxD4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790729097; c=relaxed/simple; bh=W91u3TgYrbEqLP/J9ErVZDmABK2bkne8JKBKTA9CbAk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cYkJBJ0rRv/Nq+XXAEuHTRm6dvPQGw1OZVnT8nNBqWPzuyzZvuR862cg62PzjK1Jx2Mypa7lzYj4psM8TIF2+VluvCpuoPRnh6BRGCf/EYGGGkLUFn0W1eCoD2X3kRHbQRQDhgKvN8QsiQGUSvwztr/ZLn5PMbK5h+pWRwLVGMA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=RP5QF2Qx; arc=none smtp.client-ip=91.218.175.216 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="RP5QF2Qx" X-Envelope-To: netdev@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=W91u3TgYrbEqLP/J9ErVZDmABK2bkne8JKBKTA9CbAk=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1790729094; v=1; x=1791333894; b=RP5QF2Qxw60C2OMBz6Aj/V6201+g46cOdKKGiV7iYhauCsmVwxhyW6YVh242wRpJTKUlpxs7 D1bEDAsQnO1R73aeTW3z6WaDzTkaqID85LfcW118fDLj3HElNk8+s/4H1/3R+QhSRHjd35Kxvdu u2Blv4ceTeXt7zM3+xtDxIQE= X-Envelope-To: netdev@vger.kernel.org Received: by mta11.migadu.com with ESMTPS id 4d3262d6c007ba2e; Wed, 30 Sep 2026 00:44:44 +0000 X-Mizu-Trace-ID: 4d3262d6c007ba2e X-Migadu-Flow: FLOW_OUT Date: Wed, 30 Sep 2026 08:44:34 +0800 From: Hangbin Liu To: Andrea Mayer Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , David Ahern , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, David Lebrun , Stefano Salsano Subject: Re: [PATCH net] seg6: ensure packet data is writable before modifying SRH and IPv6 DA Message-ID: References: <20260925133807.32-1-andrea.mayer@uniroma2.it> <20260930013910.ef20606a1141e83edeee0771@uniroma2.it> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260930013910.ef20606a1141e83edeee0771@uniroma2.it> On Wed, Sep 30, 2026 at 01:39:10AM +0200, Andrea Mayer wrote: > On Tue, 29 Sep 2026 11:05:02 +0800 > Hangbin Liu wrote: > > > [snip] > > > > > static int input_action_end_core(struct sk_buff *skb, > > > struct seg6_local_lwt *slwt) > > > { > > > + enum skb_drop_reason reason = SKB_DROP_REASON_NOT_SPECIFIED; > > > struct ipv6_sr_hdr *srh; > > > + int err = -EINVAL; > > > > > > srh = get_and_validate_srh(skb); > > > if (!srh) > > > goto drop; > > > > > > - advance_nextseg(srh, &ipv6_hdr(skb)->daddr); > > > + srh = advance_nextseg(skb, srh, &reason); > > > + if (!srh) { > > > + err = -ENOMEM; > > > + goto drop; > > > + } > > > > The srh is not used in the later function, maybe just > > > > if (!advance_nextseg(skb, srh, &reason)) { > > err = -ENOMEM; > > goto drop; > > } > > > > [snip] > > Hi Hangbin, > > Right. Since the patch changed advance_nextseg() to return the SRH, > I updated srh at every call site. Your form works as well where srh > is not used afterwards. Never mind. I replied to your patch too late. It has been merged into net. Thanks Hangin