From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C6893A4F50 for ; Tue, 13 Oct 2026 08:32:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791880328; cv=none; b=dJPTZljFp7ZMuJj5legWm92dqIKZCEIs0cbO+GuSBk19dJ84ehRhr6LLIY1IgvmQIkFVI8oMPbvKC86M/pILkU/GquT+zLVhNg5KJkuzGPcskjS8lyQBo4IMyIIz0cotThRn6HUJzFPjlRctWTiWuAI4ka6q3ChBQH1WUlm5H+U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791880328; c=relaxed/simple; bh=4zMpqhZ55rJCQzknkvOqC1dZoM+uAeq64ZXJDJRKCSM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mrMvOGYewCNlXxb+QICK1RaHTUEN5Lz1lTThyl71/5Z1oSr01I0QxQWd+Kav2i3LDlifqLQPCfuZVFrQUr3pABB8ORac9IrtPph6ZAajkJs+t7lpxA++nfYcRvITtx4fzSUSQDoHx6wOL1MWt/r2rQfKYDWY4XOVBGAMZXEwmI4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RhqBEOSN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bu2owK6P; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RhqBEOSN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bu2owK6P" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69D20r7h302932 for ; Tue, 13 Oct 2026 08:32:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=CgEoCHdTeicYs8dHNwUpBuKb XP9XPOOmwmEWGVwyiIs=; b=RhqBEOSNGGNNo03Tp7noRTWEiLZ3ZuTC5vgd55vq iT45tRxi2JVn8DP1pebcN0MU9e5enClYO99FTYCbn1MDebinMcxVK8JTL3QS8Bn9 qK/BCTH54jcsy2gT5cx7kCfcZy+r55XOK8UZut6ilIzWQ5fuKzutPMWE27SLCf+3 frfr6mH9sTcEnvsIyjTOXXQJ6EkqXamW1HEgzUrZ6M5WCYxvUqR6YSuIE+/mpQte E0ZesVP2OITDNPNmGeIuQUfP0rt8uJLyGldHOecZdxxyQc08crBQBiZekaef1Obx YYViMymHYyE3t9xo6bHC35fwSzXldjZbqe/Sh7ayPxwX6g== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4h98sq9v7b-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 13 Oct 2026 08:32:06 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-93a1de6d5c3so630549785a.3 for ; Tue, 13 Oct 2026 01:32:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1791880326; x=1792485126; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=CgEoCHdTeicYs8dHNwUpBuKbXP9XPOOmwmEWGVwyiIs=; b=bu2owK6Pw4zzLZsKexEbDgaAaohYcj7rQYt5QkNeENFsWQ2PraRNOfPjV6ZRH7Xu/r zQBY9yMZVJDT1Vzcyj15fyI6bRdiq19ESxgMwjOJWYEFe14gYEJhcuIYtlPK9U9CFPjD CmUNQvcYwpgOyFcHMfRk/RqPOkmL6VXEwUBCg9VwJKBrgarkNBWQbprMN4uIcTQqINso HLfHvTK/ejSfOrK7K14U4ab6h5PoMAbtxaRz2ZsgECO+jI0kdaZ1fNpoPbnPo4imQW1y zWUlcPlTp3x3/SEo11O9Ahc1WRySqguuFnGQBOLVwJDVY+ahhx1NZ7nikGIwMKX/Fh+O 46TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791880326; x=1792485126; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=CgEoCHdTeicYs8dHNwUpBuKbXP9XPOOmwmEWGVwyiIs=; b=IhM+VJoxQ2hwbzTuwi003BumO62wP/4s8ySBKxrx1hP8WEdWxPrFRtLvf9v0fGs4JC NvlVgc0Y4S8gpvhArnVDwaThDJ1dvxTXQ9gehBqpbhsh4wqh2L7AYz3LMbQ8BXz94BAz warQMNkzA4LuAkkU2EY9DvvirfvOgsluc8vMx0JeW839jTVLQlUxR9P4tClXuuNAWa5D lzWwN09KXfvOwFQam3iJJ4cyeAU+i2yKQY6w6X5OYhOH/XH+e1q2V+JqTH4G+M1X/mad O0NYiUdRWV9mLdOHLzQj3eQtGIkTWCwmj8fUw3w3XzaO71kIBexXVXNKw7NTtbsVPYgs 6oFg== X-Forwarded-Encrypted: i=1; AKwUvBxvMNQDZ0O4pLiao/wW5JbwOUjTRiqo7WKR82rULEi7xSXkJ2ZoQAc/Dd8JXBJARL82uFuSN6o=@vger.kernel.org X-Gm-Message-State: AFq9FYLSpqDLX0lMoJ8E32h2bBvUn0NG03b8pjD614vIXaWNRaOh6wB4 0dZ37UAXDJxMY+z0yT4cln217mFapJORRoigKhKgCy3aGQFB4Z33i8TudKXB7yyt4wjAxI1Zf0g sHl6N68I53YcFd6qb2s/XaiRWNcwhw60CSmb4eaPQe5IQPyiCD6IJasUXTfo= X-Gm-Gg: AYBFou2iSVxcy5VftcwAQ5Fj8ehlVYOGkPRczqvcQQ9XNIxCTtx75n9m2GkMwQ5iFRJ FaMD0B5DzU4r6O0YPK2iB1lq8KMe7Dxm9IrP9sSsn/GlKarP3nVDOcCDLqdYbEYGsuyIKerMs6b HX0mpjq1Idw7sEcbweRln85uc8APuq8bgxdCR4xF+0CyXwDDdjqPbNhD7eoZXQgoivas9Pwj5gu 88sdC5Sp0hfRGVZnfwz1QOZ5H8t9dlbeiOxKPoOgLs77Q+gswVNkgvWLLH9jq69AJ4IuMQUfQAO h4GFokCbqEj8AjZyq5pTH9pQqk4BFf3FKNvUwtyafQSr/fJGRrXTDBt1+0+l5xok0v3wffPDmuf /+luqM/+NlNA0VQ== X-Received: by 2002:a05:620a:3720:b0:93e:5eaf:dd87 with SMTP id af79cd13be357-93ebd2a05fbmr1975435185a.62.1791880325497; Tue, 13 Oct 2026 01:32:05 -0700 (PDT) X-Received: by 2002:a05:620a:3720:b0:93e:5eaf:dd87 with SMTP id af79cd13be357-93ebd2a05fbmr1975431485a.62.1791880324843; Tue, 13 Oct 2026 01:32:04 -0700 (PDT) Received: from localhost ([188.216.77.92]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a19f249692sm280651825e9.3.2026.10.13.01.32.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2026 01:32:03 -0700 (PDT) Date: Tue, 13 Oct 2026 10:32:03 +0200 From: Lorenzo Bianconi To: Nicolai Buchwitz Cc: Maxime Chevallier , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Jose Abreu , Ong Boon Leong , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org Subject: Re: [PATCH net-next v6 3/4] net: stmmac: drop multi-buffer frames in XDP mode Message-ID: References: <20261012-stmmac-rx-mb-v6-0-2225050915c1@oss.qualcomm.com> <20261012-stmmac-rx-mb-v6-3-2225050915c1@oss.qualcomm.com> <3a483a6fbd86f50a02435932fe4a7ea3@tipi-net.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3qwKvKFoaOiXYisH" Content-Disposition: inline In-Reply-To: <3a483a6fbd86f50a02435932fe4a7ea3@tipi-net.de> X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDEzMDAzMyBTYWx0ZWRfXytMgDdN5blkL 1g3w0IlVUfD5Bo2fS9EmBSq8+o/dSobQFcWz13fI65JlDP+jEyN1dbO4LnE+DdoqM3jHOvXKUgM pcmmyVb9dIiyxI7XaBZBM8eWR2FsvKWdG3FpOiwwdbkyeHbBH7G1krTmVIqatoJAs7lDcB5Wblf QixYrP7a5BHOugYIDchyNiXZDI2kdqY/r6lUcsb9KrndGi54LCocyno9yZBwV8eCHAzKq7upzgU ZHM9+svVTC/LxVSTCl/f6QgY5Hix76MvkMsy3q1qZnS2D0wR6NSAoM289Ms0XAqrfAaVH9VtpIA MAtcqkPFWK5RlpLQY7l0K8Fk9huRinfs3ocMOoGhKKF2GvJxAcKfAXVe3XiylVw6YZ/4Ar3NXQB TBBUATH95AeB45Z7+gYKb0lwJHpXZx2ikbkCGxuMnWwS4n7pmE/ObgGDfL/zrbyhQwb3bOueiFt 1g2zSTIoXKK8Kh4n8bg== X-Authority-Analysis: v=2.4 cv=JN+uIMKb c=1 sm=1 tr=0 ts=6acdec86 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=WpTaRW6qxYHRGzLzQsVYzg==:17 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VeR9IiojQdXVVGmY0-kA:9 a=CjuIK1q_8ugA:10 a=hNWK7rNVVTdq26VXPtYA:9 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDEzMDAzMyBTYWx0ZWRfX9lfHOysMk3b1 MijplaTLowuC+c2d9nUXDs8RFa1n5vqlmVZeUyURNYQVgWrKFe883XR7aQ4G+qILSd+QGQHeZsu 7J/lFRS+wpmqdyl8wMIMJlxbdl3/JRw= X-Proofpoint-ORIG-GUID: gVy9JYB23mYEsOF2i0LkyTOv0glO17Ik X-Proofpoint-GUID: gVy9JYB23mYEsOF2i0LkyTOv0glO17Ik X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-13_01,2026-10-09_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 priorityscore=1501 adultscore=0 suspectscore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610130033 --3qwKvKFoaOiXYisH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Oct 13, Nicolai Buchwitz wrote: > Hi Lorenzo >=20 > On 13.10.2026 10:17, Lorenzo Bianconi wrote: > > On Oct 12, Nicolai Buchwitz wrote: >=20 > > [...] >=20 > > > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > > > b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > > > index 426bb68c9bbc..8c08d44fdbd3 100644 > > > > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > > > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > > > @@ -5893,18 +5893,24 @@ static int stmmac_rx(struct stmmac_priv *pr= iv, > > > > int limit, u32 queue) > > > > > > > > if (priv->extend_desc) > > > > stmmac_rx_extended_status(priv, &priv->xstats, rx_q->dma_erx + > > > > entry); > > > > - if (unlikely(status =3D=3D discard_frame)) { > > > > - page_pool_put_page(rx_q->page_pool, buf->page, 0, true); > > > > - buf->page =3D NULL; > > > > + > > > > + if (unlikely(!error && status =3D=3D discard_frame)) { > > > > error =3D 1; > > > > if (!priv->hwts_rx_en) > > > > rx_errors++; > > > > } > > > > > > > > - if (unlikely(error && (status & rx_not_ls))) > > > > - goto read_again; > > > > + /* We do not support SG in XDP mode */ > > > > + if (unlikely(!error && (status & rx_not_ls) && > > > > + stmmac_xdp_is_enabled(priv))) { > > > > + rx_dropped++; > > > > + error =3D 1; > > > > + } > > >=20 > > > AFAIU GMAC4 and XGMAC always use the second buffer of a descriptor. If > > > so, at MTU 1500 a frame of up to 3072 bytes can fit in one descriptor, > > > and this check would not catch it? > > >=20 > > > The XDP program would then only see the first buffer. With XDP_TX the > > > frame is cut and sent too short. With XDP_PASS the second buffer is > > > added > > > after the program already decided. > > >=20 > > > Patch 4 fixes this. But if this patch should work on its own, should > > > it > > > also drop the frame when buf2_len is not zero? Or am I missing > > > something? > >=20 > > Hi Nicolai, > >=20 > > IIUC your comment we are missing the case where we have a single > > descriptor > > (rx_not_ls is not set in status) but the packet is splitted over buf1 > > and buf2, > > right? Something like: > >=20 > > ... > > buf2_len =3D stmmac_rx_buf2_len(priv, p, status, len); > > len +=3D buf2_len; > >=20 > > if (unlikely(stmmac_xdp_is_enabled(priv) && buf2_len)) { > > rx_dropped++; > > dev_kfree_skb(skb); > > goto next; > > } > > ... > >=20 > > Is my understanding correct? >=20 > Yes, exactly. >=20 > I think skb is always NULL there in XDP mode, so the dev_kfree_skb() > can go. Both pages stay in the slot and stmmac_rx_refill() reuses them, > so nothing leaks. >=20 > Maybe extend the "We do not support SG in XDP mode" comment to cover > this case too. ack, thx for the review. I will fix it in v7. Regards, Lorenzo >=20 > > [...] >=20 > Thanks, > Nicolai --3qwKvKFoaOiXYisH Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCas3sgwAKCRA6cBh0uS2t rEjBAP9gErlRqvxFcDyFsfPFSFOkj0MTST4iWeXLN6NZgNjN7wD8DWWqfrjLXqPl Dp1q1qQAQUSjZYRFz2ogR2tzHG0Eeg4= =mHzj -----END PGP SIGNATURE----- --3qwKvKFoaOiXYisH--